Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
70419b5e
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
70419b5e
编写于
5月 19, 2014
作者:
R
Rafael Mendonça França
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #18 from mperham/param_whitelist
Whitelist legal job parameter types
上级
3a932bf0
575a837d
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
18 addition
and
7 deletion
+18
-7
lib/active_job/parameters.rb
lib/active_job/parameters.rb
+7
-3
test/cases/parameters_test.rb
test/cases/parameters_test.rb
+11
-4
未找到文件。
lib/active_job/parameters.rb
浏览文件 @
70419b5e
...
...
@@ -3,13 +3,17 @@
module
ActiveJob
class
Parameters
TYPE_WHITELIST
=
[
NilClass
,
Fixnum
,
Float
,
String
,
TrueClass
,
FalseClass
,
Hash
,
Array
]
def
self
.
serialize
(
params
)
params
.
collect
{
|
param
|
param
.
try
(
:global_id
)
||
param
}
params
.
collect
do
|
param
|
raise
"Unsupported parameter type:
#{
param
.
class
.
name
}
"
unless
param
.
respond_to?
(
:global_id
)
||
TYPE_WHITELIST
.
include?
(
param
.
class
)
param
.
try
(
:global_id
)
||
param
end
end
def
self
.
deserialize
(
params
)
params
.
collect
{
|
param
|
ActiveModel
::
GlobalLocator
.
locate
(
param
)
||
param
}
end
end
end
\ No newline at end of file
test/cases/parameters_test.rb
浏览文件 @
70419b5e
...
...
@@ -6,11 +6,18 @@ class ParameterSerializationTest < ActiveSupport::TestCase
test
'should make no change to regular values'
do
assert_equal
[
1
,
"something"
],
ActiveJob
::
Parameters
.
serialize
([
1
,
"something"
])
end
test
'should not allow complex objects'
do
err
=
assert_raises
RuntimeError
do
ActiveJob
::
Parameters
.
serialize
([
1
,
self
])
end
assert_equal
"Unsupported parameter type:
#{
self
.
class
.
name
}
"
,
err
.
message
end
test
'should serialize records with global id'
do
assert_equal
[
Person
.
find
(
5
).
gid
],
ActiveJob
::
Parameters
.
serialize
([
Person
.
find
(
5
)
])
end
test
'should serialize values and records together'
do
assert_equal
[
3
,
Person
.
find
(
5
).
gid
],
ActiveJob
::
Parameters
.
serialize
([
3
,
Person
.
find
(
5
)
])
end
...
...
@@ -20,11 +27,11 @@ class ParameterDeserializationTest < ActiveSupport::TestCase
test
'should make no change to regular values'
do
assert_equal
[
1
,
"something"
],
ActiveJob
::
Parameters
.
deserialize
([
1
,
"something"
])
end
test
'should deserialize records with global id'
do
assert_equal
[
Person
.
find
(
5
)
],
ActiveJob
::
Parameters
.
deserialize
([
Person
.
find
(
5
).
gid
])
end
test
'should serialize values and records together'
do
assert_equal
[
3
,
Person
.
find
(
5
)
],
ActiveJob
::
Parameters
.
deserialize
([
3
,
Person
.
find
(
5
).
gid
])
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录