Merge pull request #24939 from Neodelf/again_with_loop

Replacement cycle for readability

activerecord/lib/active_record/associations/association_scope.rb

@@ -124,8 +124,7 @@ def add_constraints(scope, owner, association_klass, refl, chain_head, chain_tai
         scope = last_chain_scope(scope, table, owner_reflection, owner, association_klass)
 
         reflection = chain_head
-        loop do
-          break unless reflection
+        while reflection
           table = reflection.alias_name
 
           unless reflection == chain_tail