提交 60b55bac 编写于 作者: F Frederick Cheung

Take into account time spent in AR even if a redirect occurs or if it is after the render

上级 4ee7d923
......@@ -15,6 +15,17 @@ def show
def zero
render :inline => "Zero DB runtime"
end
def redirect
Project.all
redirect_to :action => 'show'
end
def db_after_render
render :inline => "Hello world"
Project.all
ActiveRecord::LogSubscriber.runtime += 100
end
end
include ActiveSupport::LogSubscriber::TestHelper
......@@ -52,4 +63,19 @@ def test_runtime_reset_before_requests
assert_equal 2, @logger.logged(:info).size
assert_match(/\(Views: [\d.]+ms \| ActiveRecord: 0.0ms\)/, @logger.logged(:info)[1])
end
def test_log_with_active_record_when_redirecting
get :redirect
wait
assert_equal 3, @logger.logged(:info).size
assert_match(/\(ActiveRecord: [\d.]+ms\)/, @logger.logged(:info)[2])
end
def test_include_time_query_time_after_rendering
get :db_after_render
wait
assert_equal 2, @logger.logged(:info).size
assert_match(/\(Views: [\d.]+ms \| ActiveRecord: ([1-9][\d.]+)ms\)/, @logger.logged(:info)[1])
end
end
......@@ -23,8 +23,8 @@ def cleanup_view_runtime
db_rt_before_render = ActiveRecord::LogSubscriber.reset_runtime
runtime = super
db_rt_after_render = ActiveRecord::LogSubscriber.reset_runtime
self.db_runtime = db_rt_before_render + db_rt_after_render
runtime - db_rt_after_render
self.db_runtime = db_rt_before_render + db_during_render
runtime - db_during_render
else
super
end
......@@ -32,7 +32,9 @@ def cleanup_view_runtime
def append_info_to_payload(payload)
super
payload[:db_runtime] = db_runtime
if ActiveRecord::Base.connected?
payload[:db_runtime] = (db_runtime || 0) + ActiveRecord::LogSubscriber.reset_runtime
end
end
module ClassMethods
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册