Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
54a65183
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
54a65183
编写于
12月 28, 2012
作者:
A
Aaron Patterson
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
fix PG typecasting errors
上级
ac659492
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
12 addition
and
22 deletion
+12
-22
activerecord/lib/active_record/relation/calculations.rb
activerecord/lib/active_record/relation/calculations.rb
+5
-2
activerecord/test/cases/calculations_test.rb
activerecord/test/cases/calculations_test.rb
+7
-20
未找到文件。
activerecord/lib/active_record/relation/calculations.rb
浏览文件 @
54a65183
...
...
@@ -241,13 +241,16 @@ def execute_simple_calculation(operation, column_name, distinct) #:nodoc:
select_value
=
operation_over_aggregate_column
(
column
,
operation
,
distinct
)
column_name
=
select_value
.
alias
relation
.
select_values
=
[
select_value
]
query_builder
=
relation
.
arel
end
result
=
@klass
.
connection
.
select_value
(
query_builder
,
nil
,
relation
.
bind_values
)
type_cast_calculated_value
(
result
,
column_for
(
column_name
),
operation
)
result
=
@klass
.
connection
.
select_all
(
query_builder
,
nil
,
relation
.
bind_values
)
row
=
result
.
first
value
=
row
&&
row
.
values
.
first
type_cast_calculated_value
(
value
,
result
.
column_types
[
column_name
],
operation
)
end
def
execute_grouped_calculation
(
operation
,
column_name
,
distinct
)
#:nodoc:
...
...
activerecord/test/cases/calculations_test.rb
浏览文件 @
54a65183
...
...
@@ -8,6 +8,7 @@
require
'models/topic'
require
'models/minivan'
require
'models/speedometer'
require
'models/ship_part'
Company
.
has_many
:accounts
...
...
@@ -33,8 +34,9 @@ def test_should_return_decimal_average_of_integer_field
end
def
test_should_return_integer_average_if_db_returns_such
Account
.
connection
.
stubs
:select_value
=>
3
value
=
Account
.
average
(
:id
)
ShipPart
.
delete_all
ShipPart
.
create!
(
:id
=>
3
,
:name
=>
'foo'
)
value
=
ShipPart
.
average
(
:id
)
assert_equal
3
,
value
end
...
...
@@ -416,34 +418,19 @@ def test_maximum_with_from_option
def
test_maximum_with_not_auto_table_name_prefix_if_column_included
Company
.
create!
(
:name
=>
"test"
,
:contracts
=>
[
Contract
.
new
(
:developer_id
=>
7
)])
# TODO: Investigate why PG isn't being typecast
if
current_adapter?
(
:PostgreSQLAdapter
)
||
current_adapter?
(
:MysqlAdapter
)
assert_equal
"7"
,
Company
.
includes
(
:contracts
).
maximum
(
:developer_id
)
else
assert_equal
7
,
Company
.
includes
(
:contracts
).
maximum
(
:developer_id
)
end
assert_equal
7
,
Company
.
includes
(
:contracts
).
maximum
(
:developer_id
)
end
def
test_minimum_with_not_auto_table_name_prefix_if_column_included
Company
.
create!
(
:name
=>
"test"
,
:contracts
=>
[
Contract
.
new
(
:developer_id
=>
7
)])
# TODO: Investigate why PG isn't being typecast
if
current_adapter?
(
:PostgreSQLAdapter
)
||
current_adapter?
(
:MysqlAdapter
)
assert_equal
"7"
,
Company
.
includes
(
:contracts
).
minimum
(
:developer_id
)
else
assert_equal
7
,
Company
.
includes
(
:contracts
).
minimum
(
:developer_id
)
end
assert_equal
7
,
Company
.
includes
(
:contracts
).
minimum
(
:developer_id
)
end
def
test_sum_with_not_auto_table_name_prefix_if_column_included
Company
.
create!
(
:name
=>
"test"
,
:contracts
=>
[
Contract
.
new
(
:developer_id
=>
7
)])
# TODO: Investigate why PG isn't being typecast
if
current_adapter?
(
:MysqlAdapter
)
||
current_adapter?
(
:PostgreSQLAdapter
)
assert_equal
"7"
,
Company
.
includes
(
:contracts
).
sum
(
:developer_id
)
else
assert_equal
7
,
Company
.
includes
(
:contracts
).
sum
(
:developer_id
)
end
assert_equal
7
,
Company
.
includes
(
:contracts
).
sum
(
:developer_id
)
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录