提交 504e5e10 编写于 作者: C Claudio B

Merge pull request #22060 from sebmck/tweak-wording

Tweaked wording used in some tests.
......@@ -93,13 +93,13 @@ def call(env)
assert_kind_of AbstractController::ActionNotFound, env["action_dispatch.exception"]
assert_equal "/404", env["PATH_INFO"]
assert_equal "/not_found_original_exception", env["action_dispatch.original_path"]
[404, { "Content-Type" => "text/plain" }, ["YOU FAILED BRO"]]
[404, { "Content-Type" => "text/plain" }, ["YOU FAILED"]]
end
@app = ActionDispatch::ShowExceptions.new(Boomer.new, exceptions_app)
get "/not_found_original_exception", headers: { 'action_dispatch.show_exceptions' => true }
assert_response 404
assert_equal "YOU FAILED BRO", body
assert_equal "YOU FAILED", body
end
test "returns an empty response if custom exceptions app returns X-Cascade pass" do
......
......@@ -83,10 +83,10 @@ def test_has_many_and_belongs_to_automatic_inverse_shares_objects_on_rating
assert_equal rating.comment, comment, "The Rating's comment should be the original Comment"
rating.comment.body = "Brogramming is the act of programming, like a bro."
rating.comment.body = "Fennec foxes are the smallest of the foxes."
assert_equal rating.comment.body, comment.body, "Changing the Comment's body on the association should change the original Comment's body"
comment.body = "Broseiden is the king of the sea of bros."
comment.body = "Kittens are adorable."
assert_equal comment.body, rating.comment.body, "Changing the original Comment's body should change the Comment's body on the association"
end
......@@ -97,10 +97,10 @@ def test_has_many_and_belongs_to_automatic_inverse_shares_objects_on_comment
assert_equal rating.comment, comment, "The Rating's comment should be the original Comment"
rating.comment.body = "Brogramming is the act of programming, like a bro."
rating.comment.body = "Fennec foxes are the smallest of the foxes."
assert_equal rating.comment.body, comment.body, "Changing the Comment's body on the association should change the original Comment's body"
comment.body = "Broseiden is the king of the sea of bros."
comment.body = "Kittens are adorable."
assert_equal comment.body, rating.comment.body, "Changing the original Comment's body should change the Comment's body on the association"
end
......
......@@ -72,11 +72,11 @@ def flush(*)
test "keeps each tag in their own thread" do
@logger.tagged("BCX") do
Thread.new do
@logger.tagged("OMG") { @logger.info "Cool story bro" }
@logger.tagged("OMG") { @logger.info "Cool story" }
end.join
@logger.info "Funky time"
end
assert_equal "[OMG] Cool story bro\n[BCX] Funky time\n", @output.string
assert_equal "[OMG] Cool story\n[BCX] Funky time\n", @output.string
end
test "keeps each tag in their own instance" do
......@@ -84,11 +84,11 @@ def flush(*)
@other_logger = ActiveSupport::TaggedLogging.new(MyLogger.new(@other_output))
@logger.tagged("OMG") do
@other_logger.tagged("BCX") do
@logger.info "Cool story bro"
@logger.info "Cool story"
@other_logger.info "Funky time"
end
end
assert_equal "[OMG] Cool story bro\n", @output.string
assert_equal "[OMG] Cool story\n", @output.string
assert_equal "[BCX] Funky time\n", @other_output.string
end
......@@ -97,11 +97,11 @@ def flush(*)
Thread.new do
@logger.tagged("OMG") do
@logger.flush
@logger.info "Cool story bro"
@logger.info "Cool story"
end
end.join
end
assert_equal "[FLUSHED]\nCool story bro\n", @output.string
assert_equal "[FLUSHED]\nCool story\n", @output.string
end
test "mixed levels of tagging" do
......
......@@ -48,7 +48,7 @@ def index
test "uses custom exceptions app" do
add_to_config <<-RUBY
config.exceptions_app = lambda do |env|
[404, { "Content-Type" => "text/plain" }, ["YOU FAILED BRO"]]
[404, { "Content-Type" => "text/plain" }, ["YOU FAILED"]]
end
RUBY
......@@ -56,7 +56,7 @@ def index
get "/foo"
assert_equal 404, last_response.status
assert_equal "YOU FAILED BRO", last_response.body
assert_equal "YOU FAILED", last_response.body
end
test "url generation error when action_dispatch.show_exceptions is set raises an exception" do
......@@ -67,7 +67,7 @@ def index
end
end
RUBY
app.config.action_dispatch.show_exceptions = true
get '/foo'
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册