Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
4877737f
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
4877737f
编写于
5月 16, 2014
作者:
R
Rafael Mendonça França
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #15071 from leafac/issues/11985
Fix `Relation#delete_all` inconsistency
上级
ec43d954
5866437e
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
18 addition
and
4 deletion
+18
-4
activerecord/lib/active_record/relation.rb
activerecord/lib/active_record/relation.rb
+13
-3
activerecord/test/cases/relations_test.rb
activerecord/test/cases/relations_test.rb
+5
-1
未找到文件。
activerecord/lib/active_record/relation.rb
浏览文件 @
4877737f
...
...
@@ -12,6 +12,7 @@ class Relation
SINGLE_VALUE_METHODS
=
[
:limit
,
:offset
,
:lock
,
:readonly
,
:from
,
:reordering
,
:reverse_order
,
:distinct
,
:create_with
,
:uniq
]
INVALID_METHODS_FOR_DELETE_ALL
=
[
:limit
,
:distinct
,
:offset
,
:group
,
:having
]
VALUE_METHODS
=
MULTI_VALUE_METHODS
+
SINGLE_VALUE_METHODS
...
...
@@ -430,12 +431,21 @@ def destroy(id)
# If you need to destroy dependent associations or call your <tt>before_*</tt> or
# +after_destroy+ callbacks, use the +destroy_all+ method instead.
#
# If a
limit scope
is supplied, +delete_all+ raises an ActiveRecord error:
# If a
n invalid method
is supplied, +delete_all+ raises an ActiveRecord error:
#
# Post.limit(100).delete_all
# # => ActiveRecord::ActiveRecordError: delete_all doesn't support limit
scope
# # => ActiveRecord::ActiveRecordError: delete_all doesn't support limit
def
delete_all
(
conditions
=
nil
)
raise
ActiveRecordError
.
new
(
"delete_all doesn't support limit scope"
)
if
self
.
limit_value
invalid_methods
=
INVALID_METHODS_FOR_DELETE_ALL
.
select
{
|
method
|
if
MULTI_VALUE_METHODS
.
include?
(
method
)
send
(
"
#{
method
}
_values"
).
any?
else
send
(
"
#{
method
}
_value"
)
end
}
if
invalid_methods
.
any?
raise
ActiveRecordError
.
new
(
"delete_all doesn't support
#{
invalid_methods
.
join
(
', '
)
}
"
)
end
if
conditions
where
(
conditions
).
delete_all
...
...
activerecord/test/cases/relations_test.rb
浏览文件 @
4877737f
...
...
@@ -831,8 +831,12 @@ def test_delete_all_loaded
assert
davids
.
loaded?
end
def
test_delete_all_
limit
_error
def
test_delete_all_
with_unpermitted_relation_raises
_error
assert_raises
(
ActiveRecord
::
ActiveRecordError
)
{
Author
.
limit
(
10
).
delete_all
}
assert_raises
(
ActiveRecord
::
ActiveRecordError
)
{
Author
.
uniq
.
delete_all
}
assert_raises
(
ActiveRecord
::
ActiveRecordError
)
{
Author
.
group
(
:name
).
delete_all
}
assert_raises
(
ActiveRecord
::
ActiveRecordError
)
{
Author
.
having
(
'SUM(id) < 3'
).
delete_all
}
assert_raises
(
ActiveRecord
::
ActiveRecordError
)
{
Author
.
offset
(
10
).
delete_all
}
end
def
test_select_with_aggregates
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录