remove implicit primary actions - more pain than gain. test collection...

remove implicit primary actions - more pain than gain.  test collection actions for other http methods.  strip whitespace.

git-svn-id: http://svn-commit.rubyonrails.org/rails/trunk@5111 5ecf4fe2-1ee6-0310-87b1-e25e094e27de

actionpack/lib/action_controller/resources.rb

@@ -225,7 +225,6 @@ def map_resource(entities, options = {}, &block)
 
       def map_collection_actions(map, resource)
         resource.collection_methods.each do |method, actions|
-          primary       = actions.shift.to_s if method != :get
           route_options = requirements_for(method)
 
           actions.each do |action|
@@ -241,11 +240,6 @@ def map_collection_actions(map, resource)
               route_options.merge(:action => action.to_s)
             )
           end
-
-          unless primary.blank?
-            map.connect(resource.path, route_options.merge(:action => primary))
-            map.connect("#{resource.path}.:format", route_options.merge(:action => primary))
-          end
         end
 
         map.named_route("#{resource.name_prefix}#{resource.plural}", resource.path, :action => "index", :conditions => { :method => :get })
@@ -271,14 +265,11 @@ def map_new_actions(map, resource)
       def map_member_actions(map, resource)
         resource.member_methods.each do |method, actions|
           route_options = requirements_for(method)
-          primary = actions.shift.to_s unless [ :get, :post, :any ].include?(method)
 
           actions.each do |action|
             map.named_route("#{resource.name_prefix}#{action}_#{resource.singular}", "#{resource.member_path};#{action}", route_options.merge(:action => action.to_s))
             map.named_route("formatted_#{resource.name_prefix}#{action}_#{resource.singular}", "#{resource.member_path}.:format;#{action}", route_options.merge(:action => action.to_s))
           end
-
-          map.connect(resource.member_path, route_options.merge(:action => primary)) unless primary.blank?
         end
 
         map.named_route("#{resource.name_prefix}#{resource.singular}", resource.member_path, :action => "show", :conditions => { :method => :get })

actionpack/test/controller/resources_test.rb

@@ -12,7 +12,7 @@ class CommentsController < ResourcesController; end
 
 class ResourcesTest < Test::Unit::TestCase
   def test_should_arrange_actions
-    resource = ActionController::Resources::Resource.new(:messages, 
+    resource = ActionController::Resources::Resource.new(:messages,
       :collection => { :rss => :get, :reorder => :post, :csv => :post },
       :member     => { :rss => :get, :atom => :get, :upload => :post, :fix => :post },
       :new        => { :preview => :get, :draft => :get })
@@ -23,7 +23,7 @@ def test_should_arrange_actions
     assert_resource_methods [:upload, :fix],      resource, :member,     :post
     assert_resource_methods [:preview, :draft],   resource, :new,        :get
   end
-  
+
   def test_default_restful_routes
     with_restful_routing :messages do
       assert_simply_restful_for :messages
@@ -51,15 +51,24 @@ def test_multile_with_path_prefix
   end
 
   def test_with_collection_action
-    with_restful_routing :messages, :collection => { :rss => :get } do
-      rss_options = {:action => 'rss'}
-      rss_path    = "/messages;rss"
+    rss_options = {:action => 'rss'}
+    rss_path    = "/messages;rss"
+    actions = { 'a' => :put, 'b' => :post, 'c' => :delete }
+
+    with_restful_routing :messages, :collection => { :rss => :get }.merge(actions) do
       assert_restful_routes_for :messages do |options|
         assert_routing rss_path, options.merge(rss_options)
+
+        actions.each do |action, method|
+          assert_recognizes(options.merge(:action => action), :path => "/messages;#{action}", :method => method)
+        end
       end
-      
+
       assert_restful_named_routes_for :messages do |options|
         assert_named_route rss_path, :rss_messages_path, rss_options
+        actions.keys.each do |action|
+          assert_named_route "/messages;#{action}", "#{action}_messages_path", :action => action
+        end
       end
     end
   end
@@ -72,7 +81,7 @@ def test_with_member_action
         assert_restful_routes_for :messages do |options|
           assert_recognizes(options.merge(mark_options), :path => mark_path, :method => method)
         end
-        
+
         assert_restful_named_routes_for :messages do |options|
           assert_named_route mark_path, :mark_message_path, mark_options
         end
@@ -89,7 +98,7 @@ def test_with_two_member_actions_with_same_method
           assert_restful_routes_for :messages do |options|
             assert_recognizes(options.merge(action_options), :path => action_path, :method => method)
           end
-        
+
           assert_restful_named_routes_for :messages do |options|
             assert_named_route action_path, "#{action}_message_path".to_sym, action_options
           end
@@ -106,7 +115,7 @@ def test_with_new_action
       assert_restful_routes_for :messages do |options|
         assert_recognizes(options.merge(preview_options), :path => preview_path, :method => :post)
       end
-      
+
       assert_restful_named_routes_for :messages do |options|
         assert_named_route preview_path, :preview_new_message_path, preview_options
       end
@@ -132,13 +141,13 @@ def test_nested_restful_routes
         :options => { :thread_id => '1', :message_id => '2' }
     end
   end
-  
+
   def test_restful_routes_dont_generate_duplicates
     with_restful_routing :messages do
       routes = ActionController::Routing::Routes.routes
       routes.each do |route|
         routes.each do |r|
-          next if route === r # skip the comparison instance 
+          next if route === r # skip the comparison instance
           assert distinct_routes?(route, r), "Duplicate Route: #{route}"
         end
       end
@@ -162,30 +171,34 @@ def assert_simply_restful_for(controller_name, options = {})
     def assert_restful_routes_for(controller_name, options = {})
       (options[:options] ||= {})[:controller] = controller_name.to_s
 
+      collection_path = "/#{options[:path_prefix]}#{controller_name}"
+      member_path = "#{collection_path}/1"
+      new_path = "#{collection_path}/new"
+
       with_options(options[:options]) do |controller|
-        controller.assert_routing "/#{options[:path_prefix]}#{controller_name}",        :action => 'index'
-        controller.assert_routing "/#{options[:path_prefix]}#{controller_name}.xml" ,   :action => 'index', :format => 'xml'
-        controller.assert_routing "/#{options[:path_prefix]}#{controller_name}/new",    :action => 'new'
-        controller.assert_routing "/#{options[:path_prefix]}#{controller_name}/1",      :action => 'show', :id => '1'
-        controller.assert_routing "/#{options[:path_prefix]}#{controller_name}/1;edit", :action => 'edit', :id => '1'
-        controller.assert_routing "/#{options[:path_prefix]}#{controller_name}/1.xml",  :action => 'show', :id => '1', :format => 'xml'
+        controller.assert_routing collection_path,            :action => 'index'
+        controller.assert_routing "#{collection_path}.xml" ,  :action => 'index', :format => 'xml'
+        controller.assert_routing new_path,                   :action => 'new'
+        controller.assert_routing member_path,                :action => 'show', :id => '1'
+        controller.assert_routing "#{member_path};edit",      :action => 'edit', :id => '1'
+        controller.assert_routing "#{member_path}.xml",       :action => 'show', :id => '1', :format => 'xml'
       end
 
       assert_recognizes(
         options[:options].merge(:action => 'create'),
-        {:path => "/#{options[:path_prefix]}#{controller_name}", :method => :post})
+        :path => collection_path, :method => :post)
 
       assert_recognizes(
         options[:options].merge(:action => 'update', :id => '1'),
-        {:path => "/#{options[:path_prefix]}#{controller_name}/1", :method => :put})
+        :path => member_path, :method => :put)
 
       assert_recognizes(
         options[:options].merge(:action => 'destroy', :id => '1'),
-        {:path => "/#{options[:path_prefix]}#{controller_name}/1", :method => :delete})
+        :path => member_path, :method => :delete)
 
       yield options[:options] if block_given?
     end
-    
+
     # test named routes like foo_path and foos_path map to the correct options.
     def assert_restful_named_routes_for(controller_name, singular_name = nil, options = {})
       if singular_name.is_a?(Hash)
@@ -219,11 +232,11 @@ def assert_named_route(expected, route, options)
     def assert_resource_methods(expected, resource, action_method, method)
       assert_equal expected.length, resource.send("#{action_method}_methods")[method].size, "#{resource.send("#{action_method}_methods")[method].inspect}"
       expected.each do |action|
-        assert resource.send("#{action_method}_methods")[method].include?(action), 
+        assert resource.send("#{action_method}_methods")[method].include?(action),
           "#{method} not in #{action_method} methods: #{resource.send("#{action_method}_methods")[method].inspect}"
       end
     end
-    
+
     def distinct_routes? (r1, r2)
       if r1.conditions == r2.conditions and r1.requirements == r2.requirements then
         if r1.segments.collect(&:to_s) == r2.segments.collect(&:to_s) then