VALUES are getting better everyday

lib/arel/insert_manager.rb

@@ -27,7 +27,7 @@ def insert fields
           @head.columns << column
           values << value
         end
-        @head.values = Nodes::Values.new values
+        @head.values = Nodes::Values.new values, @head.columns
       end
     end
   end

lib/arel/nodes/values.rb

 module Arel
   module Nodes
     class Values
-      attr_accessor :expressions
+      attr_accessor :expressions, :columns
 
-      def initialize exprs
+      def initialize exprs, columns = []
         @expressions = exprs
+        @columns = columns
       end
     end
   end

lib/arel/visitors/to_sql.rb

@@ -46,8 +46,8 @@ def visit_Arel_Nodes_Exists o
       end
 
       def visit_Arel_Nodes_Values o
-        "VALUES (#{o.expressions.map { |value|
-          value.nil? ? 'NULL' : visit(value)
+        "VALUES (#{o.expressions.zip(o.columns).map { |value, column|
+          quote(value, column && column.column)
         }.join ', '})"
       end
 

spec/arel/insert_manager_spec.rb

@@ -12,6 +12,11 @@ module Arel
       it "inserts false" do
         table = Table.new(:users)
         manager = Arel::InsertManager.new Table.engine
+
+        table[:id].column.extend(Module.new {
+          def type; :boolean; end
+        })
+
         manager.insert [[table[:id], false]]
         manager.to_sql.should be_like %{
           INSERT INTO "users" ("id") VALUES ('f')