Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
277d6372
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
未验证
提交
277d6372
编写于
5月 24, 2020
作者:
P
player1
提交者:
GitHub
5月 23, 2020
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Take primay_key in count in ActiveRecord::SignedId (#39404)
Co-authored-by:
N
Anton Topchii
<
player1@infinitevoid.net
>
上级
068a436f
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
20 addition
and
3 deletion
+20
-3
activerecord/lib/active_record/signed_id.rb
activerecord/lib/active_record/signed_id.rb
+3
-1
activerecord/test/cases/signed_id_test.rb
activerecord/test/cases/signed_id_test.rb
+17
-2
未找到文件。
activerecord/lib/active_record/signed_id.rb
浏览文件 @
277d6372
...
...
@@ -40,8 +40,10 @@ module ClassMethods
# travel_back
# User.find_signed signed_id, purpose: :password_reset # => User.first
def
find_signed
(
signed_id
,
purpose:
nil
)
raise
UnknownPrimaryKey
.
new
(
@klass
)
if
primary_key
.
nil?
if
id
=
signed_id_verifier
.
verified
(
signed_id
,
purpose:
combine_signed_id_purposes
(
purpose
))
find_by
id:
id
find_by
primary_key
=>
id
end
end
...
...
activerecord/test/cases/signed_id_test.rb
浏览文件 @
277d6372
...
...
@@ -3,20 +3,35 @@
require
"cases/helper"
require
"models/account"
require
"models/company"
require
"models/toy"
require
"models/matey"
SIGNED_ID_VERIFIER_TEST_SECRET
=
"This is normally set by the railtie initializer when used with Rails!"
ActiveRecord
::
Base
.
signed_id_verifier_secret
=
SIGNED_ID_VERIFIER_TEST_SECRET
class
SignedIdTest
<
ActiveRecord
::
TestCase
fixtures
:accounts
fixtures
:accounts
,
:toys
setup
{
@account
=
Account
.
first
}
setup
do
@account
=
Account
.
first
@toy
=
Toy
.
first
end
test
"find signed record"
do
assert_equal
@account
,
Account
.
find_signed
(
@account
.
signed_id
)
end
test
"find signed record with custom primary key"
do
assert_equal
@toy
,
Toy
.
find_signed
(
@toy
.
signed_id
)
end
test
"raise UnknownPrimaryKey when model have no primary key"
do
assert_raises
(
ActiveRecord
::
UnknownPrimaryKey
)
do
Matey
.
find_signed
(
"this will not be even verified"
)
end
end
test
"find signed record with a bang"
do
assert_equal
@account
,
Account
.
find_signed!
(
@account
.
signed_id
)
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录