Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
23329d33
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
23329d33
编写于
8月 23, 2014
作者:
C
Cristian Bica
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Raise ActiveJob::SerializationError when cannot serialize job arguments
上级
ba1d02d8
变更
2
隐藏空白更改
内联
并排
Showing
2 changed file
with
16 addition
and
5 deletion
+16
-5
activejob/lib/active_job/arguments.rb
activejob/lib/active_job/arguments.rb
+13
-2
activejob/test/cases/parameters_test.rb
activejob/test/cases/parameters_test.rb
+3
-3
未找到文件。
activejob/lib/active_job/arguments.rb
浏览文件 @
23329d33
module
ActiveJob
# Raised when an exception is raised during job arguments deserialization.
#
# Wraps the original exception raised as +original_exception+.
class
DeserializationError
<
StandardError
attr_reader
:original_exception
...
...
@@ -9,6 +12,14 @@ def initialize(e)
end
end
# Raised when an unsupporter argument type is being set as job argument. We
# currently support NilClass, Fixnum, Float, String, TrueClass, FalseClass,
# Bignum and object that can be represented as GlobalIDs (ex: Active Record).
# Also raised if you set the key for a Hash something else than a string or
# a symbol.
class
SerializationError
<
ArgumentError
end
module
Arguments
extend
self
TYPE_WHITELIST
=
[
NilClass
,
Fixnum
,
Float
,
String
,
TrueClass
,
FalseClass
,
Bignum
]
...
...
@@ -33,7 +44,7 @@ def serialize_argument(argument)
when
Hash
Hash
[
argument
.
map
{
|
key
,
value
|
[
serialize_hash_key
(
key
),
serialize_argument
(
value
)
]
}
]
else
raise
"Unsupported argument type:
#{
argument
.
class
.
name
}
"
raise
SerializationError
.
new
(
"Unsupported argument type:
#{
argument
.
class
.
name
}
"
)
end
end
...
...
@@ -55,7 +66,7 @@ def serialize_hash_key(key)
when
String
,
Symbol
key
.
to_s
else
raise
"Unsupported hash key type:
#{
key
.
class
.
name
}
"
raise
SerializationError
.
new
(
"Unsupported hash key type:
#{
key
.
class
.
name
}
"
)
end
end
end
...
...
activejob/test/cases/parameters_test.rb
浏览文件 @
23329d33
...
...
@@ -19,7 +19,7 @@ class ParameterSerializationTest < ActiveSupport::TestCase
assert_equal
[
[
1
]
],
ActiveJob
::
Arguments
.
serialize
([
[
1
]
])
assert_equal
[
1_000_000_000_000_000_000_000
],
ActiveJob
::
Arguments
.
serialize
([
1_000_000_000_000_000_000_000
])
err
=
assert_raises
Runtime
Error
do
err
=
assert_raises
ActiveJob
::
Serialization
Error
do
ActiveJob
::
Arguments
.
serialize
([
1
,
self
])
end
assert_equal
"Unsupported argument type:
#{
self
.
class
.
name
}
"
,
err
.
message
...
...
@@ -31,14 +31,14 @@ class ParameterSerializationTest < ActiveSupport::TestCase
end
test
'should dive deep into arrays or hashes and raise exception on complex objects'
do
err
=
assert_raises
Runtime
Error
do
err
=
assert_raises
ActiveJob
::
Serialization
Error
do
ActiveJob
::
Arguments
.
serialize
([
1
,
[
self
]
])
end
assert_equal
"Unsupported argument type:
#{
self
.
class
.
name
}
"
,
err
.
message
end
test
'shoud dive deep into hashes and allow raise exception on not string/symbol keys'
do
err
=
assert_raises
Runtime
Error
do
err
=
assert_raises
ActiveJob
::
Serialization
Error
do
ActiveJob
::
Arguments
.
serialize
([
[
{
1
=>
2
}
]
])
end
assert_equal
"Unsupported hash key type: Fixnum"
,
err
.
message
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录