Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
1ce9b73e
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
1ce9b73e
编写于
12月 07, 2010
作者:
P
Pavel Gorbokon
提交者:
Santiago Pastorino
12月 07, 2010
浏览文件
操作
浏览文件
下载
电子邮件补丁
差异文件
Replace nested ifs with case/when
Signed-off-by:
N
Santiago Pastorino
<
santiago@wyeworks.com
>
上级
4c4c7a27
变更
1
隐藏空白更改
内联
并排
Showing
1 changed file
with
44 addition
and
46 deletion
+44
-46
activesupport/lib/active_support/callbacks.rb
activesupport/lib/active_support/callbacks.rb
+44
-46
未找到文件。
activesupport/lib/active_support/callbacks.rb
浏览文件 @
1ce9b73e
...
...
@@ -178,49 +178,48 @@ def start(key=nil, object=nil)
# options[0] is the compiled form of supplied conditions
# options[1] is the "end" for the conditional
#
if
@kind
==
:before
||
@kind
==
:around
if
@kind
==
:before
# if condition # before_save :filter_name, :if => :condition
# filter_name
# end
filter
=
<<-
RUBY_EVAL
unless halted
result =
#{
@filter
}
halted = (
#{
chain
.
config
[
:terminator
]
}
)
end
RUBY_EVAL
[
@compiled_options
[
0
],
filter
,
@compiled_options
[
1
]].
compact
.
join
(
"
\n
"
)
else
# Compile around filters with conditions into proxy methods
# that contain the conditions.
#
# For `around_save :filter_name, :if => :condition':
#
# def _conditional_callback_save_17
# if condition
# filter_name do
# yield self
# end
# else
# yield self
# end
# end
#
name
=
"_conditional_callback_
#{
@kind
}
_
#{
next_id
}
"
@klass
.
class_eval
<<-
RUBY_EVAL
,
__FILE__
,
__LINE__
+
1
def
#{
name
}
(halted)
#{
@compiled_options
[
0
]
||
"if true"
}
&& !halted
#{
@filter
}
do
yield self
end
else
case
@kind
when
:before
# if condition # before_save :filter_name, :if => :condition
# filter_name
# end
filter
=
<<-
RUBY_EVAL
unless halted
result =
#{
@filter
}
halted = (
#{
chain
.
config
[
:terminator
]
}
)
end
RUBY_EVAL
[
@compiled_options
[
0
],
filter
,
@compiled_options
[
1
]].
compact
.
join
(
"
\n
"
)
when
:around
# Compile around filters with conditions into proxy methods
# that contain the conditions.
#
# For `around_save :filter_name, :if => :condition':
#
# def _conditional_callback_save_17
# if condition
# filter_name do
# yield self
# end
# else
# yield self
# end
# end
#
name
=
"_conditional_callback_
#{
@kind
}
_
#{
next_id
}
"
@klass
.
class_eval
<<-
RUBY_EVAL
,
__FILE__
,
__LINE__
+
1
def
#{
name
}
(halted)
#{
@compiled_options
[
0
]
||
"if true"
}
&& !halted
#{
@filter
}
do
yield self
end
else
yield self
end
RUBY_EVAL
"
#{
name
}
(halted) do"
end
end
RUBY_EVAL
"
#{
name
}
(halted) do"
end
end
...
...
@@ -229,15 +228,14 @@ def #{name}(halted)
def
end
(
key
=
nil
,
object
=
nil
)
return
if
key
&&
!
object
.
send
(
"_one_time_conditions_valid_
#{
@callback_id
}
?"
)
if
@kind
==
:around
||
@kind
==
:after
case
@kind
when
:after
# if condition # after_save :filter_name, :if => :condition
# filter_name
# end
if
@kind
==
:after
[
@compiled_options
[
0
],
@filter
,
@compiled_options
[
1
]].
compact
.
join
(
"
\n
"
)
else
"end"
end
[
@compiled_options
[
0
],
@filter
,
@compiled_options
[
1
]].
compact
.
join
(
"
\n
"
)
when
:around
"end"
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录