提交 1a36be39 编写于 作者: A Andrey Voronkov

Fix uniqueness validation with out of range value

上级 0a120a81
* Uniqueness validation with out of range value fixed
*Andrey Voronkov*
* MySQL: `:charset` and `:collation` support for string and text columns.
Example:
......
......@@ -76,6 +76,8 @@ def build_relation(klass, table, attribute, value) #:nodoc:
klass.connection.case_sensitive_comparison(table, attribute, column, value)
end
klass.unscoped.where(comparison)
rescue RangeError
klass.none
end
def scope_relation(record, table, relation)
......
......@@ -34,6 +34,19 @@ class TopicWithUniqEvent < Topic
validates :event, uniqueness: true
end
class BigIntTest < ActiveRecord::Base
PG_MAX_INTEGER = 2147483647
self.table_name = 'cars'
validates :engines_count, uniqueness: true, inclusion: { in: 0..PG_MAX_INTEGER }
end
class BigIntReverseTest < ActiveRecord::Base
PG_MAX_INTEGER = 2147483647
self.table_name = 'cars'
validates :engines_count, inclusion: { in: 0..PG_MAX_INTEGER }
validates :engines_count, uniqueness: true
end
class UniquenessValidationTest < ActiveRecord::TestCase
fixtures :topics, 'warehouse-things'
......@@ -86,6 +99,18 @@ def test_validates_uniqueness_with_validates
assert t2.errors[:title]
end
if current_adapter? :PostgreSQLAdapter
def test_validate_uniqueness_when_integer_out_of_range
entry = BigIntTest.create(engines_count: (BigIntTest::PG_MAX_INTEGER + 1))
assert_equal entry.errors[:engines_count], ['is not included in the list']
end
def test_validate_uniqueness_when_integer_out_of_range_show_order_does_not_matter
entry = BigIntReverseTest.create(engines_count: (BigIntTest::PG_MAX_INTEGER + 1))
assert_equal entry.errors[:engines_count], ['is not included in the list']
end
end
def test_validates_uniqueness_with_newline_chars
Topic.validates_uniqueness_of(:title, :case_sensitive => false)
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册