Merge pull request #15349 from tgxworld/remove_duplicated_method_call

Remove duplicated HashWithIndifferentAccess#with_indifferent_access.

actionpack/lib/action_dispatch/http/parameters.rb

@@ -15,7 +15,6 @@ def parameters
             query_parameters.dup
           end
           params.merge!(path_parameters)
-          params.with_indifferent_access
         end
       end
       alias :params :parameters

actionpack/lib/action_dispatch/http/request.rb

@@ -291,7 +291,7 @@ def session_options=(options)
 
     # Override Rack's GET method to support indifferent access
     def GET
-      @env["action_dispatch.request.query_parameters"] ||= Utils.deep_munge((normalize_encode_params(super) || {}))
+      @env["action_dispatch.request.query_parameters"] ||= Utils.deep_munge(normalize_encode_params(super || {}))
     rescue TypeError => e
       raise ActionController::BadRequest.new(:query, e)
     end
@@ -299,7 +299,7 @@ def GET
 
     # Override Rack's POST method to support indifferent access
     def POST
-      @env["action_dispatch.request.request_parameters"] ||= Utils.deep_munge((normalize_encode_params(super) || {}))
+      @env["action_dispatch.request.request_parameters"] ||= Utils.deep_munge(normalize_encode_params(super || {}))
     rescue TypeError => e
       raise ActionController::BadRequest.new(:request, e)
     end

actionpack/test/dispatch/request/url_encoded_params_parsing_test.rb

@@ -130,10 +130,7 @@ def teardown
   end
 
   test "ambiguous params returns a bad request" do
-    with_routing do |set|
-      set.draw do
-        post ':action', to: ::UrlEncodedParamsParsingTest::TestController
-      end
+    with_test_routing do
       post "/parse", "foo[]=bar&foo[4]=bar"
       assert_response :bad_request
     end