Make the options that has_many, belongs_to and other association generation...

Make the options that has_many, belongs_to and other association generation methods can accept, configurable.

[#985 state:resolved]
Signed-off-by: NJeremy Kemper <jeremy@bitsweat.net>

activerecord/CHANGELOG

 *Edge*
 
+* Internal API: configurable association options so plugins may extend and override.  #985 [Hongli Lai]
+
 * Changed benchmarks to be reported in milliseconds [DHH]
 
 * Connection pooling.  #936 [Nick Sieger]

activerecord/lib/active_record/associations.rb

@@ -1509,28 +1509,36 @@ def configure_dependency_for_belongs_to(reflection)
           end
         end
 
+        mattr_accessor :valid_keys_for_has_many_association
+        @@valid_keys_for_has_many_association = [
+          :class_name, :table_name, :foreign_key, :primary_key,
+          :dependent,
+          :select, :conditions, :include, :order, :group, :limit, :offset,
+          :as, :through, :source, :source_type,
+          :uniq,
+          :finder_sql, :counter_sql,
+          :before_add, :after_add, :before_remove, :after_remove,
+          :extend, :readonly,
+          :validate, :accessible
+        ]
+
         def create_has_many_reflection(association_id, options, &extension)
-          options.assert_valid_keys(
-            :class_name, :table_name, :foreign_key, :primary_key,
-            :dependent,
-            :select, :conditions, :include, :order, :group, :limit, :offset,
-            :as, :through, :source, :source_type,
-            :uniq,
-            :finder_sql, :counter_sql,
-            :before_add, :after_add, :before_remove, :after_remove,
-            :extend, :readonly,
-            :validate, :accessible
-          )
+          options.assert_valid_keys(valid_keys_for_has_many_association)
 
           options[:extend] = create_extension_modules(association_id, extension, options[:extend])
 
           create_reflection(:has_many, association_id, options, self)
         end
 
+        mattr_accessor :valid_keys_for_has_one_association
+        @@valid_keys_for_has_one_association = [
+          :class_name, :foreign_key, :remote, :select, :conditions, :order,
+          :include, :dependent, :counter_cache, :extend, :as, :readonly,
+          :validate, :primary_key, :accessible
+        ]
+
         def create_has_one_reflection(association_id, options)
-          options.assert_valid_keys(
-            :class_name, :foreign_key, :remote, :select, :conditions, :order, :include, :dependent, :counter_cache, :extend, :as, :readonly, :validate, :primary_key, :accessible
-          )
+          options.assert_valid_keys(valid_keys_for_has_one_association)
 
           create_reflection(:has_one, association_id, options, self)
         end
@@ -1542,11 +1550,15 @@ def create_has_one_through_reflection(association_id, options)
           create_reflection(:has_one, association_id, options, self)
         end
 
+        mattr_accessor :valid_keys_for_belongs_to_association
+        @@valid_keys_for_belongs_to_association = [
+          :class_name, :foreign_key, :foreign_type, :remote, :select, :conditions,
+          :include, :dependent, :counter_cache, :extend, :polymorphic, :readonly,
+          :validate, :accessible
+        ]
+
         def create_belongs_to_reflection(association_id, options)
-          options.assert_valid_keys(
-            :class_name, :foreign_key, :foreign_type, :remote, :select, :conditions, :include, :dependent,
-            :counter_cache, :extend, :polymorphic, :readonly, :validate, :accessible
-          )
+          options.assert_valid_keys(valid_keys_for_belongs_to_association)
 
           reflection = create_reflection(:belongs_to, association_id, options, self)