提交 0d0c30e5 编写于 作者: R Ryuta Kamizono

Avoid making query when using `where(attr: [])` for `pluck`

Follow up #37266.
上级 104c1843
......@@ -190,7 +190,13 @@ def pluck(*column_names)
klass.disallow_raw_sql!(column_names)
relation = spawn
relation.select_values = column_names
result = skip_query_cache_if_necessary { klass.connection.select_all(relation.arel, nil) }
result = skip_query_cache_if_necessary do
if where_clause.contradiction?
ActiveRecord::Result.new([], [])
else
klass.connection.select_all(relation.arel, nil)
end
end
result.cast_values(klass.attribute_types)
end
end
......
......@@ -678,6 +678,13 @@ def test_pluck
assert_equal [1, 2, 3, 4, 5], Topic.order(:id).pluck(:id)
end
def test_pluck_with_empty_in
Topic.send(:load_schema)
assert_no_queries do
assert_equal [], Topic.where(id: []).pluck(:id)
end
end
def test_pluck_without_column_names
if current_adapter?(:OracleAdapter)
assert_equal [[1, "Firm", 1, nil, "37signals", nil, 1, nil, nil]], Company.order(:id).limit(1).pluck
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册