Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
08df10a9
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
前往新版Gitcode,体验更适合开发者的 AI 搜索 >>
提交
08df10a9
编写于
10月 25, 2017
作者:
R
Rafael França
提交者:
GitHub
10月 25, 2017
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #30970 from rohitpaulk/fix-sqlite-3-index-order-dump
Save index order :desc to schema.rb (sqlite). Fixes #30902
上级
df4632fe
ab8c7a51
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
19 addition
and
2 deletion
+19
-2
activerecord/CHANGELOG.md
activerecord/CHANGELOG.md
+7
-0
activerecord/lib/active_record/connection_adapters/sqlite3/schema_statements.rb
...e_record/connection_adapters/sqlite3/schema_statements.rb
+11
-1
activerecord/test/cases/schema_dumper_test.rb
activerecord/test/cases/schema_dumper_test.rb
+1
-1
未找到文件。
activerecord/CHANGELOG.md
浏览文件 @
08df10a9
*
Fixed a bug where column orders for an index weren't written to
db/schema.rb when using the sqlite adapter.
Fixes #30902.
*Paul Kuruvilla*
*
Remove deprecated method
`#sanitize_conditions`
.
*Rafael Mendonça França*
...
...
activerecord/lib/active_record/connection_adapters/sqlite3/schema_statements.rb
浏览文件 @
08df10a9
...
...
@@ -23,12 +23,22 @@ def indexes(table_name)
col
[
"name"
]
end
# Add info on sort order for columns (only desc order is explicitly specified, asc is
# the default)
orders
=
{}
if
index_sql
# index_sql can be null in case of primary key indexes
index_sql
.
scan
(
/"(\w+)" DESC/
).
flatten
.
each
{
|
order_column
|
orders
[
order_column
]
=
:desc
}
end
IndexDefinition
.
new
(
table_name
,
row
[
"name"
],
row
[
"unique"
]
!=
0
,
columns
,
where:
where
where:
where
,
orders:
orders
)
end
end
...
...
activerecord/test/cases/schema_dumper_test.rb
浏览文件 @
08df10a9
...
...
@@ -186,7 +186,7 @@ def test_schema_dumps_index_columns_in_right_order
assert_equal
't.index ["firm_id", "type", "rating"], name: "company_index", length: { type: 10 }'
,
index_definition
end
else
assert_equal
't.index ["firm_id", "type", "rating"], name: "company_index"'
,
index_definition
assert_equal
't.index ["firm_id", "type", "rating"], name: "company_index"
, order: { rating: :desc }
'
,
index_definition
end
end
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录