Skip to content
体验新版
项目
组织
正在加载...
登录
切换导航
打开侧边栏
张重言
rails
提交
0450642c
R
rails
项目概览
张重言
/
rails
通知
1
Star
0
Fork
0
代码
文件
提交
分支
Tags
贡献者
分支图
Diff
Issue
0
列表
看板
标记
里程碑
合并请求
0
Wiki
0
Wiki
分析
仓库
DevOps
项目成员
Pages
R
rails
项目概览
项目概览
详情
发布
仓库
仓库
文件
提交
分支
标签
贡献者
分支图
比较
Issue
0
Issue
0
列表
看板
标记
里程碑
合并请求
0
合并请求
0
Pages
分析
分析
仓库分析
DevOps
Wiki
0
Wiki
成员
成员
收起侧边栏
关闭侧边栏
动态
分支图
创建新Issue
提交
Issue看板
体验新版 GitCode,发现更多精彩内容 >>
提交
0450642c
编写于
10月 09, 2015
作者:
J
Jeremy Daer
浏览文件
操作
浏览文件
下载
差异文件
Merge pull request #21631 from RobinClowers/fix-cache-instrumentation
Fix cache fetch instrumentation
上级
5c7e9925
edd33c08
变更
3
隐藏空白更改
内联
并排
Showing
3 changed file
with
43 addition
and
13 deletion
+43
-13
activesupport/CHANGELOG.md
activesupport/CHANGELOG.md
+4
-0
activesupport/lib/active_support/cache.rb
activesupport/lib/active_support/cache.rb
+11
-13
activesupport/test/caching_test.rb
activesupport/test/caching_test.rb
+28
-0
未找到文件。
activesupport/CHANGELOG.md
浏览文件 @
0450642c
*
`Cache#fetch`
instrumentation marks whether it was a
`:hit`
.
*Robin Clowers*
*
`assert_difference`
and
`assert_no_difference`
now returns the result of the
yielded block.
...
...
activesupport/lib/active_support/cache.rb
浏览文件 @
0450642c
...
...
@@ -277,13 +277,18 @@ def fetch(name, options = nil)
options
=
merged_options
(
options
)
key
=
namespaced_key
(
name
,
options
)
cached_entry
=
find_cached_entry
(
key
,
name
,
options
)
unless
options
[
:force
]
entry
=
handle_expired_entry
(
cached_entry
,
key
,
options
)
instrument
(
:read
,
name
,
options
)
do
|
payload
|
cached_entry
=
read_entry
(
key
,
options
)
unless
options
[
:force
]
payload
[
:super_operation
]
=
:fetch
if
payload
entry
=
handle_expired_entry
(
cached_entry
,
key
,
options
)
if
entry
get_entry_value
(
entry
,
name
,
options
)
else
save_block_result_to_cache
(
name
,
options
)
{
|
_name
|
yield
_name
}
if
entry
payload
[
:hit
]
=
true
if
payload
get_entry_value
(
entry
,
name
,
options
)
else
payload
[
:hit
]
=
false
if
payload
save_block_result_to_cache
(
name
,
options
)
{
|
_name
|
yield
_name
}
end
end
else
read
(
name
,
options
)
...
...
@@ -556,13 +561,6 @@ def log
logger
.
debug
(
yield
)
end
def
find_cached_entry
(
key
,
name
,
options
)
instrument
(
:read
,
name
,
options
)
do
|
payload
|
payload
[
:super_operation
]
=
:fetch
if
payload
read_entry
(
key
,
options
)
end
end
def
handle_expired_entry
(
entry
,
key
,
options
)
if
entry
&&
entry
.
expired?
race_ttl
=
options
[
:race_condition_ttl
].
to_i
...
...
activesupport/test/caching_test.rb
浏览文件 @
0450642c
...
...
@@ -490,6 +490,34 @@ def test_really_long_keys
assert_equal
({
key
=>
"bar"
},
@cache
.
read_multi
(
key
))
assert
@cache
.
delete
(
key
)
end
def
test_cache_hit_instrumentation
key
=
"test_key"
subscribe_executed
=
false
ActiveSupport
::
Notifications
.
subscribe
"cache_read.active_support"
do
|
name
,
start
,
finish
,
id
,
payload
|
subscribe_executed
=
true
assert_equal
:fetch
,
payload
[
:super_operation
]
assert
payload
[
:hit
]
end
assert
@cache
.
write
(
key
,
"1"
,
:raw
=>
true
)
assert
@cache
.
fetch
(
key
)
{}
assert
subscribe_executed
ensure
ActiveSupport
::
Notifications
.
unsubscribe
"cache_read.active_support"
end
def
test_cache_miss_instrumentation
subscribe_executed
=
false
ActiveSupport
::
Notifications
.
subscribe
"cache_read.active_support"
do
|
name
,
start
,
finish
,
id
,
payload
|
subscribe_executed
=
true
assert_equal
:fetch
,
payload
[
:super_operation
]
assert_not
payload
[
:hit
]
end
assert_not
@cache
.
fetch
(
"bad_key"
)
{}
assert
subscribe_executed
ensure
ActiveSupport
::
Notifications
.
unsubscribe
"cache_read.active_support"
end
end
# https://rails.lighthouseapp.com/projects/8994/tickets/6225-memcachestore-cant-deal-with-umlauts-and-special-characters
...
...
编辑
预览
Markdown
is supported
0%
请重试
或
添加新附件
.
添加附件
取消
You are about to add
0
people
to the discussion. Proceed with caution.
先完成此消息的编辑!
取消
想要评论请
注册
或
登录