提交 00eb09e0 编写于 作者: J Jeremy Kemper

Revert "Get AS TestCase off deprecated callbacks"

This reverts commit 29b28066.
上级 efdc0624
...@@ -3,9 +3,7 @@ module Testing ...@@ -3,9 +3,7 @@ module Testing
module SetupAndTeardown module SetupAndTeardown
def self.included(base) def self.included(base)
base.class_eval do base.class_eval do
extend ClassMethods include ActiveSupport::DeprecatedCallbacks
include ActiveSupport::Callbacks
define_callbacks :setup, :teardown define_callbacks :setup, :teardown
if defined?(MiniTest::Assertions) && TestCase < MiniTest::Assertions if defined?(MiniTest::Assertions) && TestCase < MiniTest::Assertions
...@@ -16,16 +14,6 @@ def self.included(base) ...@@ -16,16 +14,6 @@ def self.included(base)
end end
end end
module ClassMethods
def setup(*args, &block)
set_callback(:setup, *args, &block)
end
def teardown(*args, &block)
set_callback(:teardown, *args, &block)
end
end
module ForMiniTest module ForMiniTest
def run(runner) def run(runner)
result = '.' result = '.'
......
...@@ -95,3 +95,55 @@ class NotTestingThingsTest < Test::Unit::TestCase ...@@ -95,3 +95,55 @@ class NotTestingThingsTest < Test::Unit::TestCase
class AlsoDoingNothingTest < ActiveSupport::TestCase class AlsoDoingNothingTest < ActiveSupport::TestCase
end end
# Setup and teardown callbacks.
class SetupAndTeardownTest < ActiveSupport::TestCase
setup :reset_callback_record, :foo
teardown :foo, :sentinel, :foo
def test_inherited_setup_callbacks
assert_equal [:reset_callback_record, :foo], self.class.setup_callback_chain.map(&:method)
assert_equal [:foo], @called_back
assert_equal [:foo, :sentinel, :foo], self.class.teardown_callback_chain.map(&:method)
end
def setup
end
def teardown
end
protected
def reset_callback_record
@called_back = []
end
def foo
@called_back << :foo
end
def sentinel
assert_equal [:foo, :foo], @called_back
end
end
class SubclassSetupAndTeardownTest < SetupAndTeardownTest
setup :bar
teardown :bar
def test_inherited_setup_callbacks
assert_equal [:reset_callback_record, :foo, :bar], self.class.setup_callback_chain.map(&:method)
assert_equal [:foo, :bar], @called_back
assert_equal [:foo, :sentinel, :foo, :bar], self.class.teardown_callback_chain.map(&:method)
end
protected
def bar
@called_back << :bar
end
def sentinel
assert_equal [:foo, :bar, :bar, :foo], @called_back
end
end
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册