• M
    Extract ActiveSupport::NumberHelper methods to classes · 2da9d67c
    Matt Bridges 提交于
    Due to the overall complexity of each method individually as well as the
    global shared private module methods, this pulls each helper into it's
    own converter class inheriting from a generic `NumberBuilder` class.
    
    * The `NumberBuilder` class contains the private methods needed for each helper
    method an eliminates the need for special definition of specialized private
    module methods.
    * The `ActiveSupport::NumberHelper::DEFAULTS` constant has been moved
    into the `NumberBuilder` class because the `NumberBuilder` is the only
    class which needs access to it.
    * For each of the builders, the `#convert` method is broken down to
    smaller parts and extracted into private methods for clarity of purpose.
    * Most of the mutation that once was necessary has now been eliminated.
    * Several of the mathematical operations for percentage, delimited, and
    rounded have been moved into private methods to ease readability and
    clarity.
    * Internationalization is still a bit crufty, and definitely could be
    improved, but it is functional and a bit easier to follow.
    
    The following helpers were extracted into their respective classes.
    
    * `#number_to_percentage` -> `NumberToPercentageConverter`
    * `#number_to_delimited` -> `NumberToDelimitedConverter`
    * `#number_to_phone` -> `NumberToPhoneConverter`
    * `#number_to_currency` -> `NumberToCurrencyConverter`
    * `#number_to_rounded` -> `NumberToRoundedConverter`
    * `#number_to_human_size` -> `NumberToHumanSizeConverter`
    * `#number_to_human` -> `NumberToHumanConverter`
    2da9d67c
number_to_human_size.rb 1.8 KB