• E
    Move records and loaded ivar up to load · 847643a5
    eileencodes 提交于
    We should set the `@records` and `@loaded` ivar inside `#load` rather
    than in `#exec_queries`. Since `#load` is running `#exec_queries` and
    `@records` can only be assigned if `loaded?` is true and `@loaded` can
    only be set if `loaded?` is true then `#load` should do the assignment.
    This is cleaner but also we came across this while working on an
    internal gem and realized that the ivar assignment was happening in the
    wrong place.
    Co-authored-by: NAaron Patterson <aaron.patterson@gmail.com>
    847643a5
record_fetch_warning.rb 1.6 KB