• S
    rm `Column#cast_type` · 158c7eb1
    Sean Griffin 提交于
    The type from the column is never used, except when being passed to the
    attributes API. While leaving the type on the column wasn't necessarily
    a bad thing, I worry that it's existence there implies that it is
    something which should be used.
    
    During the design and implementation process of the attributes API,
    there have been plenty of cases where getting the "right" type object
    was hard, but I had easy access to the column objects. For any
    contributor who isn't intimately familiar with the intents behind the
    type casting system, grabbing the type from the column might easily seem
    like the "correct" thing to do.
    
    As such, the goal of this change is to express that the column is not
    something that should be used for type casting. The only places that are
    "valid" (at the time of this commit) uses of acquiring a type object
    from the column are fixtures (as the YAML file is going to mirror the
    database more closely than the AR object), and looking up the type
    during schema detection to pass to the attributes API
    
    Many of the failing tests were removed, as they've been made obsolete
    over the last year. All of the PG column tests were testing nothing
    beyond polymorphism. The Mysql2 tests were duplicating the mysql tests,
    since they now share a column class.
    
    The implementation is a little hairy, and slightly verbose, but it felt
    preferable to going back to 20 constructor options for the columns. If
    you are git blaming to figure out wtf I was thinking with them, and have
    a better idea, go for it. Just don't use a type object for this.
    158c7eb1
sqlite3_adapter.rb 18.5 KB