belongs_to_associations_test.rb 34.2 KB
Newer Older
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25
require "cases/helper"
require "models/developer"
require "models/project"
require "models/company"
require "models/topic"
require "models/reply"
require "models/computer"
require "models/post"
require "models/author"
require "models/tag"
require "models/tagging"
require "models/comment"
require "models/sponsor"
require "models/member"
require "models/essay"
require "models/toy"
require "models/invoice"
require "models/line_item"
require "models/column"
require "models/record"
require "models/admin"
require "models/admin/user"
require "models/ship"
require "models/treasure"
require "models/parrot"
26 27 28

class BelongsToAssociationsTest < ActiveRecord::TestCase
  fixtures :accounts, :companies, :developers, :projects, :topics,
29
           :developers_projects, :computers, :authors, :author_addresses,
30
           :posts, :tags, :taggings, :comments, :sponsors, :members
31 32

  def test_belongs_to
33 34 35
    firm = Client.find(3).firm
    assert_not_nil firm
    assert_equal companies(:first_firm).name, firm.name
36 37
  end

38 39 40 41
  def test_missing_attribute_error_is_raised_when_no_foreign_key_attribute
    assert_raises(ActiveModel::MissingAttributeError) { Client.select(:id).first.firm }
  end

42 43 44 45
  def test_belongs_to_does_not_use_order_by
    ActiveRecord::SQLCounter.clear_log
    Client.find(3).firm
  ensure
46
    assert ActiveRecord::SQLCounter.log_all.all? { |sql| /order by/i !~ sql }, "ORDER BY was used in the query"
47 48
  end

49
  def test_belongs_to_with_primary_key
50
    client = Client.create(name: "Primary key client", firm_name: companies(:first_firm).name)
51 52 53
    assert_equal companies(:first_firm).name, client.firm_with_primary_key.name
  end

54 55
  def test_belongs_to_with_primary_key_joins_on_correct_column
    sql = Client.joins(:firm_with_primary_key).to_sql
A
Abdelkader Boudih 已提交
56
    if current_adapter?(:Mysql2Adapter)
57 58
      assert_no_match(/`firm_with_primary_keys_companies`\.`id`/, sql)
      assert_match(/`firm_with_primary_keys_companies`\.`name`/, sql)
59 60 61 62
    elsif current_adapter?(:OracleAdapter)
      # on Oracle aliases are truncated to 30 characters and are quoted in uppercase
      assert_no_match(/"firm_with_primary_keys_compani"\."id"/i, sql)
      assert_match(/"firm_with_primary_keys_compani"\."name"/i, sql)
E
Emilio Tagua 已提交
63
    else
64 65
      assert_no_match(/"firm_with_primary_keys_companies"\."id"/, sql)
      assert_match(/"firm_with_primary_keys_companies"\."name"/, sql)
E
Emilio Tagua 已提交
66
    end
67 68
  end

69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95
  def test_optional_relation
    original_value = ActiveRecord::Base.belongs_to_required_by_default
    ActiveRecord::Base.belongs_to_required_by_default = true

    model = Class.new(ActiveRecord::Base) do
      self.table_name = "accounts"
      def self.name; "Temp"; end
      belongs_to :company, optional: true
    end

    account = model.new
    assert account.valid?
  ensure
    ActiveRecord::Base.belongs_to_required_by_default = original_value
  end

  def test_not_optional_relation
    original_value = ActiveRecord::Base.belongs_to_required_by_default
    ActiveRecord::Base.belongs_to_required_by_default = true

    model = Class.new(ActiveRecord::Base) do
      self.table_name = "accounts"
      def self.name; "Temp"; end
      belongs_to :company, optional: false
    end

    account = model.new
96
    assert_not account.valid?
97
    assert_equal [{ error: :blank }], account.errors.details[:company]
98 99 100 101 102 103 104 105 106 107 108 109 110 111 112
  ensure
    ActiveRecord::Base.belongs_to_required_by_default = original_value
  end

  def test_required_belongs_to_config
    original_value = ActiveRecord::Base.belongs_to_required_by_default
    ActiveRecord::Base.belongs_to_required_by_default = true

    model = Class.new(ActiveRecord::Base) do
      self.table_name = "accounts"
      def self.name; "Temp"; end
      belongs_to :company
    end

    account = model.new
113
    assert_not account.valid?
114
    assert_equal [{ error: :blank }], account.errors.details[:company]
115 116 117 118
  ensure
    ActiveRecord::Base.belongs_to_required_by_default = original_value
  end

119 120 121 122
  def test_default_scope_on_relations_is_not_cached
    counter = 0

    comments = Class.new(ActiveRecord::Base) {
123 124
      self.table_name = "comments"
      self.inheritance_column = "not_there"
125 126

      posts = Class.new(ActiveRecord::Base) {
127 128
        self.table_name = "posts"
        self.inheritance_column = "not_there"
129 130 131

        default_scope -> {
          counter += 1
132
          where("id = :inc", inc: counter)
133 134
        }

135
        has_many :comments, anonymous_class: comments
136
      }
137
      belongs_to :post, anonymous_class: posts, inverse_of: false
138 139 140 141 142 143 144 145 146 147
    }

    assert_equal 0, counter
    comment = comments.first
    assert_equal 0, counter
    sql = capture_sql { comment.post }
    comment.reload
    assert_not_equal sql, capture_sql { comment.post }
  end

148 149 150 151 152 153 154 155 156 157
  def test_proxy_assignment
    account = Account.find(1)
    assert_nothing_raised { account.firm = account.firm }
  end

  def test_type_mismatch
    assert_raise(ActiveRecord::AssociationTypeMismatch) { Account.find(1).firm = 1 }
    assert_raise(ActiveRecord::AssociationTypeMismatch) { Account.find(1).firm = Project.find(1) }
  end

158 159 160 161 162 163 164
  def test_raises_type_mismatch_with_namespaced_class
    assert_nil defined?(Region), "This test requires that there is no top-level Region class"

    ActiveRecord::Base.connection.instance_eval do
      create_table(:admin_regions) { |t| t.string :name }
      add_column :admin_users, :region_id, :integer
    end
165 166
    Admin.const_set "RegionalUser", Class.new(Admin::User) { belongs_to(:region) }
    Admin.const_set "Region", Class.new(ActiveRecord::Base)
167 168

    e = assert_raise(ActiveRecord::AssociationTypeMismatch) {
169
      Admin::RegionalUser.new(region: "wrong value")
170
    }
171
    assert_match(/^Region\([^)]+\) expected, got "wrong value" which is an instance of String\([^)]+\)$/, e.message)
172 173 174
  ensure
    Admin.send :remove_const, "Region" if Admin.const_defined?("Region")
    Admin.send :remove_const, "RegionalUser" if Admin.const_defined?("RegionalUser")
175 176 177 178 179

    ActiveRecord::Base.connection.instance_eval do
      remove_column :admin_users, :region_id if column_exists?(:admin_users, :region_id)
      drop_table :admin_regions, if_exists: true
    end
180 181
  end

182 183 184 185 186 187 188
  def test_natural_assignment
    apple = Firm.create("name" => "Apple")
    citibank = Account.create("credit_limit" => 10)
    citibank.firm = apple
    assert_equal apple.id, citibank.firm_id
  end

189 190 191 192 193 194 195
  def test_id_assignment
    apple = Firm.create("name" => "Apple")
    citibank = Account.create("credit_limit" => 10)
    citibank.firm_id = apple
    assert_nil citibank.firm_id
  end

196 197 198 199 200 201 202
  def test_natural_assignment_with_primary_key
    apple = Firm.create("name" => "Apple")
    citibank = Client.create("name" => "Primary key client")
    citibank.firm_with_primary_key = apple
    assert_equal apple.name, citibank.firm_name
  end

203
  def test_eager_loading_with_primary_key
A
Aaron Patterson 已提交
204 205
    Firm.create("name" => "Apple")
    Client.create("name" => "Citibank", :firm_name => "Apple")
206
    citibank_result = Client.all.merge!(where: { name: "Citibank" }, includes: :firm_with_primary_key).first
207
    assert citibank_result.association(:firm_with_primary_key).loaded?
208 209
  end

210 211 212
  def test_eager_loading_with_primary_key_as_symbol
    Firm.create("name" => "Apple")
    Client.create("name" => "Citibank", :firm_name => "Apple")
213
    citibank_result = Client.all.merge!(where: { name: "Citibank" }, includes: :firm_with_primary_key_symbols).first
214
    assert citibank_result.association(:firm_with_primary_key_symbols).loaded?
215 216
  end

217 218 219 220 221 222 223 224 225
  def test_creating_the_belonging_object
    citibank = Account.create("credit_limit" => 10)
    apple    = citibank.create_firm("name" => "Apple")
    assert_equal apple, citibank.firm
    citibank.save
    citibank.reload
    assert_equal apple, citibank.firm
  end

226
  def test_creating_the_belonging_object_with_primary_key
227
    client = Client.create(name: "Primary key client")
228 229 230 231 232 233 234
    apple  = client.create_firm_with_primary_key("name" => "Apple")
    assert_equal apple, client.firm_with_primary_key
    client.save
    client.reload
    assert_equal apple, client.firm_with_primary_key
  end

235 236 237 238 239 240 241
  def test_building_the_belonging_object
    citibank = Account.create("credit_limit" => 10)
    apple    = citibank.build_firm("name" => "Apple")
    citibank.save
    assert_equal apple.id, citibank.firm_id
  end

242 243 244
  def test_building_the_belonging_object_with_implicit_sti_base_class
    account = Account.new
    company = account.build_firm
245
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
246 247 248 249
  end

  def test_building_the_belonging_object_with_explicit_sti_base_class
    account = Account.new
250
    company = account.build_firm(type: "Company")
251
    assert_kind_of Company, company, "Expected #{company.class} to be a Company"
252 253 254 255
  end

  def test_building_the_belonging_object_with_sti_subclass
    account = Account.new
256
    company = account.build_firm(type: "Firm")
257
    assert_kind_of Firm, company, "Expected #{company.class} to be a Firm"
258 259 260 261
  end

  def test_building_the_belonging_object_with_an_invalid_type
    account = Account.new
262
    assert_raise(ActiveRecord::SubclassNotFound) { account.build_firm(type: "InvalidType") }
263 264 265 266
  end

  def test_building_the_belonging_object_with_an_unrelated_type
    account = Account.new
267
    assert_raise(ActiveRecord::SubclassNotFound) { account.build_firm(type: "Account") }
268 269
  end

270
  def test_building_the_belonging_object_with_primary_key
271
    client = Client.create(name: "Primary key client")
272 273 274 275 276
    apple  = client.build_firm_with_primary_key("name" => "Apple")
    client.save
    assert_equal apple.name, client.firm_name
  end

277
  def test_create!
278 279
    client  = Client.create!(name: "Jimmy")
    account = client.create_account!(credit_limit: 10)
280 281 282 283 284 285 286 287
    assert_equal account, client.account
    assert account.persisted?
    client.save
    client.reload
    assert_equal account, client.account
  end

  def test_failing_create!
288
    client = Client.create!(name: "Jimmy")
289 290 291 292 293
    assert_raise(ActiveRecord::RecordInvalid) { client.create_account! }
    assert_not_nil client.account
    assert client.account.new_record?
  end

294 295 296 297
  def test_natural_assignment_to_nil
    client = Client.find(3)
    client.firm = nil
    client.save
298 299
    client.association(:firm).reload
    assert_nil client.firm
300 301 302
    assert_nil client.client_of
  end

303
  def test_natural_assignment_to_nil_with_primary_key
304
    client = Client.create(name: "Primary key client", firm_name: companies(:first_firm).name)
305 306
    client.firm_with_primary_key = nil
    client.save
307 308
    client.association(:firm_with_primary_key).reload
    assert_nil client.firm_with_primary_key
309 310 311
    assert_nil client.client_of
  end

312 313 314 315 316 317 318 319 320 321
  def test_with_different_class_name
    assert_equal Company.find(1).name, Company.find(3).firm_with_other_name.name
    assert_not_nil Company.find(3).firm_with_other_name, "Microsoft should have a firm"
  end

  def test_with_condition
    assert_equal Company.find(1).name, Company.find(3).firm_with_condition.name
    assert_not_nil Company.find(3).firm_with_condition, "Microsoft should have a firm"
  end

322 323 324
  def test_polymorphic_association_class
    sponsor = Sponsor.new
    assert_nil sponsor.association(:sponsorable).send(:klass)
325 326
    sponsor.association(:sponsorable).reload
    assert_nil sponsor.sponsorable
327

328
    sponsor.sponsorable_type = "" # the column doesn't have to be declared NOT NULL
329
    assert_nil sponsor.association(:sponsorable).send(:klass)
330 331
    sponsor.association(:sponsorable).reload
    assert_nil sponsor.sponsorable
332

333
    sponsor.sponsorable = Member.new name: "Bert"
334
    assert_equal Member, sponsor.association(:sponsorable).send(:klass)
335
    assert_equal "members", sponsor.association(:sponsorable).aliased_table_name
336 337
  end

338 339
  def test_with_polymorphic_and_condition
    sponsor = Sponsor.create
340
    member = Member.create name: "Bert"
341 342 343 344 345 346
    sponsor.sponsorable = member

    assert_equal member, sponsor.sponsorable
    assert_nil sponsor.sponsorable_with_conditions
  end

347
  def test_with_select
J
Jon Leighton 已提交
348
    assert_equal 1, Company.find(2).firm_with_select.attributes.size
349
    assert_equal 1, Company.all.merge!(includes: :firm_with_select).find(2).firm_with_select.attributes.size
350 351
  end

352 353 354
  def test_belongs_to_without_counter_cache_option
    # Ship has a conventionally named `treasures_count` column, but the counter_cache
    # option is not given on the association.
355
    ship = Ship.create(name: "Countless")
356 357

    assert_no_difference lambda { ship.reload.treasures_count }, "treasures_count should not be changed unless counter_cache is given on the relation" do
358
      treasure = Treasure.new(name: "Gold", ship: ship)
359 360 361 362 363 364 365 366 367
      treasure.save
    end

    assert_no_difference lambda { ship.reload.treasures_count }, "treasures_count should not be changed unless counter_cache is given on the relation" do
      treasure = ship.treasures.first
      treasure.destroy
    end
  end

368 369
  def test_belongs_to_counter
    debate = Topic.create("title" => "debate")
370
    assert_equal 0, debate.read_attribute("replies_count"), "No replies yet"
371 372

    trash = debate.replies.create("title" => "blah!", "content" => "world around!")
373
    assert_equal 1, Topic.find(debate.id).read_attribute("replies_count"), "First reply created"
374 375

    trash.destroy
376
    assert_equal 0, Topic.find(debate.id).read_attribute("replies_count"), "First reply deleted"
377 378 379
  end

  def test_belongs_to_counter_with_assigning_nil
380 381
    post = Post.find(1)
    comment = Comment.find(1)
382

383 384
    assert_equal post.id, comment.post_id
    assert_equal 2, Post.find(post.id).comments.size
385

386
    comment.post = nil
387

388
    assert_equal 1, Post.find(post.id).comments.size
389 390
  end

391 392 393 394 395 396 397 398 399
  def test_belongs_to_with_primary_key_counter
    debate  = Topic.create("title" => "debate")
    debate2 = Topic.create("title" => "debate2")
    reply   = Reply.create("title" => "blah!", "content" => "world around!", "parent_title" => "debate")

    assert_equal 1, debate.reload.replies_count
    assert_equal 0, debate2.reload.replies_count

    reply.topic_with_primary_key = debate2
400

401 402
    assert_equal 0, debate.reload.replies_count
    assert_equal 1, debate2.reload.replies_count
403 404 405

    reply.topic_with_primary_key = nil

406 407
    assert_equal 0, debate.reload.replies_count
    assert_equal 0, debate2.reload.replies_count
408 409
  end

410
  def test_belongs_to_counter_with_reassigning
411 412 413 414
    topic1 = Topic.create("title" => "t1")
    topic2 = Topic.create("title" => "t2")
    reply1 = Reply.new("title" => "r1", "content" => "r1")
    reply1.topic = topic1
415

416 417 418
    assert reply1.save
    assert_equal 1, Topic.find(topic1.id).replies.size
    assert_equal 0, Topic.find(topic2.id).replies.size
419

420
    reply1.topic = Topic.find(topic2.id)
421

422
    assert_no_queries do
423
      reply1.topic = topic2
424 425
    end

426 427 428
    assert reply1.save
    assert_equal 0, Topic.find(topic1.id).replies.size
    assert_equal 1, Topic.find(topic2.id).replies.size
429

430
    reply1.topic = nil
431

432 433
    assert_equal 0, Topic.find(topic1.id).replies.size
    assert_equal 0, Topic.find(topic2.id).replies.size
434

435
    reply1.topic = topic1
436

437 438
    assert_equal 1, Topic.find(topic1.id).replies.size
    assert_equal 0, Topic.find(topic2.id).replies.size
439

440
    reply1.destroy
441

442 443
    assert_equal 0, Topic.find(topic1.id).replies.size
    assert_equal 0, Topic.find(topic2.id).replies.size
444 445
  end

446
  def test_belongs_to_reassign_with_namespaced_models_and_counters
447 448 449 450
    topic1 = Web::Topic.create("title" => "t1")
    topic2 = Web::Topic.create("title" => "t2")
    reply1 = Web::Reply.new("title" => "r1", "content" => "r1")
    reply1.topic = topic1
451

452 453 454
    assert reply1.save
    assert_equal 1, Web::Topic.find(topic1.id).replies.size
    assert_equal 0, Web::Topic.find(topic2.id).replies.size
455

456
    reply1.topic = Web::Topic.find(topic2.id)
457

458 459 460
    assert reply1.save
    assert_equal 0, Web::Topic.find(topic1.id).replies.size
    assert_equal 1, Web::Topic.find(topic2.id).replies.size
461 462
  end

463
  def test_belongs_to_counter_after_save
464 465
    topic = Topic.create!(title: "monday night")
    topic.replies.create!(title: "re: monday night", content: "football")
466 467 468 469 470 471
    assert_equal 1, Topic.find(topic.id)[:replies_count]

    topic.save!
    assert_equal 1, Topic.find(topic.id)[:replies_count]
  end

472 473 474 475 476 477 478
  def test_belongs_to_with_touch_option_on_touch
    line_item = LineItem.create!
    Invoice.create!(line_items: [line_item])

    assert_queries(1) { line_item.touch }
  end

A
Arthur Neves 已提交
479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496
  def test_belongs_to_with_touch_on_multiple_records
    line_item = LineItem.create!(amount: 1)
    line_item2 = LineItem.create!(amount: 2)
    Invoice.create!(line_items: [line_item, line_item2])

    assert_queries(1) do
      LineItem.transaction do
        line_item.touch
        line_item2.touch
      end
    end

    assert_queries(2) do
      line_item.touch
      line_item2.touch
    end
  end

497
  def test_belongs_to_with_touch_option_on_touch_without_updated_at_attributes
R
Rafael Mendonça França 已提交
498
    assert_not LineItem.column_names.include?("updated_at")
499 500 501 502

    line_item = LineItem.create!
    invoice = Invoice.create!(line_items: [line_item])
    initial = invoice.updated_at
503 504 505
    travel(1.second) do
      line_item.touch
    end
506

R
Rafael Mendonça França 已提交
507
    assert_not_equal initial, invoice.reload.updated_at
508 509
  end

510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525
  def test_belongs_to_with_touch_option_on_touch_and_removed_parent
    line_item = LineItem.create!
    Invoice.create!(line_items: [line_item])

    line_item.invoice = nil

    assert_queries(2) { line_item.touch }
  end

  def test_belongs_to_with_touch_option_on_update
    line_item = LineItem.create!
    Invoice.create!(line_items: [line_item])

    assert_queries(2) { line_item.update amount: 10 }
  end

526 527 528 529 530 531 532
  def test_belongs_to_with_touch_option_on_empty_update
    line_item = LineItem.create!
    Invoice.create!(line_items: [line_item])

    assert_queries(0) { line_item.save }
  end

533 534 535 536 537 538 539
  def test_belongs_to_with_touch_option_on_destroy
    line_item = LineItem.create!
    Invoice.create!(line_items: [line_item])

    assert_queries(2) { line_item.destroy }
  end

540 541 542 543 544 545 546 547
  def test_belongs_to_with_touch_option_on_destroy_with_destroyed_parent
    line_item = LineItem.create!
    invoice   = Invoice.create!(line_items: [line_item])
    invoice.destroy

    assert_queries(1) { line_item.destroy }
  end

548 549 550 551 552 553 554 555 556
  def test_belongs_to_with_touch_option_on_touch_and_reassigned_parent
    line_item = LineItem.create!
    Invoice.create!(line_items: [line_item])

    line_item.invoice = Invoice.create!

    assert_queries(3) { line_item.touch }
  end

557 558 559
  def test_belongs_to_counter_after_update
    topic = Topic.create!(title: "37s")
    topic.replies.create!(title: "re: 37s", content: "rails")
560 561
    assert_equal 1, Topic.find(topic.id)[:replies_count]

562
    topic.update(title: "37signals")
563 564 565
    assert_equal 1, Topic.find(topic.id)[:replies_count]
  end

566
  def test_belongs_to_counter_when_update_columns
567 568
    topic = Topic.create!(title: "37s")
    topic.replies.create!(title: "re: 37s", content: "rails")
G
ganesh 已提交
569 570
    assert_equal 1, Topic.find(topic.id)[:replies_count]

V
Vipul A M 已提交
571
    topic.update_columns(content: "rails is wonderful")
G
ganesh 已提交
572 573 574
    assert_equal 1, Topic.find(topic.id)[:replies_count]
  end

575 576 577 578
  def test_assignment_before_child_saved
    final_cut = Client.new("name" => "Final Cut")
    firm = Firm.find(1)
    final_cut.firm = firm
579
    assert !final_cut.persisted?
580
    assert final_cut.save
581 582
    assert final_cut.persisted?
    assert firm.persisted?
583
    assert_equal firm, final_cut.firm
584 585
    final_cut.association(:firm).reload
    assert_equal firm, final_cut.firm
586 587
  end

588 589 590 591
  def test_assignment_before_child_saved_with_primary_key
    final_cut = Client.new("name" => "Final Cut")
    firm = Firm.find(1)
    final_cut.firm_with_primary_key = firm
592
    assert !final_cut.persisted?
593
    assert final_cut.save
594 595
    assert final_cut.persisted?
    assert firm.persisted?
596
    assert_equal firm, final_cut.firm_with_primary_key
597 598
    final_cut.association(:firm_with_primary_key).reload
    assert_equal firm, final_cut.firm_with_primary_key
599 600
  end

601
  def test_new_record_with_foreign_key_but_no_object
602
    client = Client.new("firm_id" => 1)
603
    # sometimes tests on Oracle fail if ORDER BY is not provided therefore add always :order with :first
604
    assert_equal Firm.all.merge!(order: "id").first, client.firm_with_basic_id
605 606
  end

607 608 609 610
  def test_setting_foreign_key_after_nil_target_loaded
    client = Client.new
    client.firm_with_basic_id
    client.firm_id = 1
611

612 613 614 615 616 617 618 619 620 621
    assert_equal companies(:first_firm), client.firm_with_basic_id
  end

  def test_polymorphic_setting_foreign_key_after_nil_target_loaded
    sponsor = Sponsor.new
    sponsor.sponsorable
    sponsor.sponsorable_id = 1
    sponsor.sponsorable_type = "Member"

    assert_equal members(:groucho), sponsor.sponsorable
622 623
  end

624 625
  def test_dont_find_target_when_foreign_key_is_null
    tagging = taggings(:thinking_general)
P
Paul Nikitochkin 已提交
626
    assert_queries(0) { tagging.super_tag }
627 628
  end

629 630 631 632 633 634
  def test_dont_find_target_when_saving_foreign_key_after_stale_association_loaded
    client = Client.create!(name: "Test client", firm_with_basic_id: Firm.find(1))
    client.firm_id = Firm.create!(name: "Test firm").id
    assert_queries(1) { client.save! }
  end

635 636 637 638 639 640
  def test_field_name_same_as_foreign_key
    computer = Computer.find(1)
    assert_not_nil computer.developer, ":foreign key == attribute didn't lock up" # '
  end

  def test_counter_cache
641
    topic = Topic.create title: "Zoom-zoom-zoom"
642 643
    assert_equal 0, topic[:replies_count]

644
    reply = Reply.create(title: "re: zoom", content: "speedy quick!")
645 646 647 648 649 650 651 652 653
    reply.topic = topic

    assert_equal 1, topic.reload[:replies_count]
    assert_equal 1, topic.replies.size

    topic[:replies_count] = 15
    assert_equal 15, topic.replies.size
  end

654
  def test_counter_cache_double_destroy
655
    topic = Topic.create title: "Zoom-zoom-zoom"
656 657

    5.times do
658
      topic.replies.create(title: "re: zoom", content: "speedy quick!")
659 660 661 662 663 664 665 666 667 668 669 670 671 672 673
    end

    assert_equal 5, topic.reload[:replies_count]
    assert_equal 5, topic.replies.size

    reply = topic.replies.first

    reply.destroy
    assert_equal 4, topic.reload[:replies_count]

    reply.destroy
    assert_equal 4, topic.reload[:replies_count]
    assert_equal 4, topic.replies.size
  end

674
  def test_concurrent_counter_cache_double_destroy
675
    topic = Topic.create title: "Zoom-zoom-zoom"
676 677

    5.times do
678
      topic.replies.create(title: "re: zoom", content: "speedy quick!")
679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694
    end

    assert_equal 5, topic.reload[:replies_count]
    assert_equal 5, topic.replies.size

    reply = topic.replies.first
    reply_clone = Reply.find(reply.id)

    reply.destroy
    assert_equal 4, topic.reload[:replies_count]

    reply_clone.destroy
    assert_equal 4, topic.reload[:replies_count]
    assert_equal 4, topic.replies.size
  end

695
  def test_custom_counter_cache
696
    reply = Reply.create(title: "re: zoom", content: "speedy quick!")
697 698
    assert_equal 0, reply[:replies_count]

699
    silly = SillyReply.create(title: "gaga", content: "boo-boo")
700 701 702 703 704 705 706 707 708
    silly.reply = reply

    assert_equal 1, reply.reload[:replies_count]
    assert_equal 1, reply.replies.size

    reply[:replies_count] = 17
    assert_equal 17, reply.replies.size
  end

709 710 711 712 713 714 715 716 717 718 719
  def test_replace_counter_cache
    topic = Topic.create(title: "Zoom-zoom-zoom")
    reply = Reply.create(title: "re: zoom", content: "speedy quick!")

    reply.topic = topic
    reply.save
    topic.reload

    assert_equal 1, topic.replies_count
  end

720
  def test_association_assignment_sticks
721
    post = Post.first
722

723
    author1, author2 = Author.all.merge!(limit: 2).to_a
724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744
    assert_not_nil author1
    assert_not_nil author2

    # make sure the association is loaded
    post.author

    # set the association by id, directly
    post.author_id = author2.id

    # save and reload
    post.save!
    post.reload

    # the author id of the post should be the id we set
    assert_equal post.author_id, author2.id
  end

  def test_cant_save_readonly_association
    assert_raise(ActiveRecord::ReadOnlyRecord) { companies(:first_client).readonly_firm.save! }
    assert companies(:first_client).readonly_firm.readonly?
  end
745

746
  def test_polymorphic_assignment_foreign_key_type_string
747 748 749 750 751 752 753 754 755 756 757 758
    comment = Comment.first
    comment.author   = Author.first
    comment.resource = Member.first
    comment.save

    assert_equal Comment.all.to_a,
      Comment.includes(:author).to_a

    assert_equal Comment.all.to_a,
      Comment.includes(:resource).to_a
  end

759 760 761 762 763 764
  def test_polymorphic_assignment_foreign_type_field_updating
    # should update when assigning a saved record
    sponsor = Sponsor.new
    member = Member.create
    sponsor.sponsorable = member
    assert_equal "Member", sponsor.sponsorable_type
765

766 767 768 769 770 771
    # should update when assigning a new record
    sponsor = Sponsor.new
    member = Member.new
    sponsor.sponsorable = member
    assert_equal "Member", sponsor.sponsorable_type
  end
772 773 774 775

  def test_polymorphic_assignment_with_primary_key_foreign_type_field_updating
    # should update when assigning a saved record
    essay = Essay.new
776
    writer = Author.create(name: "David")
777 778 779 780 781 782 783 784 785
    essay.writer = writer
    assert_equal "Author", essay.writer_type

    # should update when assigning a new record
    essay = Essay.new
    writer = Author.new
    essay.writer = writer
    assert_equal "Author", essay.writer_type
  end
786

787 788 789 790
  def test_polymorphic_assignment_updates_foreign_id_field_for_new_and_saved_records
    sponsor = Sponsor.new
    saved_member = Member.create
    new_member = Member.new
791

792 793
    sponsor.sponsorable = saved_member
    assert_equal saved_member.id, sponsor.sponsorable_id
794

795
    sponsor.sponsorable = new_member
796
    assert_nil sponsor.sponsorable_id
797
  end
798

799 800
  def test_assignment_updates_foreign_id_field_for_new_and_saved_records
    client = Client.new
801
    saved_firm = Firm.create name: "Saved"
802 803 804 805 806 807 808 809 810
    new_firm = Firm.new

    client.firm = saved_firm
    assert_equal saved_firm.id, client.client_of

    client.firm = new_firm
    assert_nil client.client_of
  end

811 812
  def test_polymorphic_assignment_with_primary_key_updates_foreign_id_field_for_new_and_saved_records
    essay = Essay.new
813
    saved_writer = Author.create(name: "David")
814 815 816 817 818 819
    new_writer = Author.new

    essay.writer = saved_writer
    assert_equal saved_writer.name, essay.writer_id

    essay.writer = new_writer
820
    assert_nil essay.writer_id
821 822
  end

823 824 825 826 827 828
  def test_polymorphic_assignment_with_nil
    essay = Essay.new
    assert_nil essay.writer_id
    assert_nil essay.writer_type

    essay.writer_id = 1
829
    essay.writer_type = "Author"
830 831 832 833 834 835

    essay.writer = nil
    assert_nil essay.writer_id
    assert_nil essay.writer_type
  end

836
  def test_belongs_to_proxy_should_not_respond_to_private_methods
837 838
    assert_raise(NoMethodError) { companies(:first_firm).private_method }
    assert_raise(NoMethodError) { companies(:second_client).firm.private_method }
839 840 841 842 843 844
  end

  def test_belongs_to_proxy_should_respond_to_private_methods_via_send
    companies(:first_firm).send(:private_method)
    companies(:second_client).firm.send(:private_method)
  end
845 846 847 848 849 850

  def test_save_of_record_with_loaded_belongs_to
    @account = companies(:first_firm).account

    assert_nothing_raised do
      Account.find(@account.id).save!
851
      Account.all.merge!(includes: :firm).find(@account.id).save!
852 853 854 855 856 857
    end

    @account.firm.delete

    assert_nothing_raised do
      Account.find(@account.id).save!
858
      Account.all.merge!(includes: :firm).find(@account.id).save!
859 860
    end
  end
861 862

  def test_dependent_delete_and_destroy_with_belongs_to
A
Akira Matsuda 已提交
863 864
    AuthorAddress.destroyed_author_address_ids.clear

865 866 867 868 869 870 871 872
    author_address = author_addresses(:david_address)
    author_address_extra = author_addresses(:david_address_extra)
    assert_equal [], AuthorAddress.destroyed_author_address_ids

    assert_difference "AuthorAddress.count", -2 do
      authors(:david).destroy
    end

J
Jon Leighton 已提交
873
    assert_equal [], AuthorAddress.where(id: [author_address.id, author_address_extra.id])
874 875 876
    assert_equal [author_address.id], AuthorAddress.destroyed_author_address_ids
  end

877 878
  def test_belongs_to_invalid_dependent_option_raises_exception
    error = assert_raise ArgumentError do
879
      Class.new(Author).belongs_to :special_author_address, dependent: :nullify
880
    end
881
    assert_equal error.message, "The :dependent option must be one of [:destroy, :delete], but is :nullify"
882
  end
883 884

  def test_attributes_are_being_set_when_initialized_from_belongs_to_association_with_where_clause
885
    new_firm = accounts(:signals37).build_firm(name: "Apple")
886 887
    assert_equal new_firm.name, "Apple"
  end
888

889
  def test_attributes_are_set_without_error_when_initialized_from_belongs_to_association_with_array_in_where_clause
890
    new_account = Account.where(credit_limit: [ 50, 60 ]).new
891 892 893
    assert_nil new_account.credit_limit
  end

894
  def test_reassigning_the_parent_id_updates_the_object
895
    client = companies(:second_client)
896

897 898 899 900
    client.firm
    client.firm_with_condition
    firm_proxy                = client.send(:association_instance_get, :firm)
    firm_with_condition_proxy = client.send(:association_instance_get, :firm_with_condition)
901

902 903 904 905 906 907 908 909 910 911 912
    assert !firm_proxy.stale_target?
    assert !firm_with_condition_proxy.stale_target?
    assert_equal companies(:first_firm), client.firm
    assert_equal companies(:first_firm), client.firm_with_condition

    client.client_of = companies(:another_firm).id

    assert firm_proxy.stale_target?
    assert firm_with_condition_proxy.stale_target?
    assert_equal companies(:another_firm), client.firm
    assert_equal companies(:another_firm), client.firm_with_condition
913 914 915
  end

  def test_polymorphic_reassignment_of_associated_id_updates_the_object
916 917 918 919 920 921 922
    sponsor = sponsors(:moustache_club_sponsor_for_groucho)

    sponsor.sponsorable
    proxy = sponsor.send(:association_instance_get, :sponsorable)

    assert !proxy.stale_target?
    assert_equal members(:groucho), sponsor.sponsorable
923

924
    sponsor.sponsorable_id = members(:some_other_guy).id
925

926 927
    assert proxy.stale_target?
    assert_equal members(:some_other_guy), sponsor.sponsorable
928 929 930
  end

  def test_polymorphic_reassignment_of_associated_type_updates_the_object
931
    sponsor = sponsors(:moustache_club_sponsor_for_groucho)
932

933 934
    sponsor.sponsorable
    proxy = sponsor.send(:association_instance_get, :sponsorable)
935

936 937 938
    assert !proxy.stale_target?
    assert_equal members(:groucho), sponsor.sponsorable

939
    sponsor.sponsorable_type = "Firm"
940

941 942 943
    assert proxy.stale_target?
    assert_equal companies(:first_firm), sponsor.sponsorable
  end
944 945 946

  def test_reloading_association_with_key_change
    client = companies(:second_client)
947
    firm = client.association(:firm)
948 949

    client.firm = companies(:another_firm)
950 951
    firm.reload
    assert_equal companies(:another_firm), firm.target
952 953

    client.client_of = companies(:first_firm).id
954 955
    firm.reload
    assert_equal companies(:first_firm), firm.target
956
  end
957 958

  def test_polymorphic_counter_cache
959 960 961
    tagging = taggings(:welcome_general)
    post    = posts(:welcome)
    comment = comments(:greetings)
962

963
    assert_difference lambda { post.reload.tags_count }, -1 do
964
      assert_difference "comment.reload.tags_count", +1 do
965 966 967 968
        tagging.taggable = comment
      end
    end
  end
969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987

  def test_polymorphic_with_custom_foreign_type
    sponsor = sponsors(:moustache_club_sponsor_for_groucho)
    groucho = members(:groucho)
    other   = members(:some_other_guy)

    assert_equal groucho, sponsor.sponsorable
    assert_equal groucho, sponsor.thing

    sponsor.thing = other

    assert_equal other, sponsor.sponsorable
    assert_equal other, sponsor.thing

    sponsor.sponsorable = groucho

    assert_equal groucho, sponsor.sponsorable
    assert_equal groucho, sponsor.thing
  end
988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008

  def test_build_with_conditions
    client = companies(:second_client)
    firm   = client.build_bob_firm

    assert_equal "Bob", firm.name
  end

  def test_create_with_conditions
    client = companies(:second_client)
    firm   = client.create_bob_firm

    assert_equal "Bob", firm.name
  end

  def test_create_bang_with_conditions
    client = companies(:second_client)
    firm   = client.create_bob_firm!

    assert_equal "Bob", firm.name
  end
1009 1010

  def test_build_with_block
1011
    client = Client.create(name: "Client Company")
1012

1013
    firm = client.build_firm { |f| f.name = "Agency Company" }
1014
    assert_equal "Agency Company", firm.name
1015 1016 1017
  end

  def test_create_with_block
1018
    client = Client.create(name: "Client Company")
1019

1020
    firm = client.create_firm { |f| f.name = "Agency Company" }
1021
    assert_equal "Agency Company", firm.name
1022 1023 1024
  end

  def test_create_bang_with_block
1025
    client = Client.create(name: "Client Company")
1026

1027
    firm = client.create_firm! { |f| f.name = "Agency Company" }
1028
    assert_equal "Agency Company", firm.name
1029
  end
1030 1031

  def test_should_set_foreign_key_on_create_association
1032
    client = Client.create! name: "fuu"
1033

1034
    firm = client.create_firm name: "baa"
1035 1036 1037 1038
    assert_equal firm.id, client.client_of
  end

  def test_should_set_foreign_key_on_create_association!
1039
    client = Client.create! name: "fuu"
1040

1041
    firm = client.create_firm! name: "baa"
1042 1043
    assert_equal firm.id, client.client_of
  end
1044 1045

  def test_self_referential_belongs_to_with_counter_cache_assigning_nil
1046
    comment = Comment.create! post: posts(:thinking), body: "fuu"
1047 1048 1049 1050 1051 1052
    comment.parent = nil
    comment.save!

    assert_equal nil, comment.reload.parent
    assert_equal 0, comments(:greetings).reload.children_count
  end
1053

1054 1055 1056 1057 1058 1059 1060 1061 1062 1063 1064
  def test_belongs_to_with_id_assigning
    post = posts(:welcome)
    comment = Comment.create! body: "foo", post: post
    parent = comments(:greetings)
    assert_equal 0, parent.reload.children_count
    comment.parent_id = parent.id

    comment.save!
    assert_equal 1, parent.reload.children_count
  end

1065 1066
  def test_polymorphic_with_custom_primary_key
    toy = Toy.create!
1067
    sponsor = Sponsor.create!(sponsorable: toy)
1068 1069 1070

    assert_equal toy, sponsor.reload.sponsorable
  end
J
Jon Leighton 已提交
1071 1072 1073 1074 1075 1076 1077 1078 1079 1080 1081 1082

  test "stale tracking doesn't care about the type" do
    apple = Firm.create("name" => "Apple")
    citibank = Account.create("credit_limit" => 10)

    citibank.firm_id = apple.id
    citibank.firm # load it

    citibank.firm_id = apple.id.to_s

    assert !citibank.association(:firm).stale_target?
  end
1083

1084 1085
  def test_reflect_the_most_recent_change
    author1, author2 = Author.limit(2)
1086
    post = Post.new(title: "foo", body: "bar")
1087 1088 1089 1090 1091 1092 1093

    post.author    = author1
    post.author_id = author2.id

    assert post.save
    assert_equal post.author_id, author2.id
  end
1094

1095 1096
  test "dangerous association name raises ArgumentError" do
    [:errors, "errors", :save, "save"].each do |name|
1097 1098 1099 1100 1101 1102 1103
      assert_raises(ArgumentError, "Association #{name} should not be allowed") do
        Class.new(ActiveRecord::Base) do
          belongs_to name
        end
      end
    end
  end
1104

1105
  test "belongs_to works with model called Record" do
1106
    record = Record.create!
1107 1108
    Column.create! record: record
    assert_equal 1, Column.count
1109
  end
1110 1111 1112 1113 1114 1115

  def test_association_force_reload_with_only_true_is_deprecated
    client = Client.find(3)

    assert_deprecated { client.firm(true) }
  end
1116
end
1117 1118

class BelongsToWithForeignKeyTest < ActiveRecord::TestCase
1119 1120
  fixtures :authors, :author_addresses

1121 1122
  def test_destroy_linked_models
    address = AuthorAddress.create!
1123
    author = Author.create! name: "Author", author_address_id: address.id
1124 1125 1126 1127

    author.destroy!
  end
end