log_subscriber_test.rb 8.3 KB
Newer Older
1
require "abstract_unit"
2 3
require "active_support/log_subscriber/test_helper"
require "action_view/log_subscriber"
4 5
require "controller/fake_models"

6
class AVLogSubscriberTest < ActiveSupport::TestCase
7
  include ActiveSupport::LogSubscriber::TestHelper
8 9

  def setup
C
Carlhuda 已提交
10
    super
11 12

    view_paths     = ActionController::Base.view_paths
13
    lookup_context = ActionView::LookupContext.new(view_paths, {}, ["test"])
14 15 16
    renderer       = ActionView::Renderer.new(lookup_context)
    @view          = ActionView::Base.new(renderer, {})

17
    ActionView::LogSubscriber.attach_to :action_view
18

R
Ronak Jangir 已提交
19 20 21 22
    unless Rails.respond_to?(:root)
      @defined_root = true
      def Rails.root; :defined_root; end # Minitest `stub` expects the method to be defined.
    end
23 24 25 26
  end

  def teardown
    super
27

28
    ActiveSupport::LogSubscriber.log_subscribers.clear
29

R
Ronak Jangir 已提交
30 31
    # We need to undef `root`, RenderTestCases don't want this to be defined
    Rails.instance_eval { undef :root } if @defined_root
32 33 34
  end

  def set_logger(logger)
35
    ActionView::Base.logger = logger
36 37
  end

38 39 40 41 42 43 44
  def set_cache_controller
    controller = ActionController::Base.new
    controller.perform_caching = true
    controller.cache_store = ActiveSupport::Cache::MemoryStore.new
    @view.controller = controller
  end

45 46
  def set_view_cache_dependencies
    def @view.view_cache_dependencies; []; end
47
    def @view.combined_fragment_cache_key(*); "ahoy `controller` dependency"; end
48 49
  end

50
  def test_render_file_template
R
Ronak Jangir 已提交
51
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
52
      @view.render(file: "test/hello_world")
R
Ronak Jangir 已提交
53
      wait
54

55 56
      assert_equal 2, @logger.logged(:info).size
      assert_match(/Rendering test\/hello_world\.erb/, @logger.logged(:info).first)
R
Ronak Jangir 已提交
57 58
      assert_match(/Rendered test\/hello_world\.erb/, @logger.logged(:info).last)
    end
59 60 61
  end

  def test_render_text_template
R
Ronak Jangir 已提交
62
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
63
      @view.render(plain: "TEXT")
R
Ronak Jangir 已提交
64
      wait
65

66 67
      assert_equal 2, @logger.logged(:info).size
      assert_match(/Rendering text template/, @logger.logged(:info).first)
R
Ronak Jangir 已提交
68 69
      assert_match(/Rendered text template/, @logger.logged(:info).last)
    end
70 71 72
  end

  def test_render_inline_template
R
Ronak Jangir 已提交
73
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
74
      @view.render(inline: "<%= 'TEXT' %>")
R
Ronak Jangir 已提交
75
      wait
76

77 78
      assert_equal 2, @logger.logged(:info).size
      assert_match(/Rendering inline template/, @logger.logged(:info).first)
R
Ronak Jangir 已提交
79 80
      assert_match(/Rendered inline template/, @logger.logged(:info).last)
    end
81 82
  end

83
  def test_render_partial_with_implicit_path
R
Ronak Jangir 已提交
84
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
85
      @view.render(Customer.new("david"), greeting: "hi")
R
Ronak Jangir 已提交
86
      wait
87

R
Ronak Jangir 已提交
88
      assert_equal 1, @logger.logged(:info).size
89
      assert_match(/Rendered customers\/_customer\.html\.erb/, @logger.logged(:info).last)
R
Ronak Jangir 已提交
90
    end
91 92
  end

93
  def test_render_partial_with_cache_missed
R
Ronak Jangir 已提交
94
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
95
      set_view_cache_dependencies
96 97 98
      set_cache_controller

      @view.render(partial: "test/cached_customer", locals: { cached_customer: Customer.new("david") })
R
Ronak Jangir 已提交
99
      wait
100

R
Ronak Jangir 已提交
101
      assert_equal 1, @logger.logged(:info).size
102 103 104 105 106 107
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache miss\]/, @logger.logged(:info).last)
    end
  end

  def test_render_partial_with_cache_hitted
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
108
      set_view_cache_dependencies
109 110 111 112
      set_cache_controller

      # Second render should hit cache.
      @view.render(partial: "test/cached_customer", locals: { cached_customer: Customer.new("david") })
113
      @view.render(partial: "test/cached_customer", locals: { cached_customer: Customer.new("david") })
114 115 116 117 118 119 120
      wait

      assert_equal 2, @logger.logged(:info).size
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache hit\]/, @logger.logged(:info).last)
    end
  end

121
  def test_render_uncached_outer_partial_with_inner_cached_partial_wont_mix_cache_hits_or_misses
122 123 124 125 126 127
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
      set_view_cache_dependencies
      set_cache_controller

      @view.render(partial: "test/nested_cached_customer", locals: { cached_customer: Customer.new("Stan") })
      wait
128 129 130
      *, cached_inner, uncached_outer = @logger.logged(:info)
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache miss\]/, cached_inner)
      assert_match(/Rendered test\/_nested_cached_customer\.erb \(.*?ms\)$/, uncached_outer)
131

132
      # Second render hits the cache for the _cached_customer partial. Outer template's log shouldn't be affected.
133 134
      @view.render(partial: "test/nested_cached_customer", locals: { cached_customer: Customer.new("Stan") })
      wait
135 136 137
      *, cached_inner, uncached_outer = @logger.logged(:info)
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache hit\]/, cached_inner)
      assert_match(/Rendered test\/_nested_cached_customer\.erb \(.*?ms\)$/, uncached_outer)
138 139 140
    end
  end

141
  def test_render_cached_outer_partial_with_cached_inner_partial
142 143 144 145 146 147
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
      set_view_cache_dependencies
      set_cache_controller

      @view.render(partial: "test/cached_nested_cached_customer", locals: { cached_customer: Customer.new("Stan") })
      wait
148 149 150 151 152 153 154 155 156
      *, cached_inner, cached_outer = @logger.logged(:info)
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache miss\]/, cached_inner)
      assert_match(/Rendered test\/_cached_nested_cached_customer\.erb (.*) \[cache miss\]/, cached_outer)

      # One render: inner partial skipped, because the outer has been cached.
      assert_difference -> { @logger.logged(:info).size }, +1 do
        @view.render(partial: "test/cached_nested_cached_customer", locals: { cached_customer: Customer.new("Stan") })
        wait
      end
157 158 159 160
      assert_match(/Rendered test\/_cached_nested_cached_customer\.erb (.*) \[cache hit\]/, @logger.logged(:info).last)
    end
  end

161 162
  def test_render_partial_with_cache_hitted_and_missed
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
163
      set_view_cache_dependencies
164 165 166 167 168 169 170 171 172 173 174 175 176
      set_cache_controller

      @view.render(partial: "test/cached_customer", locals: { cached_customer: Customer.new("david") })
      wait
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache miss\]/, @logger.logged(:info).last)

      @view.render(partial: "test/cached_customer", locals: { cached_customer: Customer.new("david") })
      wait
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache hit\]/, @logger.logged(:info).last)

      @view.render(partial: "test/cached_customer", locals: { cached_customer: Customer.new("Stan") })
      wait
      assert_match(/Rendered test\/_cached_customer\.erb (.*) \[cache miss\]/, @logger.logged(:info).last)
R
Ronak Jangir 已提交
177
    end
178 179
  end

180
  def test_render_collection_template
R
Ronak Jangir 已提交
181
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
182
      @view.render(partial: "test/customer", collection: [ Customer.new("david"), Customer.new("mary") ])
R
Ronak Jangir 已提交
183
      wait
184

R
Ronak Jangir 已提交
185
      assert_equal 1, @logger.logged(:info).size
186
      assert_match(/Rendered collection of test\/_customer.erb \[2 times\]/, @logger.logged(:info).last)
R
Ronak Jangir 已提交
187
    end
188 189
  end

190
  def test_render_collection_with_implicit_path
R
Ronak Jangir 已提交
191
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
192
      @view.render([ Customer.new("david"), Customer.new("mary") ], greeting: "hi")
R
Ronak Jangir 已提交
193
      wait
194

R
Ronak Jangir 已提交
195
      assert_equal 1, @logger.logged(:info).size
196
      assert_match(/Rendered collection of customers\/_customer\.html\.erb \[2 times\]/, @logger.logged(:info).last)
R
Ronak Jangir 已提交
197
    end
198 199
  end

200
  def test_render_collection_template_without_path
R
Ronak Jangir 已提交
201
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
202
      @view.render([ GoodCustomer.new("david"), Customer.new("mary") ], greeting: "hi")
R
Ronak Jangir 已提交
203
      wait
204

R
Ronak Jangir 已提交
205
      assert_equal 1, @logger.logged(:info).size
206 207 208 209 210 211
      assert_match(/Rendered collection of templates/, @logger.logged(:info).last)
    end
  end

  def test_render_collection_with_cached_set
    Rails.stub(:root, File.expand_path(FIXTURE_LOAD_PATH)) do
212
      set_view_cache_dependencies
213

214 215
      @view.render(partial: "customers/customer", collection: [ Customer.new("david"), Customer.new("mary") ], cached: true,
        locals: { greeting: "hi" })
216 217 218 219
      wait

      assert_equal 1, @logger.logged(:info).size
      assert_match(/Rendered collection of customers\/_customer\.html\.erb \[0 \/ 2 cache hits\]/, @logger.logged(:info).last)
R
Ronak Jangir 已提交
220
    end
221
  end
222
end