finder_test.rb 33.6 KB
Newer Older
1
require "cases/helper"
2
require 'models/post'
J
Jeremy Kemper 已提交
3
require 'models/author'
4
require 'models/categorization'
J
Jeremy Kemper 已提交
5 6 7 8 9
require 'models/comment'
require 'models/company'
require 'models/topic'
require 'models/reply'
require 'models/entrant'
10
require 'models/project'
J
Jeremy Kemper 已提交
11
require 'models/developer'
12
require 'models/customer'
13
require 'models/toy'
14
require 'models/matey'
D
David Heinemeier Hansson 已提交
15

16
class FinderTest < ActiveRecord::TestCase
17
  fixtures :companies, :topics, :entrants, :developers, :developers_projects, :posts, :comments, :accounts, :authors, :customers, :categories, :categorizations
D
David Heinemeier Hansson 已提交
18

19 20 21 22 23 24 25 26 27 28 29 30
  def test_find_by_id_with_hash
    assert_raises(ActiveRecord::StatementInvalid) do
      Post.find_by_id(:limit => 1)
    end
  end

  def test_find_by_title_and_id_with_hash
    assert_raises(ActiveRecord::StatementInvalid) do
      Post.find_by_title_and_id('foo', :limit => 1)
    end
  end

D
David Heinemeier Hansson 已提交
31
  def test_find
32
    assert_equal(topics(:first).title, Topic.find(1).title)
D
David Heinemeier Hansson 已提交
33
  end
34

35 36 37 38 39 40 41
  def test_symbols_table_ref
    Post.first # warm up
    x = Symbol.all_symbols.count
    Post.where("title" => {"xxxqqqq" => "bar"})
    assert_equal x, Symbol.all_symbols.count
  end

42 43 44 45 46
  # find should handle strings that come from URLs
  # (example: Category.find(params[:id]))
  def test_find_with_string
    assert_equal(Topic.find(1).title,Topic.find("1").title)
  end
47

D
David Heinemeier Hansson 已提交
48
  def test_exists
49 50 51 52 53 54
    assert_equal true, Topic.exists?(1)
    assert_equal true, Topic.exists?("1")
    assert_equal true, Topic.exists?(title: "The First Topic")
    assert_equal true, Topic.exists?(heading: "The First Topic")
    assert_equal true, Topic.exists?(:author_name => "Mary", :approved => true)
    assert_equal true, Topic.exists?(["parent_id = ?", 1])
55
    assert_equal true, Topic.exists?(id: [1, 9999])
56 57 58

    assert_equal false, Topic.exists?(45)
    assert_equal false, Topic.exists?(Topic.new)
59 60

    begin
61
      assert_equal false, Topic.exists?("foo")
62 63 64 65 66 67
    rescue ActiveRecord::StatementInvalid
      # PostgreSQL complains about string comparison with integer field
    rescue Exception
      flunk
    end

68
    assert_raise(NoMethodError) { Topic.exists?([1,2]) }
D
David Heinemeier Hansson 已提交
69
  end
70

71
  def test_exists_does_not_select_columns_without_alias
72
    assert_sql(/SELECT\W+1 AS one FROM ["`]topics["`]/i) do
73 74 75 76
      Topic.exists?
    end
  end

77
  def test_exists_returns_true_with_one_record_and_no_args
78
    assert_equal true, Topic.exists?
79
  end
80

E
Egor Lynko 已提交
81
  def test_exists_returns_false_with_false_arg
82
    assert_equal false, Topic.exists?(false)
E
Egor Lynko 已提交
83 84
  end

85 86 87
  # exists? should handle nil for id's that come from URLs and always return false
  # (example: Topic.exists?(params[:id])) where params[:id] is nil
  def test_exists_with_nil_arg
88 89 90 91 92
    assert_equal false, Topic.exists?(nil)
    assert_equal true, Topic.exists?

    assert_equal false, Topic.first.replies.exists?(nil)
    assert_equal true, Topic.first.replies.exists?
93 94
  end

95 96
  # ensures +exists?+ runs valid SQL by excluding order value
  def test_exists_with_order
97
    assert_equal true, Topic.order(:id).distinct.exists?
98 99
  end

100
  def test_exists_with_includes_limit_and_empty_result
101 102
    assert_equal false, Topic.includes(:replies).limit(0).exists?
    assert_equal false, Topic.includes(:replies).limit(1).where('0 = 1').exists?
103 104
  end

105 106
  def test_exists_with_distinct_association_includes_and_limit
    author = Author.first
107 108
    assert_equal false, author.unique_categorized_posts.includes(:special_comments).limit(0).exists?
    assert_equal true, author.unique_categorized_posts.includes(:special_comments).limit(1).exists?
109 110 111 112
  end

  def test_exists_with_distinct_association_includes_limit_and_order
    author = Author.first
113 114
    assert_equal false, author.unique_categorized_posts.includes(:special_comments).order('comments.taggings_count DESC').limit(0).exists?
    assert_equal true, author.unique_categorized_posts.includes(:special_comments).order('comments.taggings_count DESC').limit(1).exists?
115 116
  end

117
  def test_exists_with_empty_table_and_no_args_given
118
    Topic.delete_all
119
    assert_equal false, Topic.exists?
120
  end
121

122 123
  def test_exists_with_aggregate_having_three_mappings
    existing_address = customers(:david).address
124
    assert_equal true, Customer.exists?(:address => existing_address)
125 126 127 128
  end

  def test_exists_with_aggregate_having_three_mappings_with_one_difference
    existing_address = customers(:david).address
129
    assert_equal false, Customer.exists?(:address =>
130
      Address.new(existing_address.street, existing_address.city, existing_address.country + "1"))
131
    assert_equal false, Customer.exists?(:address =>
132
      Address.new(existing_address.street, existing_address.city + "1", existing_address.country))
133
    assert_equal false, Customer.exists?(:address =>
134 135 136
      Address.new(existing_address.street + "1", existing_address.city, existing_address.country))
  end

137 138 139 140 141
  def test_exists_does_not_instantiate_records
    Developer.expects(:instantiate).never
    Developer.exists?
  end

D
David Heinemeier Hansson 已提交
142 143 144 145
  def test_find_by_array_of_one_id
    assert_kind_of(Array, Topic.find([ 1 ]))
    assert_equal(1, Topic.find([ 1 ]).length)
  end
146

D
David Heinemeier Hansson 已提交
147
  def test_find_by_ids
148 149 150 151 152
    assert_equal 2, Topic.find(1, 2).size
    assert_equal topics(:second).title, Topic.find([2]).first.title
  end

  def test_find_by_ids_with_limit_and_offset
153 154
    assert_equal 2, Entrant.all.merge!(:limit => 2).find([1,3,2]).size
    assert_equal 1, Entrant.all.merge!(:limit => 3, :offset => 2).find([1,3,2]).size
155 156 157 158

    # Also test an edge case: If you have 11 results, and you set a
    #   limit of 3 and offset of 9, then you should find that there
    #   will be only 2 results, regardless of the limit.
J
Jon Leighton 已提交
159
    devs = Developer.all
160
    last_devs = Developer.all.merge!(:limit => 3, :offset => 9).find devs.map(&:id)
161
    assert_equal 2, last_devs.size
D
David Heinemeier Hansson 已提交
162 163
  end

164 165 166 167
  def test_find_an_empty_array
    assert_equal [], Topic.find([])
  end

168 169 170 171
  def test_find_doesnt_have_implicit_ordering
    assert_sql(/^((?!ORDER).)*$/) { Topic.find(1) }
  end

D
David Heinemeier Hansson 已提交
172
  def test_find_by_ids_missing_one
173
    assert_raise(ActiveRecord::RecordNotFound) { Topic.find(1, 2, 45) }
D
David Heinemeier Hansson 已提交
174
  end
175

176
  def test_find_with_group_and_sanitized_having_method
177
    developers = Developer.group(:salary).having("sum(salary) > ?", 10000).select('salary').to_a
178 179 180 181 182
    assert_equal 3, developers.size
    assert_equal 3, developers.map(&:salary).uniq.size
    assert developers.all? { |developer| developer.salary > 10000 }
  end

D
David Heinemeier Hansson 已提交
183 184
  def test_find_with_entire_select_statement
    topics = Topic.find_by_sql "SELECT * FROM topics WHERE author_name = 'Mary'"
185

D
David Heinemeier Hansson 已提交
186
    assert_equal(1, topics.size)
187
    assert_equal(topics(:second).title, topics.first.title)
D
David Heinemeier Hansson 已提交
188
  end
189

D
David Heinemeier Hansson 已提交
190 191
  def test_find_with_prepared_select_statement
    topics = Topic.find_by_sql ["SELECT * FROM topics WHERE author_name = ?", "Mary"]
192

D
David Heinemeier Hansson 已提交
193
    assert_equal(1, topics.size)
194
    assert_equal(topics(:second).title, topics.first.title)
D
David Heinemeier Hansson 已提交
195
  end
196

197 198 199 200
  def test_find_by_sql_with_sti_on_joined_table
    accounts = Account.find_by_sql("SELECT * FROM accounts INNER JOIN companies ON companies.id = accounts.firm_id")
    assert_equal [Account], accounts.collect(&:class).uniq
  end
201

202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221
  def test_take
    assert_equal topics(:first), Topic.take
  end

  def test_take_failing
    assert_nil Topic.where("title = 'This title does not exist'").take
  end

  def test_take_bang_present
    assert_nothing_raised do
      assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").take!
    end
  end

  def test_take_bang_missing
    assert_raises ActiveRecord::RecordNotFound do
      Topic.where("title = 'This title does not exist'").take!
    end
  end

222
  def test_first
223
    assert_equal topics(:second).title, Topic.where("title = 'The Second Topic of the day'").first.title
224
  end
225

226
  def test_first_failing
227
    assert_nil Topic.where("title = 'The Second Topic of the day!'").first
228
  end
D
David Heinemeier Hansson 已提交
229

230 231 232 233 234 235 236 237 238 239 240 241
  def test_first_bang_present
    assert_nothing_raised do
      assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").first!
    end
  end

  def test_first_bang_missing
    assert_raises ActiveRecord::RecordNotFound do
      Topic.where("title = 'This title does not exist'").first!
    end
  end

242 243 244 245 246 247
  def test_first_have_primary_key_order_by_default
    expected = topics(:first)
    expected.touch # PostgreSQL changes the default order if no order clause is used
    assert_equal expected, Topic.first
  end

248
  def test_model_class_responds_to_first_bang
249 250
    assert Topic.first!
    Topic.delete_all
251 252 253 254 255
    assert_raises ActiveRecord::RecordNotFound do
      Topic.first!
    end
  end

256 257 258 259 260 261 262 263 264 265 266 267
  def test_last_bang_present
    assert_nothing_raised do
      assert_equal topics(:second), Topic.where("title = 'The Second Topic of the day'").last!
    end
  end

  def test_last_bang_missing
    assert_raises ActiveRecord::RecordNotFound do
      Topic.where("title = 'This title does not exist'").last!
    end
  end

268 269 270 271 272 273 274 275
  def test_model_class_responds_to_last_bang
    assert_equal topics(:fourth), Topic.last!
    assert_raises ActiveRecord::RecordNotFound do
      Topic.delete_all
      Topic.last!
    end
  end

276 277
  def test_take_and_first_and_last_with_integer_should_use_sql_limit
    assert_sql(/LIMIT 3|ROWNUM <= 3/) { Topic.take(3).entries }
278 279
    assert_sql(/LIMIT 2|ROWNUM <= 2/) { Topic.first(2).entries }
    assert_sql(/LIMIT 5|ROWNUM <= 5/) { Topic.last(5).entries }
280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295
  end

  def test_last_with_integer_and_order_should_keep_the_order
    assert_equal Topic.order("title").to_a.last(2), Topic.order("title").last(2)
  end

  def test_last_with_integer_and_order_should_not_use_sql_limit
    query = assert_sql { Topic.order("title").last(5).entries }
    assert_equal 1, query.length
    assert_no_match(/LIMIT/, query.first)
  end

  def test_last_with_integer_and_reorder_should_not_use_sql_limit
    query = assert_sql { Topic.reorder("title").last(5).entries }
    assert_equal 1, query.length
    assert_no_match(/LIMIT/, query.first)
296 297
  end

298 299
  def test_take_and_first_and_last_with_integer_should_return_an_array
    assert_kind_of Array, Topic.take(5)
300 301 302 303
    assert_kind_of Array, Topic.first(5)
    assert_kind_of Array, Topic.last(5)
  end

D
David Heinemeier Hansson 已提交
304
  def test_unexisting_record_exception_handling
305
    assert_raise(ActiveRecord::RecordNotFound) {
D
David Heinemeier Hansson 已提交
306 307
      Topic.find(1).parent
    }
308

309
    Topic.find(2).topic
D
David Heinemeier Hansson 已提交
310
  end
311

312
  def test_find_only_some_columns
313
    topic = Topic.all.merge!(:select => "author_name").find(1)
314
    assert_raise(ActiveModel::MissingAttributeError) {topic.title}
315
    assert_raise(ActiveModel::MissingAttributeError) {topic.title?}
316
    assert_nil topic.read_attribute("title")
317 318
    assert_equal "David", topic.author_name
    assert !topic.attribute_present?("title")
319
    assert !topic.attribute_present?(:title)
320
    assert topic.attribute_present?("author_name")
321
    assert_respond_to topic, "author_name"
322
  end
J
Jeremy Kemper 已提交
323

324
  def test_find_on_array_conditions
325 326
    assert Topic.all.merge!(:where => ["approved = ?", false]).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => ["approved = ?", true]).find(1) }
D
David Heinemeier Hansson 已提交
327
  end
328

329
  def test_find_on_hash_conditions
330 331
    assert Topic.all.merge!(:where => { :approved => false }).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :approved => true }).find(1) }
332
  end
333

334
  def test_find_on_hash_conditions_with_explicit_table_name
335 336
    assert Topic.all.merge!(:where => { 'topics.approved' => false }).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { 'topics.approved' => true }).find(1) }
337 338
  end

339
  def test_find_on_hash_conditions_with_hashed_table_name
340 341
    assert Topic.all.merge!(:where => {:topics => { :approved => false }}).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => {:topics => { :approved => true }}).find(1) }
342 343 344
  end

  def test_find_with_hash_conditions_on_joined_table
345
    firms = Firm.joins(:account).where(:accounts => { :credit_limit => 50 })
346 347 348 349 350
    assert_equal 1, firms.size
    assert_equal companies(:first_firm), firms.first
  end

  def test_find_with_hash_conditions_on_joined_table_and_with_range
351
    firms = DependentFirm.all.merge!(:joins => :account, :where => {:name => 'RailsCore', :accounts => { :credit_limit => 55..60 }})
352 353 354 355
    assert_equal 1, firms.size
    assert_equal companies(:rails_core), firms.first
  end

356 357 358 359 360 361 362 363
  def test_find_on_hash_conditions_with_explicit_table_name_and_aggregate
    david = customers(:david)
    assert Customer.where('customers.name' => david.name, :address => david.address).find(david.id)
    assert_raise(ActiveRecord::RecordNotFound) {
      Customer.where('customers.name' => david.name + "1", :address => david.address).find(david.id)
    }
  end

364
  def test_find_on_association_proxy_conditions
J
Jon Leighton 已提交
365
    assert_equal [1, 2, 3, 5, 6, 7, 8, 9, 10, 12], Comment.where(post_id: authors(:david).posts).map(&:id).sort
366 367
  end

368
  def test_find_on_hash_conditions_with_range
369 370
    assert_equal [1,2], Topic.all.merge!(:where => { :id => 1..2 }).to_a.map(&:id).sort
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :id => 2..3 }).find(1) }
371
  end
372

373
  def test_find_on_hash_conditions_with_end_exclusive_range
374 375 376
    assert_equal [1,2,3], Topic.all.merge!(:where => { :id => 1..3 }).to_a.map(&:id).sort
    assert_equal [1,2], Topic.all.merge!(:where => { :id => 1...3 }).to_a.map(&:id).sort
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :id => 2...3 }).find(3) }
377 378
  end

379
  def test_find_on_hash_conditions_with_multiple_ranges
380 381
    assert_equal [1,2,3], Comment.all.merge!(:where => { :id => 1..3, :post_id => 1..2 }).to_a.map(&:id).sort
    assert_equal [1], Comment.all.merge!(:where => { :id => 1..1, :post_id => 1..10 }).to_a.map(&:id).sort
382
  end
383

384
  def test_find_on_hash_conditions_with_array_of_integers_and_ranges
385
    assert_equal [1,2,3,5,6,7,8,9], Comment.all.merge!(:where => {:id => [1..2, 3, 5, 6..8, 9]}).to_a.map(&:id).sort
386 387
  end

388
  def test_find_on_multiple_hash_conditions
389 390 391 392
    assert Topic.all.merge!(:where => { :author_name => "David", :title => "The First Topic", :replies_count => 1, :approved => false }).find(1)
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :author_name => "David", :title => "The First Topic", :replies_count => 1, :approved => true }).find(1) }
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :author_name => "David", :title => "HHC", :replies_count => 1, :approved => false }).find(1) }
    assert_raise(ActiveRecord::RecordNotFound) { Topic.all.merge!(:where => { :author_name => "David", :title => "The First Topic", :replies_count => 1, :approved => true }).find(1) }
393
  end
394

395
  def test_condition_interpolation
396
    assert_kind_of Firm, Company.where("name = '%s'", "37signals").first
397 398 399
    assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!"]).first
    assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!' OR 1=1"]).first
    assert_kind_of Time, Topic.all.merge!(:where => ["id = %d", 1]).first.written_on
400 401
  end

402
  def test_condition_array_interpolation
403 404 405 406
    assert_kind_of Firm, Company.all.merge!(:where => ["name = '%s'", "37signals"]).first
    assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!"]).first
    assert_nil Company.all.merge!(:where => ["name = '%s'", "37signals!' OR 1=1"]).first
    assert_kind_of Time, Topic.all.merge!(:where => ["id = %d", 1]).first.written_on
D
David Heinemeier Hansson 已提交
407
  end
408

409
  def test_condition_hash_interpolation
410 411 412
    assert_kind_of Firm, Company.all.merge!(:where => { :name => "37signals"}).first
    assert_nil Company.all.merge!(:where => { :name => "37signals!"}).first
    assert_kind_of Time, Topic.all.merge!(:where => {:id => 1}).first.written_on
413
  end
414

415
  def test_hash_condition_find_malformed
416
    assert_raise(ActiveRecord::StatementInvalid) {
417
      Company.all.merge!(:where => { :id => 2, :dhh => true }).first
418 419
    }
  end
420

421 422
  def test_hash_condition_find_with_escaped_characters
    Company.create("name" => "Ain't noth'n like' \#stuff")
423
    assert Company.all.merge!(:where => { :name => "Ain't noth'n like' \#stuff" }).first
424 425 426
  end

  def test_hash_condition_find_with_array
427 428 429
    p1, p2 = Post.all.merge!(:limit => 2, :order => 'id asc').to_a
    assert_equal [p1, p2], Post.all.merge!(:where => { :id => [p1, p2] }, :order => 'id asc').to_a
    assert_equal [p1, p2], Post.all.merge!(:where => { :id => [p1, p2.id] }, :order => 'id asc').to_a
430 431 432
  end

  def test_hash_condition_find_with_nil
433
    topic = Topic.all.merge!(:where => { :last_read => nil } ).first
434 435
    assert_not_nil topic
    assert_nil topic.last_read
436
  end
D
David Heinemeier Hansson 已提交
437

438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479
  def test_hash_condition_find_with_aggregate_having_one_mapping
    balance = customers(:david).balance
    assert_kind_of Money, balance
    found_customer = Customer.where(:balance => balance).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_attribute_having_same_name_as_field_and_key_value_being_aggregate
    gps_location = customers(:david).gps_location
    assert_kind_of GpsLocation, gps_location
    found_customer = Customer.where(:gps_location => gps_location).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_having_one_mapping_and_key_value_being_attribute_value
    balance = customers(:david).balance
    assert_kind_of Money, balance
    found_customer = Customer.where(:balance => balance.amount).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_attribute_having_same_name_as_field_and_key_value_being_attribute_value
    gps_location = customers(:david).gps_location
    assert_kind_of GpsLocation, gps_location
    found_customer = Customer.where(:gps_location => gps_location.gps_location).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_aggregate_having_three_mappings
    address = customers(:david).address
    assert_kind_of Address, address
    found_customer = Customer.where(:address => address).first
    assert_equal customers(:david), found_customer
  end

  def test_hash_condition_find_with_one_condition_being_aggregate_and_another_not
    address = customers(:david).address
    assert_kind_of Address, address
    found_customer = Customer.where(:address => address, :name => customers(:david).name).first
    assert_equal customers(:david), found_customer
  end

480 481 482 483
  def test_condition_utc_time_interpolation_with_default_timezone_local
    with_env_tz 'America/New_York' do
      with_active_record_default_timezone :local do
        topic = Topic.first
484
        assert_equal topic, Topic.all.merge!(:where => ['written_on = ?', topic.written_on.getutc]).first
485 486 487 488 489 490 491 492
      end
    end
  end

  def test_hash_condition_utc_time_interpolation_with_default_timezone_local
    with_env_tz 'America/New_York' do
      with_active_record_default_timezone :local do
        topic = Topic.first
493
        assert_equal topic, Topic.all.merge!(:where => {:written_on => topic.written_on.getutc}).first
494 495 496 497 498 499 500 501
      end
    end
  end

  def test_condition_local_time_interpolation_with_default_timezone_utc
    with_env_tz 'America/New_York' do
      with_active_record_default_timezone :utc do
        topic = Topic.first
502
        assert_equal topic, Topic.all.merge!(:where => ['written_on = ?', topic.written_on.getlocal]).first
503 504 505 506 507 508 509 510
      end
    end
  end

  def test_hash_condition_local_time_interpolation_with_default_timezone_utc
    with_env_tz 'America/New_York' do
      with_active_record_default_timezone :utc do
        topic = Topic.first
511
        assert_equal topic, Topic.all.merge!(:where => {:written_on => topic.written_on.getlocal}).first
512 513 514 515
      end
    end
  end

D
David Heinemeier Hansson 已提交
516
  def test_bind_variables
517 518 519 520
    assert_kind_of Firm, Company.all.merge!(:where => ["name = ?", "37signals"]).first
    assert_nil Company.all.merge!(:where => ["name = ?", "37signals!"]).first
    assert_nil Company.all.merge!(:where => ["name = ?", "37signals!' OR 1=1"]).first
    assert_kind_of Time, Topic.all.merge!(:where => ["id = ?", 1]).first.written_on
521
    assert_raise(ActiveRecord::PreparedStatementInvalid) {
522
      Company.all.merge!(:where => ["id=? AND name = ?", 2]).first
D
David Heinemeier Hansson 已提交
523
    }
524
    assert_raise(ActiveRecord::PreparedStatementInvalid) {
525
     Company.all.merge!(:where => ["id=?", 2, 3, 4]).first
D
David Heinemeier Hansson 已提交
526 527
    }
  end
528

D
David Heinemeier Hansson 已提交
529 530
  def test_bind_variables_with_quotes
    Company.create("name" => "37signals' go'es agains")
531
    assert Company.all.merge!(:where => ["name = ?", "37signals' go'es agains"]).first
D
David Heinemeier Hansson 已提交
532 533 534 535
  end

  def test_named_bind_variables_with_quotes
    Company.create("name" => "37signals' go'es agains")
536
    assert Company.all.merge!(:where => ["name = :name", {:name => "37signals' go'es agains"}]).first
D
David Heinemeier Hansson 已提交
537 538 539 540
  end

  def test_bind_arity
    assert_nothing_raised                                 { bind '' }
541
    assert_raise(ActiveRecord::PreparedStatementInvalid) { bind '', 1 }
542

543
    assert_raise(ActiveRecord::PreparedStatementInvalid) { bind '?' }
D
David Heinemeier Hansson 已提交
544
    assert_nothing_raised                                 { bind '?', 1 }
545
    assert_raise(ActiveRecord::PreparedStatementInvalid) { bind '?', 1, 1  }
D
David Heinemeier Hansson 已提交
546
  end
547

D
David Heinemeier Hansson 已提交
548 549 550
  def test_named_bind_variables
    assert_equal '1', bind(':a', :a => 1) # ' ruby-mode
    assert_equal '1 1', bind(':a :a', :a => 1)  # ' ruby-mode
551

552
    assert_nothing_raised { bind("'+00:00'", :foo => "bar") }
553

554 555 556 557
    assert_kind_of Firm, Company.all.merge!(:where => ["name = :name", { :name => "37signals" }]).first
    assert_nil Company.all.merge!(:where => ["name = :name", { :name => "37signals!" }]).first
    assert_nil Company.all.merge!(:where => ["name = :name", { :name => "37signals!' OR 1=1" }]).first
    assert_kind_of Time, Topic.all.merge!(:where => ["id = :id", { :id => 1 }]).first.written_on
D
David Heinemeier Hansson 已提交
558 559
  end

560 561 562 563 564 565 566 567 568 569 570 571
  class SimpleEnumerable
    include Enumerable

    def initialize(ary)
      @ary = ary
    end

    def each(&b)
      @ary.each(&b)
    end
  end

572
  def test_bind_enumerable
573 574
    quoted_abc = %(#{ActiveRecord::Base.connection.quote('a')},#{ActiveRecord::Base.connection.quote('b')},#{ActiveRecord::Base.connection.quote('c')})

D
David Heinemeier Hansson 已提交
575
    assert_equal '1,2,3', bind('?', [1, 2, 3])
576
    assert_equal quoted_abc, bind('?', %w(a b c))
D
David Heinemeier Hansson 已提交
577 578

    assert_equal '1,2,3', bind(':a', :a => [1, 2, 3])
579
    assert_equal quoted_abc, bind(':a', :a => %w(a b c)) # '
580

581 582
    assert_equal '1,2,3', bind('?', SimpleEnumerable.new([1, 2, 3]))
    assert_equal quoted_abc, bind('?', SimpleEnumerable.new(%w(a b c)))
583

584 585
    assert_equal '1,2,3', bind(':a', :a => SimpleEnumerable.new([1, 2, 3]))
    assert_equal quoted_abc, bind(':a', :a => SimpleEnumerable.new(%w(a b c))) # '
D
David Heinemeier Hansson 已提交
586 587
  end

588 589 590 591 592 593 594
  def test_bind_empty_enumerable
    quoted_nil = ActiveRecord::Base.connection.quote(nil)
    assert_equal quoted_nil, bind('?', [])
    assert_equal " in (#{quoted_nil})", bind(' in (?)', [])
    assert_equal "foo in (#{quoted_nil})", bind('foo in (?)', [])
  end

J
Jeremy Kemper 已提交
595 596 597
  def test_bind_empty_string
    quoted_empty = ActiveRecord::Base.connection.quote('')
    assert_equal quoted_empty, bind('?', '')
598 599
  end

600 601 602 603 604
  def test_bind_chars
    quoted_bambi = ActiveRecord::Base.connection.quote("Bambi")
    quoted_bambi_and_thumper = ActiveRecord::Base.connection.quote("Bambi\nand\nThumper")
    assert_equal "name=#{quoted_bambi}", bind('name=?', "Bambi")
    assert_equal "name=#{quoted_bambi_and_thumper}", bind('name=?', "Bambi\nand\nThumper")
605 606
    assert_equal "name=#{quoted_bambi}", bind('name=?', "Bambi".mb_chars)
    assert_equal "name=#{quoted_bambi_and_thumper}", bind('name=?', "Bambi\nand\nThumper".mb_chars)
607 608
  end

609 610 611 612 613 614 615 616
  def test_bind_record
    o = Struct.new(:quoted_id).new(1)
    assert_equal '1', bind('?', o)

    os = [o] * 3
    assert_equal '1,1,1', bind('?', os)
  end

617 618 619
  def test_named_bind_with_postgresql_type_casts
    l = Proc.new { bind(":a::integer '2009-01-01'::date", :a => '10') }
    assert_nothing_raised(&l)
620
    assert_equal "#{ActiveRecord::Base.connection.quote('10')}::integer '2009-01-01'::date", l.call
621 622
  end

D
David Heinemeier Hansson 已提交
623
  def test_string_sanitation
624 625
    assert_not_equal "'something ' 1=1'", ActiveRecord::Base.sanitize("something ' 1=1")
    assert_equal "'something; select table'", ActiveRecord::Base.sanitize("something; select table")
D
David Heinemeier Hansson 已提交
626 627 628 629 630 631 632 633 634
  end

  def test_count_by_sql
    assert_equal(0, Entrant.count_by_sql("SELECT COUNT(*) FROM entrants WHERE id > 3"))
    assert_equal(1, Entrant.count_by_sql(["SELECT COUNT(*) FROM entrants WHERE id > ?", 2]))
    assert_equal(2, Entrant.count_by_sql(["SELECT COUNT(*) FROM entrants WHERE id > ?", 1]))
  end

  def test_find_by_one_attribute
635
    assert_equal topics(:first), Topic.find_by_title("The First Topic")
D
David Heinemeier Hansson 已提交
636 637
    assert_nil Topic.find_by_title("The First Topic!")
  end
J
Jeremy Kemper 已提交
638

639 640
  def test_find_by_one_attribute_bang
    assert_equal topics(:first), Topic.find_by_title!("The First Topic")
641
    assert_raise(ActiveRecord::RecordNotFound) { Topic.find_by_title!("The First Topic!") }
642 643
  end

644 645 646 647 648
  def test_find_by_one_attribute_that_is_an_alias
    assert_equal topics(:first), Topic.find_by_heading("The First Topic")
    assert_nil Topic.find_by_heading("The First Topic!")
  end

N
Nikita Afanasenko 已提交
649
  def test_find_by_one_attribute_bang_with_blank_defined
650 651
    blank_topic = BlankTopic.create(title: "The Blank One")
    assert_equal blank_topic, BlankTopic.find_by_title!("The Blank One")
N
Nikita Afanasenko 已提交
652 653
  end

654
  def test_find_by_one_attribute_with_conditions
J
Jon Leighton 已提交
655
    assert_equal accounts(:rails_core_account), Account.where('firm_id = ?', 6).find_by_credit_limit(50)
656 657
  end

658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691
  def test_find_by_one_attribute_that_is_an_aggregate
    address = customers(:david).address
    assert_kind_of Address, address
    found_customer = Customer.find_by_address(address)
    assert_equal customers(:david), found_customer
  end

  def test_find_by_one_attribute_that_is_an_aggregate_with_one_attribute_difference
    address = customers(:david).address
    assert_kind_of Address, address
    missing_address = Address.new(address.street, address.city, address.country + "1")
    assert_nil Customer.find_by_address(missing_address)
    missing_address = Address.new(address.street, address.city + "1", address.country)
    assert_nil Customer.find_by_address(missing_address)
    missing_address = Address.new(address.street + "1", address.city, address.country)
    assert_nil Customer.find_by_address(missing_address)
  end

  def test_find_by_two_attributes_that_are_both_aggregates
    balance = customers(:david).balance
    address = customers(:david).address
    assert_kind_of Money, balance
    assert_kind_of Address, address
    found_customer = Customer.find_by_balance_and_address(balance, address)
    assert_equal customers(:david), found_customer
  end

  def test_find_by_two_attributes_with_one_being_an_aggregate
    balance = customers(:david).balance
    assert_kind_of Money, balance
    found_customer = Customer.find_by_balance_and_name(balance, customers(:david).name)
    assert_equal customers(:david), found_customer
  end

692 693
  def test_dynamic_finder_on_one_attribute_with_conditions_returns_same_results_after_caching
    # ensure this test can run independently of order
A
Akira Matsuda 已提交
694
    class << Account; self; end.send(:remove_method, :find_by_credit_limit) if Account.public_methods.include?(:find_by_credit_limit)
J
Jon Leighton 已提交
695 696
    a = Account.where('firm_id = ?', 6).find_by_credit_limit(50)
    assert_equal a, Account.where('firm_id = ?', 6).find_by_credit_limit(50) # find_by_credit_limit has been cached
697 698
  end

699
  def test_find_by_one_attribute_with_several_options
J
Jon Leighton 已提交
700
    assert_equal accounts(:unknown), Account.order('id DESC').where('id != ?', 3).find_by_credit_limit(50)
701
  end
702

D
David Heinemeier Hansson 已提交
703
  def test_find_by_one_missing_attribute
704
    assert_raise(NoMethodError) { Topic.find_by_undertitle("The First Topic!") }
D
David Heinemeier Hansson 已提交
705
  end
706

707
  def test_find_by_invalid_method_syntax
708 709 710 711
    assert_raise(NoMethodError) { Topic.fail_to_find_by_title("The First Topic") }
    assert_raise(NoMethodError) { Topic.find_by_title?("The First Topic") }
    assert_raise(NoMethodError) { Topic.fail_to_find_or_create_by_title("Nonexistent Title") }
    assert_raise(NoMethodError) { Topic.find_or_create_by_title?("Nonexistent Title") }
712
  end
D
David Heinemeier Hansson 已提交
713 714

  def test_find_by_two_attributes
715
    assert_equal topics(:first), Topic.find_by_title_and_author_name("The First Topic", "David")
D
David Heinemeier Hansson 已提交
716 717 718
    assert_nil Topic.find_by_title_and_author_name("The First Topic", "Mary")
  end

719 720 721 722
  def test_find_by_two_attributes_but_passing_only_one
    assert_raise(ArgumentError) { Topic.find_by_title_and_author_name("The First Topic") }
  end

D
David Heinemeier Hansson 已提交
723 724 725 726 727
  def test_find_by_nil_attribute
    topic = Topic.find_by_last_read nil
    assert_not_nil topic
    assert_nil topic.last_read
  end
728

D
David Heinemeier Hansson 已提交
729 730 731 732 733 734
  def test_find_by_nil_and_not_nil_attributes
    topic = Topic.find_by_last_read_and_author_name nil, "Mary"
    assert_equal "Mary", topic.author_name
  end

  def test_find_with_bad_sql
735
    assert_raise(ActiveRecord::StatementInvalid) { Topic.find_by_sql "select 1 from badtable" }
D
David Heinemeier Hansson 已提交
736 737
  end

738
  def test_find_all_with_join
739
    developers_on_project_one = Developer.all.merge!(
740
      :joins => 'LEFT JOIN developers_projects ON developers.id = developers_projects.developer_id',
J
Jon Leighton 已提交
741
      :where => 'project_id=1'
742
    ).to_a
743
    assert_equal 3, developers_on_project_one.length
744 745 746
    developer_names = developers_on_project_one.map { |d| d.name }
    assert developer_names.include?('David')
    assert developer_names.include?('Jamis')
747
  end
748

749
  def test_joins_dont_clobber_id
750
    first = Firm.all.merge!(
751
      :joins => 'INNER JOIN companies clients ON clients.firm_id = companies.id',
J
Jon Leighton 已提交
752 753
      :where => 'companies.id = 1'
    ).first
754 755 756
    assert_equal 1, first.id
  end

757
  def test_joins_with_string_array
758
    person_with_reader_and_post = Post.all.merge!(
759 760 761 762 763 764 765 766
      :joins => [
        "INNER JOIN categorizations ON categorizations.post_id = posts.id",
        "INNER JOIN categories ON categories.id = categorizations.category_id AND categories.type = 'SpecialCategory'"
      ]
    )
    assert_equal 1, person_with_reader_and_post.size
  end

767 768
  def test_find_by_id_with_conditions_with_or
    assert_nothing_raised do
J
Jon Leighton 已提交
769
      Post.where("posts.id <= 3 OR posts.#{QUOTED_TYPE} = 'Post'").find([1,2,3])
770 771
    end
  end
772

773 774
  # http://dev.rubyonrails.org/ticket/6778
  def test_find_ignores_previously_inserted_record
A
Aaron Patterson 已提交
775
    Post.create!(:title => 'test', :body => 'it out')
J
Jon Leighton 已提交
776
    assert_equal [], Post.where(id: nil)
777 778
  end

779 780 781 782 783
  def test_find_by_empty_ids
    assert_equal [], Post.find([])
  end

  def test_find_by_empty_in_condition
784
    assert_equal [], Post.where('id in (?)', [])
785 786 787
  end

  def test_find_by_records
788 789 790
    p1, p2 = Post.all.merge!(:limit => 2, :order => 'id asc').to_a
    assert_equal [p1, p2], Post.all.merge!(:where => ['id in (?)', [p1, p2]], :order => 'id asc')
    assert_equal [p1, p2], Post.all.merge!(:where => ['id in (?)', [p1, p2.id]], :order => 'id asc')
791 792
  end

793 794 795 796 797 798 799 800 801
  def test_select_value
    assert_equal "37signals", Company.connection.select_value("SELECT name FROM companies WHERE id = 1")
    assert_nil Company.connection.select_value("SELECT name FROM companies WHERE id = -1")
    # make sure we didn't break count...
    assert_equal 0, Company.count_by_sql("SELECT COUNT(*) FROM companies WHERE name = 'Halliburton'")
    assert_equal 1, Company.count_by_sql("SELECT COUNT(*) FROM companies WHERE name = '37signals'")
  end

  def test_select_values
802 803
    assert_equal ["1","2","3","4","5","6","7","8","9", "10"], Company.connection.select_values("SELECT id FROM companies ORDER BY id").map! { |i| i.to_s }
    assert_equal ["37signals","Summit","Microsoft", "Flamboyant Software", "Ex Nihilo", "RailsCore", "Leetsoft", "Jadedpixel", "Odegy", "Ex Nihilo Part Deux"], Company.connection.select_values("SELECT name FROM companies ORDER BY id")
804 805
  end

806 807
  def test_select_rows
    assert_equal(
808
      [["1", "1", nil, "37signals"],
809 810
       ["2", "1", "2", "Summit"],
       ["3", "1", "1", "Microsoft"]],
811
      Company.connection.select_rows("SELECT id, firm_id, client_of, name FROM companies WHERE id IN (1,2,3) ORDER BY id").map! {|i| i.map! {|j| j.to_s unless j.nil?}})
812
    assert_equal [["1", "37signals"], ["2", "Summit"], ["3", "Microsoft"]],
813
      Company.connection.select_rows("SELECT id, name FROM companies WHERE id IN (1,2,3) ORDER BY id").map! {|i| i.map! {|j| j.to_s unless j.nil?}}
814 815
  end

816
  def test_find_with_order_on_included_associations_with_construct_finder_sql_for_association_limiting_and_is_distinct
817
    assert_equal 2, Post.all.merge!(:includes => { :authors => :author_address }, :order => 'author_addresses.id DESC ', :limit => 2).to_a.size
818

819
    assert_equal 3, Post.all.merge!(:includes => { :author => :author_address, :authors => :author_address},
820
                              :order => 'author_addresses_authors.id DESC ', :limit => 3).to_a.size
821 822
  end

823
  def test_find_with_nil_inside_set_passed_for_one_attribute
824
    client_of = Company.all.merge!(
J
Jon Leighton 已提交
825
      :where => {
826 827 828 829 830
        :client_of => [2, 1, nil],
        :name => ['37signals', 'Summit', 'Microsoft'] },
      :order => 'client_of DESC'
    ).map { |x| x.client_of }

831 832
    assert client_of.include?(nil)
    assert_equal [2, 1].sort, client_of.compact.sort
833 834
  end

835 836 837 838 839 840 841 842 843
  def test_find_with_nil_inside_set_passed_for_attribute
    client_of = Company.all.merge!(
      :where => { :client_of => [nil] },
      :order => 'client_of DESC'
    ).map { |x| x.client_of }

    assert_equal [], client_of.compact
  end

844
  def test_with_limiting_with_custom_select
845
    posts = Post.references(:authors).merge(
J
Jon Leighton 已提交
846
      :includes => :author, :select => ' posts.*, authors.id as "author_id"',
J
Jon Leighton 已提交
847
      :limit => 3, :order => 'posts.id'
848
    ).to_a
849 850
    assert_equal 3, posts.size
    assert_equal [0, 1, 1], posts.map(&:author_id).sort
851
  end
852

853
  def test_find_one_message_with_custom_primary_key
854
    Toy.primary_key = :name
855 856 857 858 859
    begin
      Toy.find 'Hello World!'
    rescue ActiveRecord::RecordNotFound => e
      assert_equal 'Couldn\'t find Toy with name=Hello World!', e.message
    end
860 861
  ensure
    Toy.reset_primary_key
862 863
  end

864 865 866 867 868 869
  def test_find_without_primary_key
    assert_raises(ActiveRecord::UnknownPrimaryKey) do
      Matey.find(1)
    end
  end

870
  def test_finder_with_offset_string
871
    assert_nothing_raised(ActiveRecord::StatementInvalid) { Topic.all.merge!(:offset => "3").to_a }
872 873
  end

D
David Heinemeier Hansson 已提交
874 875 876 877 878 879 880 881
  protected
    def bind(statement, *vars)
      if vars.first.is_a?(Hash)
        ActiveRecord::Base.send(:replace_named_bind_variables, statement, vars.first)
      else
        ActiveRecord::Base.send(:replace_bind_variables, statement, vars)
      end
    end
882 883 884 885 886 887 888

    def with_env_tz(new_tz = 'US/Eastern')
      old_tz, ENV['TZ'] = ENV['TZ'], new_tz
      yield
    ensure
      old_tz ? ENV['TZ'] = old_tz : ENV.delete('TZ')
    end
D
David Heinemeier Hansson 已提交
889
end