request_forgery_protection_test.rb 9.5 KB
Newer Older
1
require 'abstract_unit'
M
Michael Koziarski 已提交
2
require 'digest/sha1'
3
require "active_support/log_subscriber/test_helper"
4

5 6 7 8 9
# common controller actions
module RequestForgeryProtectionActions
  def index
    render :inline => "<%= form_tag('/') {} %>"
  end
10

11 12 13
  def show_button
    render :inline => "<%= button_to('New', '/') {} %>"
  end
14

15 16 17 18 19 20 21 22
  def external_form
    render :inline => "<%= form_tag('http://farfar.away/form', :authenticity_token => 'external_token') {} %>"
  end

  def external_form_without_protection
    render :inline => "<%= form_tag('http://farfar.away/form', :authenticity_token => false) {} %>"
  end

23 24 25
  def unsafe
    render :text => 'pwn'
  end
26

J
Jeremy Kemper 已提交
27
  def meta
28
    render :inline => "<%= csrf_meta_tags %>"
J
Jeremy Kemper 已提交
29 30
  end

31
  def external_form_for
32
    render :inline => "<%= form_for(:some_resource, :authenticity_token => 'external_token') {} %>"
33 34 35
  end

  def form_for_without_protection
36
    render :inline => "<%= form_for(:some_resource, :authenticity_token => false ) {} %>"
37
  end
38 39 40 41 42

  def form_for_remote
    render :inline => "<%= form_for(:some_resource, :remote => true ) {} %>"
  end

43 44 45 46
  def form_for_remote_with_token
    render :inline => "<%= form_for(:some_resource, :remote => true, :authenticity_token => true ) {} %>"
  end

47 48 49 50 51 52 53 54
  def form_for_with_token
    render :inline => "<%= form_for(:some_resource, :authenticity_token => true ) {} %>"
  end

  def form_for_remote_with_external_token
    render :inline => "<%= form_for(:some_resource, :remote => true, :authenticity_token => 'external_token') {} %>"
  end

55
  def rescue_action(e) raise e end
56 57 58 59 60
end

# sample controllers
class RequestForgeryProtectionController < ActionController::Base
  include RequestForgeryProtectionActions
J
Jeremy Kemper 已提交
61
  protect_from_forgery :only => %w(index meta)
62 63
end

64
class RequestForgeryProtectionControllerUsingException < ActionController::Base
65 66 67 68 69 70 71 72 73
  include RequestForgeryProtectionActions
  protect_from_forgery :only => %w(index meta)

  def handle_unverified_request
    raise(ActionController::InvalidAuthenticityToken)
  end
end


74
class FreeCookieController < RequestForgeryProtectionController
75
  self.allow_forgery_protection = false
76

77 78 79
  def index
    render :inline => "<%= form_tag('/') {} %>"
  end
80

81 82 83 84 85
  def show_button
    render :inline => "<%= button_to('New', '/') {} %>"
  end
end

86 87 88 89 90 91
class CustomAuthenticityParamController < RequestForgeryProtectionController
  def form_authenticity_param
    'foobar'
  end
end

92
# common test methods
93
module RequestForgeryProtectionTests
94 95
  def setup
    @token      = "cf50faa3fe97702ca1ae"
96

97
    SecureRandom.stubs(:base64).returns(@token)
98
    ActionController::Base.request_forgery_protection_token = :custom_authenticity_token
E
Emilio Tagua 已提交
99 100
  end

101 102 103
  def teardown
    ActionController::Base.request_forgery_protection_token = nil
  end
104

105 106 107 108
  def test_should_render_form_with_token_tag
    assert_not_blocked do
      get :index
    end
109
    assert_select 'form>div>input[name=?][value=?]', 'custom_authenticity_token', @token
110 111
  end

E
Emilio Tagua 已提交
112
  def test_should_render_button_to_with_token_tag
113 114 115
    assert_not_blocked do
      get :show_button
    end
116
    assert_select 'form>div>input[name=?][value=?]', 'custom_authenticity_token', @token
E
Emilio Tagua 已提交
117 118
  end

119
  def test_should_render_form_without_token_tag_if_remote
120 121 122
    assert_not_blocked do
      get :form_for_remote
    end
123
    assert_no_match(/authenticity_token/, response.body)
124 125
  end

126 127
  def test_should_render_form_with_token_tag_if_remote_and_embedding_token_is_on
    original = ActionView::Helpers::FormTagHelper.embed_authenticity_token_in_remote_forms
128
    begin
129
      ActionView::Helpers::FormTagHelper.embed_authenticity_token_in_remote_forms = true
130 131 132
      assert_not_blocked do
        get :form_for_remote
      end
133
      assert_match(/authenticity_token/, response.body)
134
    ensure
135
      ActionView::Helpers::FormTagHelper.embed_authenticity_token_in_remote_forms = original
136 137 138
    end
  end

139 140 141 142
  def test_should_render_form_with_token_tag_if_remote_and_external_authenticity_token_requested_and_embedding_is_on
    original = ActionView::Helpers::FormTagHelper.embed_authenticity_token_in_remote_forms
    begin
      ActionView::Helpers::FormTagHelper.embed_authenticity_token_in_remote_forms = true
143
      assert_not_blocked do
144
        get :form_for_remote_with_external_token
145
      end
146
      assert_select 'form>div>input[name=?][value=?]', 'custom_authenticity_token', 'external_token'
147
    ensure
148
      ActionView::Helpers::FormTagHelper.embed_authenticity_token_in_remote_forms = original
149
    end
150 151
  end

152 153 154 155 156 157 158
  def test_should_render_form_with_token_tag_if_remote_and_authenticity_token_requested
    assert_not_blocked do
      get :form_for_remote_with_token
    end
    assert_select 'form>div>input[name=?][value=?]', 'custom_authenticity_token', @token
  end

159 160 161 162 163 164 165
  def test_should_render_form_with_token_tag_with_authenticity_token_requested
    assert_not_blocked do
      get :form_for_with_token
    end
    assert_select 'form>div>input[name=?][value=?]', 'custom_authenticity_token', @token
  end

E
Emilio Tagua 已提交
166
  def test_should_allow_get
167
    assert_not_blocked { get :index }
E
Emilio Tagua 已提交
168 169 170
  end

  def test_should_allow_post_without_token_on_unsafe_action
171
    assert_not_blocked { post :unsafe }
172 173
  end

174 175
  def test_should_not_allow_post_without_token
    assert_blocked { post :index }
176 177
  end

178 179
  def test_should_not_allow_post_without_token_irrespective_of_format
    assert_blocked { post :index, :format=>'xml' }
180 181
  end

182 183 184 185
  def test_should_not_allow_patch_without_token
    assert_blocked { patch :index }
  end

186 187
  def test_should_not_allow_put_without_token
    assert_blocked { put :index }
188
  end
189

190 191
  def test_should_not_allow_delete_without_token
    assert_blocked { delete :index }
192
  end
193

194 195
  def test_should_not_allow_xhr_post_without_token
    assert_blocked { xhr :post, :index }
196
  end
197

198
  def test_should_allow_post_with_token
199
    assert_not_blocked { post :index, :custom_authenticity_token => @token }
200
  end
201

202 203 204 205
  def test_should_allow_patch_with_token
    assert_not_blocked { patch :index, :custom_authenticity_token => @token }
  end

206
  def test_should_allow_put_with_token
207
    assert_not_blocked { put :index, :custom_authenticity_token => @token }
208
  end
209

210
  def test_should_allow_delete_with_token
211
    assert_not_blocked { delete :index, :custom_authenticity_token => @token }
212
  end
213

214 215 216
  def test_should_allow_post_with_token_in_header
    @request.env['HTTP_X_CSRF_TOKEN'] = @token
    assert_not_blocked { post :index }
217
  end
218

219 220 221
  def test_should_allow_delete_with_token_in_header
    @request.env['HTTP_X_CSRF_TOKEN'] = @token
    assert_not_blocked { delete :index }
222
  end
223

224 225 226 227 228
  def test_should_allow_patch_with_token_in_header
    @request.env['HTTP_X_CSRF_TOKEN'] = @token
    assert_not_blocked { patch :index }
  end

229 230 231
  def test_should_allow_put_with_token_in_header
    @request.env['HTTP_X_CSRF_TOKEN'] = @token
    assert_not_blocked { put :index }
232
  end
233

234 235 236 237 238 239 240 241 242 243
  def test_should_warn_on_missing_csrf_token
    old_logger = ActionController::Base.logger
    logger = ActiveSupport::LogSubscriber::TestHelper::MockLogger.new
    ActionController::Base.logger = logger

    begin
      assert_blocked { post :index }

      assert_equal 1, logger.logged(:warn).size
      assert_match(/CSRF token authenticity/, logger.logged(:warn).last)
M
Mike Dillon 已提交
244
    ensure
245 246 247 248
      ActionController::Base.logger = old_logger
    end
  end

249 250 251 252
  def assert_blocked
    session[:something_like_user_id] = 1
    yield
    assert_nil session[:something_like_user_id], "session values are still present"
253 254
    assert_response :success
  end
255

256 257
  def assert_not_blocked
    assert_nothing_raised { yield }
258 259 260 261
    assert_response :success
  end
end

262
# OK let's get our test on
263

264
class RequestForgeryProtectionControllerTest < ActionController::TestCase
265
  include RequestForgeryProtectionTests
J
Jeremy Kemper 已提交
266

267 268 269 270 271 272 273 274
  setup do
    ActionController::Base.request_forgery_protection_token = :custom_authenticity_token
  end

  teardown do
    ActionController::Base.request_forgery_protection_token = nil
  end

275
  test 'should emit a csrf-param meta tag and a csrf-token meta tag' do
276
    SecureRandom.stubs(:base64).returns(@token + '<=?')
J
Jeremy Kemper 已提交
277
    get :meta
278
    assert_select 'meta[name=?][content=?]', 'csrf-param', 'custom_authenticity_token'
279
    assert_select 'meta[name=?][content=?]', 'csrf-token', 'cf50faa3fe97702ca1ae&lt;=?'
J
Jeremy Kemper 已提交
280
  end
281 282
end

283
class RequestForgeryProtectionControllerUsingExceptionTest < ActionController::TestCase
284 285 286 287 288 289 290 291
  include RequestForgeryProtectionTests
  def assert_blocked
    assert_raises(ActionController::InvalidAuthenticityToken) do
      yield
    end
  end
end

292
class FreeCookieControllerTest < ActionController::TestCase
293 294 295 296
  def setup
    @controller = FreeCookieController.new
    @request    = ActionController::TestRequest.new
    @response   = ActionController::TestResponse.new
J
Jeremy Kemper 已提交
297
    @token      = "cf50faa3fe97702ca1ae"
298

299
    SecureRandom.stubs(:base64).returns(@token)
300
  end
301

302 303 304 305
  def test_should_not_render_form_with_token_tag
    get :index
    assert_select 'form>div>input[name=?][value=?]', 'authenticity_token', @token, false
  end
306

307 308 309 310
  def test_should_not_render_button_to_with_token_tag
    get :show_button
    assert_select 'form>div>input[name=?][value=?]', 'authenticity_token', @token, false
  end
311

312
  def test_should_allow_all_methods_without_token
313
    [:post, :patch, :put, :delete].each do |method|
314 315 316
      assert_nothing_raised { send(method, :index)}
    end
  end
J
Jeremy Kemper 已提交
317 318 319

  test 'should not emit a csrf-token meta tag' do
    get :meta
320
    assert_blank @response.body
J
Jeremy Kemper 已提交
321
  end
322
end
323 324 325

class CustomAuthenticityParamControllerTest < ActionController::TestCase
  def setup
326 327 328 329 330
    ActionController::Base.request_forgery_protection_token = :custom_token_name
    super
  end

  def teardown
J
Jeremy Kemper 已提交
331
    ActionController::Base.request_forgery_protection_token = :authenticity_token
332
    super
333 334 335
  end

  def test_should_allow_custom_token
336
    post :index, :custom_token_name => 'foobar'
337 338 339
    assert_response :ok
  end
end