• R
    Correct tokio_util::block_on() and op_fetch_module_meta_data · 53b6356e
    Ryan Dahl 提交于
    op_fetch_module_meta_data is an op that is used by the TypeScript
    compiler. TypeScript requires this op to be sync. However the
    implementation of the op does things on the event loop (like fetching
    HTTP resources).
    
    In certain situations this can lead to deadlocks. The runtime's thread
    pool can be filled with ops waiting on the result of
    op_fetch_module_meta_data. The runtime has a maximum number of
    threads it can use (the number of logical CPUs on the system).
    
    This patch changes tokio_util::block_on to launch a new Tokio runtime
    for evaluating the future, thus bipassing the max-thread problem.
    
    This is only an issue in op_fetch_module_meta_data. Other synchronous
    ops are truly synchornous, not interacting with the event loop.  TODO
    comments are added to direct future development.
    53b6356e
tokio_util.rs 4.2 KB