1. 28 8月, 2019 2 次提交
  2. 14 8月, 2019 5 次提交
  3. 13 8月, 2019 2 次提交
    • A
      proc: next/step/stepout restarts thread from wrong instruction (#1657) · 3b0c8865
      Alessandro Arzilli 提交于
      proc.Next and proc.Step will call, after setting their temp
      breakpoints, curthread.SetCurrentBreakpoint. This is intended to find
      if one of the newly created breakpoints happens to be at the same
      instruction that curthread is stopped at.
      However SetCurrentBreakpoint is intended to be called after a Continue
      and StepInstruction operation so it will also detect if curthread is
      stopped one byte after a breakpoint.
      If the instruction immediately preceeding the current instruction of
      curthread happens to:
       1. have one of the newly created temp breakpoints
       2. be one byte long
      SetCurrentBreakpoint will believe that we just hit that breakpoint and
      therefore the instruction should be repeated, and thus rewind the PC of
      curthread by 1.
      
      We should distinguish between the two uses of SetCurrentBreakpoint and
      disable the check for "just hit" breakpoints when inappropriate.
      
      Fixes #1656
      3b0c8865
    • D
      ecc62a0f
  4. 12 8月, 2019 1 次提交
  5. 10 8月, 2019 8 次提交
  6. 02 8月, 2019 2 次提交
    • A
      cmd/dlv: actually disable C compiler optimizations when building (#1647) · c9c455cc
      Alessandro Arzilli 提交于
      * proc: fix stacktraces when a SIGSEGV happens during a cgo call
      
      When a SIGSEGV happens in a cgo call (for example as a result of
      dereferencing a NULL pointer) the stack layout will look like this:
      
      (system stack) runtime.fatalthrow
      (system stack) runtime.throw
      (system stack) runtime.sigpanic
      (system stack) offending C function
      ... other C functions...
      (system stack) runtime.asmcgocall
      (goroutine stack) call inside cgo
      
      The code in switchStack would switch directly from the
      runtime.fatalthrow frame to the first frame in the goroutine stack,
      hiding important information.
      
      Disable this switch for runtime.fatalthrow and reintroduce the check
      for runtime.mstart that existed before this version of the code was
      implemented in commit 7bec20.
      
      This problem was reported in comment:
      https://github.com/go-delve/delve/issues/935#issuecomment-512182533
      
      * cmd/dlv: actually disable C compiler optimizations when building
      c9c455cc
    • A
      Documentation,cmd/dlv: tidy up --help output (#1649) · 2bd1cd3f
      Alessandro Arzilli 提交于
      * scripts: use relative path in gen-cli-docs.go
      
      Makes gen-cli-docs.go work outside GOPATH.
      
      * Documentation,cmd/dlv: tidy up --help output
      
      The description of --log-dest, --log-output and --backend is very
      verbose and messes up the output of --help, move it to two "additional
      help" subcommands.
      2bd1cd3f
  7. 01 8月, 2019 2 次提交
  8. 30 7月, 2019 2 次提交
    • D
      *: Add .cirrus.yml for FreeBSD testing (#1639) · f4eaad69
      Derek Parker 提交于
      * *: Add .cirrus.yml for FreeBSD testing
      
      * *: run go mod tidy
      
      * service/test: prefer 127.0.0.1 over localhost
      
      * dwarf/line: fix TestDebugLinePrologueParser
      
      * vendor: rerun go mod vendor
      f4eaad69
    • J
      terminal/command: add support for next [count] (#1629) · 1a478cdb
      Jeremy Faller 提交于
      * terminal/command: add support for next [count]
      
      * disallow negative counts.
      
      * handle github comments, and regen docs.
      
      * Fix the fact that we don't print the file info in the last step of the next count.
      
      * Fix a typo, cleanup a few other observations.
      1a478cdb
  9. 28 7月, 2019 1 次提交
  10. 27 7月, 2019 2 次提交
    • A
    • A
      proc: ignore DW_TAG_inlined_subroutine entries without abstract origin (#1637) · b65882a5
      Alessandro Arzilli 提交于
      GCC produces DW_TAG_inlined_subroutine entries without a
      DW_AT_abstract_origin attribute.
      From the bug report:
      
       <1><1fe6c7c>: Abbrev Number: 41 (DW_TAG_subprogram)
          <1fe6c7d>   DW_AT_external    : 1
          <1fe6c7d>   DW_AT_name        : (indirect string, offset: 0x485814): MultiGetImpl
          (omissis)
       <2><1fe6c9e>: Abbrev Number: 65 (DW_TAG_inlined_subroutine)
          <1fe6c9f>   DW_AT_low_pc      : 0x311023a
          <1fe6ca7>   DW_AT_high_pc     : 0x5
          <1fe6caf>   DW_AT_call_file   : 10
          <1fe6cb0>   DW_AT_call_line   : 1690
       <2><1fe6cb2>: Abbrev Number: 20 (DW_TAG_inlined_subroutine)
          <1fe6cb3>   DW_AT_abstract_origin: <0x1ffb534>
          <1fe6cb7>   DW_AT_entry_pc    : 0x311023f
          <1fe6cbf>   DW_AT_ranges      : 0xe9bf20
          <1fe6cc3>   DW_AT_call_file   : 10
          <1fe6cc4>   DW_AT_call_line   : 1690
      
      Inlined subroutine at 1fe6c9e doesn't have abstract origin, a name or a
      declaration location. It's unclear whether this is in-standard and what
      it even means.
      
      Let's ignore it.
      
      Fixes #1636
      b65882a5
  11. 24 7月, 2019 2 次提交
    • A
      gdbserial: propagate signals to target while stepping (#1624) · dcc1030d
      Alessandro Arzilli 提交于
      Propagate signals when stepping because debugserver will report them,
      from the issue:
      
      2019-07-11T16:31:25+02:00 debug layer=gdbconn <- $z0,105525d,1#c9
      2019-07-11T16:31:25+02:00 debug layer=gdbconn -> $OK#00
      2019-07-11T16:31:25+02:00 debug layer=gdbconn <- $vCont;s:c41c3#50
      2019-07-11T16:31:25+02:00 debug layer=gdbconn -> $T1cthread:c41c3;threads:c41c3,c41d7,c41d8,c41d9,c41da;thread-pcs:105525d,7fffc464bf46,7fffc464bbf2,7fffc464bbf2,7fffc46...
      2019-07-11T16:31:25+02:00 debug layer=gdbconn <- $Z0,105525d,1#a9
      2019-07-11T16:31:25+02:00 debug layer=gdbconn -> $OK#00
      
      in this case we request a single step on thread c41c3 but debugserver
      reports instead a signal (in this case SIGWINCH).
      
      Fixes #1610
      dcc1030d
    • M
      pkg/config: add max-variable-recurse parameter (#1626) · 89d2167c
      Michail Safronov 提交于
      * add max-variable-recurse parameter
      89d2167c
  12. 20 7月, 2019 1 次提交
    • B
      cmd/dlv: add --continue to continue process on launch/attach (#1585) · cb658772
      Brian de Alwis 提交于
      * Add --continue to continue process on launch/attach
      
      * Add small test of --continue
      
      * regenerate usage docs
      
      * minor cleanup
      
      * Use similar approach to `trace` and connect and detach using a client instance
      
      * back out previous attempt
      
      * regen usage doc
      
      * fix up continue test
      
      * fix TestContinue to properly test --continue
      
      * back out unnecessary changes
      
      * update faq
      cb658772
  13. 18 7月, 2019 3 次提交
  14. 17 7月, 2019 2 次提交
  15. 13 7月, 2019 2 次提交
    • R
      *: FreeBSD initial support (#1480) · df65be43
      Robert Ayrapetyan 提交于
      * FreeBSD initial support
      
      * first code review fixes
      
      * regs slice upd
      
      * execPtraceFunc wrap
      
      * disabled concurrency tests
      fixed kill() issue
      
      * disabled concurrency tests
      fixed kill() issue
      
      * cleanup vendor related code
      
      * cleanup ptrace calls
      
      * vendoring latest changes
      
      * Revert "vendoring latest changes"
      
      This reverts commit 833cb87b
      
      * vendoring latest changes
      
      * requested changes
      df65be43
    • Q
      terminal: Add breakpoint autocompletion (#183) (#1612) · 114b76ae
      qingyunha 提交于
      114b76ae
  16. 09 7月, 2019 3 次提交