- 02 8月, 2017 2 次提交
-
-
由 aarzilli 提交于
The compiler a variable 'v' that escapes to the heap with a '&v' entry. Auto dereference those local variables. Fixe #871
-
由 Alessandro Arzilli 提交于
Can't get the trace directory from the server after we disconnect from it.
-
- 29 7月, 2017 1 次提交
-
-
由 Derek Parker 提交于
Instead of panicing for sending on a closed channel, detect that the process has exited and return a proper error message. This patch also cleans up some spots where the Pid is omitted from the error. Fixes #920
-
- 27 7月, 2017 12 次提交
-
-
由 Alessandro Arzilli 提交于
Mozilla RR will create a trace directory that can be reused with the replay verb, however if we delete the executable file the trace directory will become useless, so delete that too before exit. Users that wish to reuse a recording should build the executable themselves and then use either dlv exec or rr record to do the recording.
-
由 Alessandro Arzilli 提交于
If the user tries to list the contents of a function pointer but forgets the '*' operator the location lookup will fail and result in a unhelpful "location not found" error. Instead if the location lookup fails we should try interpreting the locspec as if it was preceded by '*'.
-
由 Alex Brainman 提交于
* proc/native: make sure debugged executable can be deleted on windows Delve opens debugged executable to read binary info it contains, but it never closes the file. Windows will not let you delete file that is opened. So close Process.bi in Process.postExit, and actually call Process.postExit from windows Process.Kill. Also Windows sends some debugging events (EXIT_PROCESS_DEBUG_EVENT event in particular) after Delve calls TerminateProcess. The events need to be consumed by debugger before debugged process will be released by Windows. So call Process.waitForDebugEvent after TerminateProcess in Process.Kill. Fixes #398 * cmd/dlv: make TestIssue398 pass on darwin * cmd/dlv: add comment for TestIssue398 * proc/native: wait for debuggee to exit before returning from windows Process.Kill * proc/native: close process handle before returning from windows killProcess * proc/native: remove not used Process.Process
-
由 aarzilli 提交于
Updates #893
-
由 aarzilli 提交于
-
由 aarzilli 提交于
When stepping through runtime sometimes the current goroutine will change. It is impossible to handle this in Next, Step and StepOut but StepInstruction can reset the current goroutine correctly.
-
由 aarzilli 提交于
When the process exits during we used to return an error, but after commit 8bbcc89711f4263e7bb2b6d9c00fa96d0294e56f we move the error into state.Err. Revert this behavior change.
-
由 aarzilli 提交于
Updates #893
-
由 aarzilli 提交于
proc.Process.StepInstruction should work even if there is no goroutine selected.
-
由 aarzilli 提交于
If one of the expressions that are automatically evaluated when a breakpoint is hit can't be evaluated breakpoint information collection should continue and the error should be returned for that specific expression instead of the whole command.
-
由 aarzilli 提交于
Next will add internal breakpoints with nil condition if it can't find the current goroutine (possibly because there isn't a current goroutine because the runtime hasn't been initialized yet). onNextGoroutine should skip breakpoints with nil condition, otherwise we'll end up with an internal debugger error trying to walk a nil expression. Updates #893
-
由 aarzilli 提交于
When there's a error reading the stack trace the call stack itself could be corrupted and we should return the partial stacktrace that we have. Fixes #868
-
- 21 7月, 2017 3 次提交
-
-
由 Alessandro Arzilli 提交于
Updates #794
-
由 Hyang-Ah Hana Kim 提交于
When location spec is given and the base can be interpreted either in source file name or function name, NomalLocationSpec searches both the source file list and the function symbol list, and selects matching candidates. Previously, all the matching candidates were added to one single list regardless whether the candidate was from the source file list or not. Then, later, Find tries to guess whether the candiate was a function or a file based on a heuristic, i.e, whether the candidate is an absolute file path. The heuristic is fragile - since there is no guarantee that the included source file name is an absolute path. Instead, this CL preserves where the candidate was found; file list or function symbol list. Then, use that info to determine whether the candidate is a source file name or not.
-
由 Alessandro Arzilli 提交于
-
- 19 7月, 2017 3 次提交
-
-
由 Florin Pățan 提交于
-
由 Sebastian Dahlgren 提交于
-
由 Alessandro Arzilli 提交于
Variable lookup is slow because it requires a full scan of debug_info to check for package variables, this doesn't matter much in interactive use but can slow down evaluation of breakpoint conditions significantly. Providing benchmark proof for this is hard since this effect doesn't show for small programs with small debug_info sections.
-
- 08 7月, 2017 2 次提交
-
-
由 Alessandro Arzilli 提交于
* proc: fix interaction of RequestManualStop and conditional breakpoints A conditional breakpoint that is hit but has the condition evaluate to false can block a RequestManualStop from working. If the conditional breakpoint is set on an instruction that is executed very frequently by multiple goroutines (or many conditional breakpoints are set) it could prevent all calls to RequestManualStop from working. This commit fixes the problem by changing proc.Continue to exit unconditionally after a RequestManualStop is called. * proc/gdbserial: fix ContinueOnce getting stuck on macOS Fixes #902
-
由 Alessandro Arzilli 提交于
Fixes #904
-
- 30 6月, 2017 3 次提交
-
-
由 Alessandro Arzilli 提交于
The concrete value of an interface is always stored as a pointer inside an interface variable. So far we have followed the memory layout and reported the type of the 'data' attribute of interfaces as a pointer, however this makes it impossible to distinguish interfaces with concrete value of type 'A' from interfaces of concrete value of type '*A'. With this changeset when we autodereference pointers when the concrete type of an interface is not a pointer.
-
由 Florin Pățan 提交于
* Fix various issues detected by megacheck I've ran honnef.co/go/tools/cmd/megacheck and fixed a few of the things that came up there. * Cleanup using Gogland
-
由 Alessandro Arzilli 提交于
Windows doesn't actually have ptrace. Fixes #778
-
- 27 6月, 2017 3 次提交
-
-
由 Alessandro Arzilli 提交于
-
由 Alex Brainman 提交于
-
由 Alessandro Arzilli 提交于
Fixes #885
-
- 22 6月, 2017 1 次提交
-
-
由 heschik 提交于
When a Go program is externally linked, the external linker is responsible for picking the TLS offset. It records its decision in the runtime.tlsg symbol. Read the offset from that rather than guessing -16. This implementation causes a regression: 1.4 and earlier will no longer work.
-
- 21 6月, 2017 2 次提交
-
-
由 Alessandro Arzilli 提交于
Other debuggers can be instructed to decorate the stacktrace with the value of SP. Our SP equivalent is the frame offset, since we can add it to the Stackframe structure without incurring into added costs we should, so that frontends can use it if they want.
-
由 Alessandro Arzilli 提交于
* cmd: include replay command in docs even if rr is not installed. * path/to/binary is the required argument Replaces #847
-
- 20 6月, 2017 1 次提交
-
-
由 Jacob Van Order 提交于
-
- 13 6月, 2017 6 次提交
-
-
由 aarzilli 提交于
A next/step/stepout command could hit a normal breakpoint, decorated with a list of variables to evaluate, if that happens the variable should be evaluated just as if the breakpoint was hit by a continue.
-
由 aarzilli 提交于
-
由 aarzilli 提交于
Implementing proc.Process.Running in a thread safe way is complicated and nothing actually uses it besides tests, so we are better off rewriting the tests without Running and removing it. In particular: * The call to d.target.Running() in service/debugger/debugger.go (Restart) can never return true because that line executes while holding processMutex and all continue operations are also executed while holding processMutex. * The call to dbp.Running() pkg/proc/native/proc.go (Detach) can never return true, because it's only called from debugger.(*Debugger).detach() which is also always called while holding processMutex. Since some tests are hard to write correctly without Process.Running a simpler interface, Process.NotifyResumed, is introduced. Fixes #830
-
由 aarzilli 提交于
RequestManualStop will run concurrently with trapWait, since one writes dbp.halt and the other reads it dbp.halt should be protected by a mutex. Updates #830
-
由 Florin Pățan 提交于
See https://youtrack.jetbrains.com/issue/GO-3931#comment=27-2224179 for more details
-
由 Alessandro Arzilli 提交于
-
- 06 6月, 2017 1 次提交
-
-
由 custa 提交于
-