1. 20 11月, 2018 1 次提交
    • S
      proc/proc: Extend GoroutinesInfo to allow specifying a range · 11accd4d
      Sergio Lopez 提交于
      Instead of unconditionally returning all present goroutines,
      GoroutinesInfo now allows specifying a range (start and count). In
      addition to the array of goroutines and the error, it now also returns
      the next goroutine to be processed, to be used as 'start' argument on
      the next call, or 0 if all present goroutines have already been
      processed.
      
      This way clients can avoid eating large amounts of RAM while debugging
      core dumps and processes with a exceptionally high amount of goroutines.
      
      Fixes #1403
      11accd4d
  2. 10 11月, 2018 1 次提交
    • A
      proc: Improve performance of loadMap on very large sparse maps · 89c8da65
      aarzilli 提交于
      Users can create sparse maps in two ways, either by:
      a) adding lots of entries to a map and then deleting most of them, or
      b) using the make(mapType, N) expression with a very large N
      
      When this happens reading the resulting map will be very slow
      because loadMap needs to scan many buckets for each entry it finds.
      
      Technically this is not a bug, the user just created a map that's
      very sparse and therefore very slow to read. However it's very
      annoying to have the debugger hang for several seconds when trying
      to read the local variables just because one of them (which you
      might not even be interested into) happens to be a very sparse map.
      
      There is an easy mitigation to this problem: not reading any
      additional buckets once we know that we have already read all
      entries of the map, or as many entries as we need to fulfill the
      MaxArrayValues parameter.
      
      Unfortunately this is mostly useless, a VLSM (Very Large Sparse Map)
      with a single entry will still be slow to access, because the single
      entry in the map could easily end up in the last bucket.
      
      The obvious solution to this problem is to set a limit to the
      number of buckets we read when loading a map. However there is no
      good way to set this limit.
      If we hardcode it there will be no way to print maps that are beyond
      whatever limit we pick.
      We could let users (or clients) specify it but the meaning of such
      knob would be arcane and they would have no way of picking a good
      value (because there is no objectively good value for it).
      
      The solution used in this commit is to set an arbirtray limit on
      the number of buckets we read but only when loadMap is invoked
      through API calls ListLocalVars and ListFunctionArgs. In this way
      `ListLocalVars` and `ListFunctionArgs` (which are often invoked
      automatically by GUI clients) remain fast even in presence of a
      VLSM, but the contents of the VLSM can still be inspected using
      `EvalVariable`.
      89c8da65
  3. 09 11月, 2018 1 次提交
  4. 07 11月, 2018 1 次提交
    • A
      tests: rename _fixtures/vendor to _fixtures/internal · 73d636f7
      aarzilli 提交于
      Some tests used a fake vendor directory placed inside _fixtures to
      import some support packages.
      In go.mod mode vendor directory are only supported on the root of the
      project, which breaks some of our tests.
      Since vendor directories outside the root of the project are so rare
      anyway it's possible that a future version of go will stop supporting
      it even in GOPATH mode.
      Also it was weird and unnecessary in the first place anyawy.
      73d636f7
  5. 20 10月, 2018 1 次提交
    • D
      *: Show return values on CLI trace · 3129aa73
      Derek Parker 提交于
      This patch allows the `trace` CLI subcommand to display return values of
      a function. Additionally, it will also display information on where the
      function exited, which could also be helpful in determining the path
      taken during function execution.
      
      Fixes #388
      3129aa73
  6. 16 10月, 2018 3 次提交
  7. 12 10月, 2018 1 次提交
    • A
      proc: support position independent executables (PIE) · 74c98bc9
      aarzilli 提交于
      Support for position independent executables (PIE) on the native linux
      backend, the gdbserver backend on linux and the core backend.
      Also implemented in the windows native backend, but it can't be tested
      because go doesn't support PIE on windows yet.
      74c98bc9
  8. 09 10月, 2018 2 次提交
  9. 03 10月, 2018 1 次提交
    • A
      proc/native,Makefile: allow compiling on macOS without native backend · 910f90c3
      aarzilli 提交于
      On macOS 10.14 Apple changed the command line tools so that system
      headers now need to be manually installed.
      
      Instead of adding one extra install step to the install procedure add a
      build tag to allow compilation of delve without the native backend on
      macOS. By default (i.e. when using `go get`) this is how delve will be
      compiled on macOS, the make script is changed to enable compiling the
      native backend if the required dependencies have been installed.
      
      Insure that both configuration still build correctly on Travis CI and
      change the documentation to describe how to compile the native backend
      and that it isn't normally needed.
      
      Fixes #1359
      910f90c3
  10. 28 9月, 2018 1 次提交
  11. 26 9月, 2018 1 次提交
    • A
      proc: implement conversion of integers to string · 50419b61
      aarzilli 提交于
      Go allows converting a single integer value to string, resulting in a
      string containing a single unicode rune with the same code as the value
      of the integer.
      Allow the same conversion to happen.
      
      Fixes #1322
      50419b61
  12. 25 9月, 2018 1 次提交
  13. 20 9月, 2018 2 次提交
  14. 31 8月, 2018 1 次提交
    • A
      proc,service,terminal: information about stack trace truncation · ac74944d
      aarzilli 提交于
      Add a flag to Stackframe that indicates where the stack frame is the
      bottom-most frame of the stack. This allows clients to know whether the
      stack trace terminated normally or if it was truncated because the
      maximum depth was reached.
      Add a truncation message to the 'stack' command.
      ac74944d
  15. 30 8月, 2018 1 次提交
    • A
      proc: fix type of some struct global variables · 0461af83
      aarzilli 提交于
      Normally variables that have a named struct as a type will get a
      typedef entry as their type, sometimes however the Go linker will
      decide to use the DW_TAG_structure_type entry instead.
      
      For consistency always wrap a struct type into a typedef when we are
      creating a new variables (see comment in newVariable for exceptions).
      
      This fixes a bug where it would be impossible to call methods on a
      global variable.
      0461af83
  16. 21 8月, 2018 1 次提交
  17. 17 8月, 2018 3 次提交
  18. 16 8月, 2018 2 次提交
    • A
      proc: use (*Variable).setValue in fncall · 9335c540
      aarzilli 提交于
      9335c540
    • A
      proc: change (*Variable).setValue for use in CallFunction · 12a3f8bb
      aarzilli 提交于
      Changes (*Variable).setValue so that it can be used in CallFunction to
      set up the argument frame for the function call, adding the ability to:
      - nil nillable types
      - set strings to the empty string
      - copy from one structure to another (including strings and slices)
      - convert any interface type to interface{}
      - convert pointer shaped types (map, chan, pointers, and structs
        consisting of a single pointer field) to interface{}
      
      This covers all cases where an assignment statement can be evaluated
      without allocating memory or calling functions in the target process.
      12a3f8bb
  19. 25 7月, 2018 1 次提交
    • A
      proc,service,terminal: read defer list · 8f1fc63d
      aarzilli 提交于
      Adds -defer flag to the stack command that decorates the stack traces
      by associating each stack frame with its deferred calls.
      
      Reworks proc.next to use this feature instead of using proc.DeferPC,
      laying the groundwork to implement #1240.
      8f1fc63d
  20. 14 7月, 2018 1 次提交
  21. 11 7月, 2018 1 次提交
  22. 10 7月, 2018 1 次提交
  23. 03 7月, 2018 1 次提交
    • A
      *: Fix log level setting in logrus · c53c43d1
      aarzilli 提交于
      Setting the Level field of a logrus logger doesn't actually do anything
      since the Level field simply reports the log level of the last log
      message emitted on the logger.
      The right way to do that is to set logger.Logger.Level.
      Also cleans up newline characters from log messages emitted through
      logrus and fixes the direction of the arrows in the messages emitted by
      rpccommon, which was inconsistent with the arrows of gdbserial.
      c53c43d1
  24. 29 6月, 2018 1 次提交
  25. 27 6月, 2018 1 次提交
    • A
      proc,terminal,service: let headless instances run without connected clients · 9a216211
      aarzilli 提交于
      This pull request makes several changes to delve to allow headless
      instancess that are started with the --accept-multiclient flag to
      keep running even if there is no connected client. Specifically:
      
      1. Makes a headless instance started with --accept-multiclient quit
          after one of the clients sends a Detach request (previously they
          would never ever quit, which was a bug).
      2. Changes proc/gdbserial and proc/native so that they mark the
          Process as exited after they detach, even if they did not kill the
          process during detach. This prevents bugs such as #1231 where we
          attempt to manipulate a target process after we detached from it.
      3. On non --accept-multiclient instances do not kill the target
          process unless we started it or the client specifically requests
          it (previously if the client did not Detach before closing the
          connection we would kill the target process unconditionally)
      4. Add a -c option to the quit command that detaches from the
          headless server after restarting the target.
      5. Change terminal so that, when attached to --accept-multiclient,
          pressing ^C will prompt the user to either disconnect from the
          server or pause the target process. Also extend the exit prompt to
          ask if the user wants to keep the headless server running.
      
      Implements #245, #952, #1159, #1231
      9a216211
  26. 26 6月, 2018 1 次提交
    • A
      rpccommon: restore API port message · 818ed0b2
      aarzilli 提交于
      This message is used by clients to determine the port that a headless
      instance is using, therefore the format can not change or move to a
      different file handle.
      
      Fixes #1245
      818ed0b2
  27. 22 6月, 2018 1 次提交
    • D
      *: Use structured logging · a208c897
      Derek Parker 提交于
      Implements structured logging via Logrus. This gives us a logger per
      boundry that we care about, allowing for easier parsing of logs if users
      have more than one log option enabled. Also, cleans up a lot of
      conditionals in the code by simply silencing the logger at creation as
      opposed to conditionally logging everywhere.
      a208c897
  28. 15 6月, 2018 2 次提交
    • A
      proc: allow "package/path".varname syntax · 2a2d1040
      aarzilli 提交于
      If the application being debugged imports two packages with the same
      name (but different paths) there was no way to disambiguate the two,
      since the character '/' can not appear inside a go identifier.
      
      By allowing users to use a string literal as the package name a package
      path can be specified.
      2a2d1040
    • A
      service,logflags: log all RPC messages · 454491ce
      aarzilli 提交于
      We occasionally receive bug reports from users of VSCode-go and GoLand.
      GoLand has its own way of capturing the packet exchange between itself
      and delve but VSCode-go (supposedly) doesn't.
      So far this hasn't been a problem since all bug reports were obvious
      bugs on the plugin or easy to reproduce without VSCode-go, but it might
      be helpful in the future to have a way to log the packet exchange
      between dlv and a frontend.
      
      This commit adds a --log-output option to enable logging of all rpc
      messages and changes service/rpccommon accordingly.
      454491ce
  29. 12 6月, 2018 1 次提交
    • A
      proc,service: display return values when stepping out of a function · 60c58acb
      aarzilli 提交于
      Displays the return values of the current function when we step out of
      it after executing a step, next or stepout command.
      
      Implementation of this feature is tricky: when the function has
      returned the return variables are not in scope anymore. Implementing
      this feature requires evaluating variables that are out of scope, using
      a stack frame that doesn't exist anymore.
      
      We can't calculate the address of these variables when the
      next/step/stepout command is initiated either, because between that
      point and the time where the stepout breakpoint is actually hit the
      goroutine stack could grow and be moved to a different memory address.
      60c58acb
  30. 19 5月, 2018 1 次提交
    • A
      proc/native,proc/gdbserial: let target access terminal · cc86bde5
      aarzilli 提交于
      Change the linux verison of proc/native and proc/gdbserial (with
      debugserver) so that they let the target process use the terminal when
      delve is launched in headless mode.
      
      Windows already worked, proc/gdbserial (with rr) already worked.
      I couldn't find a way to make proc/gdbserial (with lldb-server) work.
      
      No tests are added because I can't think of a way to test for
      foregroundness of a process.
      
      Fixes #65
      cc86bde5
  31. 24 4月, 2018 2 次提交
    • A
      proc: Flag shadowed arguments as shadowed · 7fd47749
      aarzilli 提交于
      Fixes #951
      7fd47749
    • A
      proc: cache entire frame in FrameToScope instead of variablesByTag · 21be5946
      aarzilli 提交于
      Caching the frame in variablesByTag is problematic:
      
      1. accounting for variables that are (partially) stored in registers is
      complicated (see issue #1106)
      2. for some types (strings, interfaces...) simply creating the Variable
      object reads memory, which therefore happens before we can do any
      caching.
      
      Instead cache the entire frame when the EvalScope object is created.
      The cached range is between the SP value of the current frame and the
      CFA of the preceeding frame, if available, or the CFA of the current
      frame otherwise.
      
      Fixes #1106
      21be5946