• A
    proc/*: remove Process.Running · 16d8bd64
    aarzilli 提交于
    Implementing proc.Process.Running in a thread safe way is complicated
    and nothing actually uses it besides tests, so we are better off
    rewriting the tests without Running and removing it.
    
    In particular:
    
    * The call to d.target.Running() in service/debugger/debugger.go
      (Restart) can never return true because that line executes while
      holding processMutex and all continue operations are also executed
      while holding processMutex.
    * The call to dbp.Running() pkg/proc/native/proc.go (Detach) can never
      return true, because it's only called from
      debugger.(*Debugger).detach() which is also always called while
      holding processMutex.
    
    Since some tests are hard to write correctly without Process.Running a
    simpler interface, Process.NotifyResumed, is introduced.
    
    Fixes #830
    16d8bd64
proc_test.go 85.5 KB