- 19 6月, 2015 23 次提交
-
-
由 Hixie 提交于
Also, fix the last warning which I conveniently (yet accidentally) left in to test this. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1190223002.
-
由 Hixie 提交于
This also introduces a new set_build_dir command to shelldb so you can set the build directory without starting sky. R=abarth@chromium.org, abarth, eseidel Review URL: https://codereview.chromium.org/1193733004.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1183143012.
-
由 Hixie 提交于
Ok, not really zero. Actually 72 if you include warnings from non-sky packages and if you include bogus warnings that can be filtered out. If you pipe the analyzer's output through the following perl script, though, you get zero warnings on the stock app with this patch: while (defined($_ = <STDIN>)) { s|out/android_Debug/gen/dart-pkg/sky/|sky/sdk/|gos; next if m|/dart-pkg/|os; # other packages next if m|^\[warning] Missing concrete implementation of 'RenderObject.toString'|os; # https://github.com/dart-lang/sdk/issues/23606 print; } R=abarth@chromium.org Review URL: https://codereview.chromium.org/1182323009.
-
由 Collin Jackson 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1189113004.
-
由 Collin Jackson 提交于
Currently you lose your scroll and drawer state when coming back from the settings pane. I think we should solve this by having the Navigator maintain a Stack and keeping the StockHome alive underneath it. But this is good enough for a first iteration. R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1191153002.
-
由 Viktor Lidholt 提交于
Enabling/disabling of handling multiple pointers Adds basic touch handling R=abarth@chromium.org Review URL: https://codereview.chromium.org/1179413009.
-
由 Hans Muller 提交于
tree of InlineStyle and InlineText elements. StyledText builds an Inline that renders the tree. For example this StyledText object: new StyledText(["FOO", [boldLargerStyle, [greenStyle "BAR"], "BAZ"] BORF]); Renders the same way the following HTML would, assuming that TextStyles boldLargerStyle and greenStyle were defined. <style> div { display: inline; } </style> <p> <div> FOO <div style="font-weight:bold; font-size:larger"> <div style="color:green"> BAR </div> BAZ </div> BORF </div> </p> R=abarth@chromium.org Review URL: https://codereview.chromium.org/1194693002.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1192183002.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1185343006.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1177223007.
-
由 Hixie 提交于
This is a short-term fix, the long term fix (see issue 254) involves moving some of these to dart:sky. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1191013004.
-
由 Hixie 提交于
Flesh out a README.md file for the SDK. Make the stocks app test wait for the app to be mounted, to catch some more errors, like typos in the mount callback. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1182053012.
-
由 Adam Barth 提交于
Fixes #165. R=jackson@google.com, jackson@chromium.org Review URL: https://codereview.chromium.org/1196463002.
-
由 Adam Barth 提交于
Fixes #167 R=ianh@google.com Review URL: https://codereview.chromium.org/1193713002.
-
由 Matt Perry 提交于
I use it a lot to test and demo the painting API. R=ianh@google.com Review URL: https://codereview.chromium.org/1188823008.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1186813009.
-
由 Matt Perry 提交于
Add a test for RenderDecoratedBox sets up the Paint object correctly. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1185423003.
-
由 John McCutchan 提交于
BUG= R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/1187313002.
-
由 Ian Fischer 提交于
R=ianh@google.com, abarth@chromium.org Review URL: https://codereview.chromium.org/1182993003.
-
由 Adam Barth 提交于
We now ensure the color is <= 0xFFFFFFFF. Fixes #245 R=ianh@google.com Review URL: https://codereview.chromium.org/1179413008.
-
由 Adam Barth 提交于
I broke this when I merged my AppContainer patch with Collin's back button patch. This change restores the functionality I broke. TBR=jackson@chromium.org Review URL: https://codereview.chromium.org/1182463007.
-
由 Adam Barth 提交于
We can't have two copies of |embedder.dart| or |shell.dart| because they take ownership of some underlying Mojo handles. Instead of duplicating the code, this CL makes the old locations just export all the symbols from the new location. I've also done the same with fetch.dart to avoid code duplication. Finally, I've removed image_cache.dart in the old location because the only clients already live in the new world and ought to use the new location. TBR=ianh@google.com Review URL: https://codereview.chromium.org/1179923004.
-
- 18 6月, 2015 17 次提交
-
-
由 Adam Barth 提交于
Fix syntax errors and add more |const|.
-
由 Adam Barth 提交于
Add the new runApp function.
-
由 Adam Barth 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1185933003.
-
由 Hixie 提交于
Some files are moved by this: Copy framework/node.dart into types/ - preparing for framework/'s decomissioning. Move app/scheduler.dart into sky/scheduler.dart - "app" doesn't really make sense. As part of the SkyBinding cleanup, I made the hit-testing less RenderBox-specific, by having the HitTestEntry.target member be a HitTestTarget, which is an interface with the handleEvent() function, which is then implemented by RenderBox. In theory, someone could now extend hit testing from the RenderBox world into their own tree of nodes, and take part in all the same dispatch logic automatically. This involved moving all the hit testing type definitions into a new sky/hittest.dart file. Renamed SkyBinding._app to SkyBinding._instance for clarity. Moved code around in SkyBinding so that related things are together. Made WidgetSkyBinding use the existing SkyBinding.instance singleton logic rather than having its own copy. I also added some stub README.md files that describe dependencies. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1187393002.
-
由 Carlos Pizano 提交于
So we can tell l-click from r-click. BUG=none R=abarth@chromium.org Review URL: https://codereview.chromium.org/1192023002.
-
由 Hixie 提交于
Summary: framework/animation/* -> animation/* framework/debug/utils.dart -> debug/utils.dart framework/shell.dart -> mojo/shell.dart framework/embedder.dart -> mojo/embedder.dart framework/net/* -> mojo/net/* This should have no code changes except fixing and reordering imports. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1189943004.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1191793004.
-
由 Hixie 提交于
Introduce a LeafRenderObjectWrapper abstract class so that RenderObjectWrappers that are leaves don't have to all redundantly assert that they're not misused. Also, make images use their URL as their src. Other misc code cleanup. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1191443009.
-
由 Hixie 提交于
Move app/view.dart to rendering/sky_binding.dart since it's part of the RenderObject API, really (it knows about RenderView intimately). The tests pass. I didn't check every last example. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1183913006.
-
由 Adam Barth 提交于
Also, trim the redundant |Mode| suffix from the TransferMode names. R=ianh@google.com Review URL: https://codereview.chromium.org/1188003006.
-
由 Adam Barth 提交于
Buttons and menu items use onPressed. Also, don't pass along the sky.Event because that's a lower-level concept. I've also reordered parameter lists to put the |child| argument last in a number of places. Also, fixed a bug where FloatingActionButton was missing syncFields. R=ianh@google.com Review URL: https://codereview.chromium.org/1188993003.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1187023005.
-
由 Hixie 提交于
Doesn't affect any APIs. TBR=abarth Review URL: https://codereview.chromium.org/1184823007.
-
由 Hans Muller 提交于
Defined constants for all 9 CSS font-weight values with conventional names from the "Common weight name mapping" section of https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight. The FontWeight enum now just enumerates the actual CSS weight values. I've moved the TextStyle class into its own file. R=ianh@google.com Review URL: https://codereview.chromium.org/1173323004.
-
由 Hixie 提交于
This also moves the test for stocks into a new tests/examples/ directory, where we can put tests that test the examples. TBR=abarth Review URL: https://codereview.chromium.org/1182223004.
-
由 Hixie 提交于
Turns out it's ok to not detach all the RenderObjects from the widget tree from each other, since they're not reused... but the WidgetToRenderBoxAdapter's renderBox _is_ reused, so we better detach that one. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1191053002.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1194473004.
-