- 01 7月, 2015 16 次提交
-
-
由 Adam Barth 提交于
Please use ".dart" files instead. R=ianh@google.com Review URL: https://codereview.chromium.org/1222483002.
-
由 Viktor Lidholt 提交于
BUG= R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1221893002.
-
由 Hixie 提交于
Note that this wildly breaks the vertical alignment of menu items, I'll fix that in a subsequent CL. (It wasn't really working before either, but looked ok by pure luck.) R=abarth@chromium.org Review URL: https://codereview.chromium.org/1215613005.
-
由 Adam Barth 提交于
These tests now run in the DOM-less world. R=ianh@google.com Review URL: https://codereview.chromium.org/1212163009.
-
由 Hans Muller 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1214413002.
-
由 Hans Muller 提交于
Demo all three varieties of TabLabels in 3 different TabNavigators. Use another TabNavigator to select among the three Card-encapsulated demos. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1217243005.
-
由 Hixie 提交于
Remove Material's opinion about background colours, since in fact the background colour varies dramatically with the kind of material involved. Also: - give users of Material who previously relied on Material's defaults opinions about background colours - reindent stock_row.dart - import colors as colors in example/widgets/styled_text.dart, rather than in global scope, for consistency with other files - import typography as typograpyh in example/widgets/tabs.dart, rather than in global scope, for consistency with other files - make flat_button actually be transparent by not painting a background, rather than painting 0x00000000. This is the what I actually originally set out to do here. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1217293003.
-
由 Adam Barth 提交于
These tests are for aspects of the Sky engine we plan to remove along with support for the old world. R=ianh@google.com Review URL: https://codereview.chromium.org/1215063003.
-
由 Adam Barth 提交于
TBR=ianh@google.com Review URL: https://codereview.chromium.org/1218903004.
-
由 Hixie 提交于
I ran this and fixed some of the warnings flagged: cd ~/dev/mojo/src/sky && find engine/core/painting sdk/example sdk/lib -type f -name '*.dart' | perl -nE 'chomp; local $/ = undef; open(FILE, $_); my $file = <FILE>; print $file; next if $file =~ /^part of/om; say "import \"$_\";"' > all.dart && shelldb analyze all.dart 2>&1 | grep -v 'sky/all.dart' Then I loaded the affected examples and fixed any bugs I found from running them. Major change to SDK: - Fix RenderPadding to get a valid size when it has no child (it was previously sizing itself too small by the padding amount). Minor changes, mostly to examples: - Fix the 'part of' lines in sky_shell_dart_controller_service_isolate to match the library name given in main.dart. - Remove unused imports in various places. - Fix example/game/lib/texture.dart to use the new Rect creation APIs. - Remove unused code in example/mine_digger/lib/main.dart. - Fix example/raw/hello_world.dart to use the new Size.center API. - Fix example/rendering/baseline.dart and example/rendering/justify_content.dart to have readable text. - Fix compile error in example/rendering/transform.dart. - Extend the debugDoesMeetConstraints() method to print useful information when it will be used to fire an assert. - Remove a warning about abstract methods on RenderView that would for some reason only sometimes get flagged by the analyzer. R=abarth@chromium.org, jackson@google.com Review URL: https://codereview.chromium.org/1215163003.
-
由 Adam Barth 提交于
Please use package:sky/widgets instead. R=ianh@google.com, eseidel@google.com Review URL: https://codereview.chromium.org/1221883002.
-
由 Adam Barth 提交于
One of the build bots is missing the yaml package. Reverting until we sort out how to fix that bot. TBR=jackson@google.com Review URL: https://codereview.chromium.org/1217863003.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1217573003.
-
由 Adam Barth 提交于
This CL teaches the build system how to create the stocks.skyx application bundle. This bundle contains the stocks snapshot as well as the material design assets needed by the stocks app to run offline. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1216273002.
-
由 Adam Barth 提交于
We need the material design icons at build time in order to build Sky application bundles that include the icons. Therefore, we need can't wait until runtime to download the icons. Also, rather than copying all the icons into each out directory, we just symlink to the copy in the source tree. R=eseidel@chromium.org, eseidel@google.com Review URL: https://codereview.chromium.org/1217283002.
-
由 Adam Barth 提交于
This script consumes a sky.yaml file and produces a bundle that contains the listed material design assets as well as the snapshot binary. This script isn't wired into the build system yet because we don't yet download the material design icons using DEPS. R=chinmaygarde@google.com, eseidel@google.com Review URL: https://codereview.chromium.org/1220893002.
-
- 30 6月, 2015 22 次提交
-
-
由 Viktor Lidholt 提交于
Adds color sequence class Refactors drawing of textures R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1216573009.
-
由 Collin Jackson 提交于
R=chinmaygarde@google.com, abarth Review URL: https://codereview.chromium.org/1209413006.
-
由 Ian Fischer 提交于
R=abarth@chromium.org, abarth@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1221583003.
-
由 Hans Muller 提交于
The Input component conforms a little more closely to the Material spec: http://www.google.com/design/spec/components/text-fields.html#text-fields-single-line-text-field Added a TextStyle attribute to EditableText and "themed" the text style for Input. Restored the blinking EditableText input cursor. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1216133002.
-
由 Hixie 提交于
R=abarth@chromium.org, jackson@google.com Review URL: https://codereview.chromium.org/1214113006.
-
由 Hixie 提交于
R=abarth@chromium.org, jackson@google.com Review URL: https://codereview.chromium.org/1217473007.
-
由 Adam Barth 提交于
When navigating from one app to another, we create a new Android window and destroy the old one. Previously, when we destroyed the old window after creating the new window, we would destroy the Ganesh context after making the GL context for the new window current, causing us to corrupt the GL state in the new window. After this CL, we call MakeCurrent before destroying the Ganesh context so that it interacts with the proper GL context. R=jackson@google.com Review URL: https://codereview.chromium.org/1214263002.
-
由 Collin Jackson 提交于
R=ianh@google.com, abarth, hixie Review URL: https://codereview.chromium.org/1217623002.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1217113002.
-
由 Hixie 提交于
Turn off the code that is forcing stocksapp to build 50 times a second, and change the code that tracks frame times to be a bit cleverer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1216973005.
-
由 Ian Fischer 提交于
R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1215023003.
-
由 Ian Fischer 提交于
Rename RenderCanvas to PaintingCanvas to avoid confusion with other classes that inherit from RenderObject. R=ianh@google.com, abarth@google.com Review URL: https://codereview.chromium.org/1217933002.
-
由 Adam Barth 提交于
We shouldn't try to drain a data pipe when we have an invalid handle. Instead, we should just call the callback with |null|, like we do for decoding failures. R=jackson@google.com, jackson@chromium.org Review URL: https://codereview.chromium.org/1213313002.
-
https://codereview.chromium.org/1216013003由 Hixie 提交于
Actually the tests broke in https://github.com/domokit/mojo/commit/136e0d4da5c8cfb802c7b77fb811a5b5d1293003 ...but I had reset the results because I had changed all the coordinates, and didn't realise some of the changes were bad. TBR=abarth Review URL: https://codereview.chromium.org/1212803003.
-
由 Hixie 提交于
Fix theme changing: turns out we were not reparenting stateful surviving nodes when their parents changed identity This also makes the optimistic/pessimistic mode switch change the active theme, because why not. While I was at it I also provided a debug boolean argument to runApp() to make it possible to profile more easily. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1215023002.
-
由 Ian Fischer 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1215893002.
-
由 Hixie 提交于
Turns out I had misimplemented Rect.center. While I was here, I also implemented Rect.width and Rect.height (to help avoid making that mistake again), and copied shortestSide from Side to Rect so that we can avoid having to allocate a Size to get the shortest side from a Rect. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1216013003.
-
由 Adam Barth 提交于
This CL makes it possible to run sky/tests/raw/bogus_import.dart in sky_shell on Linux. We'd eventually like to scale this up to running all the tests. R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1218633003.
-
由 Eric Seidel 提交于
TBR=abarth@chromium.org Review URL: https://codereview.chromium.org/1219683005.
-
由 Adam Barth 提交于
By profiling mine_digger in a continuous rebuild loop, we observe Widget#syncChild as being very hot. This CL optimizes this function by making sure to read each input value exactly once. Also, the hash operations for _mountedChanged were showing up on the profile, so this CL makes _mountedChanged into a List, which should work fine. Together, these changes reduce the amount of time we spend in Navtive code inside the VM from 29% to 20%. R=ianh@google.com Review URL: https://codereview.chromium.org/1217473004.
-
由 Hans Muller 提交于
A simple container for a TabBar. It is defined by a list of TabNavigatorViews, each of which is just a TabLabel and the tab's content. The content of each tab is represented by a function that produces a Widget called "content". I couldn't bring myself to call it buildTabContentCallback or something else more specific. R=abarth@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1212993003.
-
由 Hixie 提交于
This should be a perf win, but I haven't tested it. Also adds an operator overloading such that Offset + Size -> Rect. Also adds Rect.fromLTWH(). R=abarth@chromium.org Review URL: https://codereview.chromium.org/1209413004.
-
- 27 6月, 2015 2 次提交
-
-
由 Adam Barth 提交于
Instead of having a one-off //sky/apk/stocks, we now use the |sky_app| GN template to create Stocks.apk directly from //sky/sdk/example/stocks. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1211883004.
-
由 Adam Barth 提交于
This library is logically part of //sky/viewer and shouldn't clutter up the top-level //sky directory. TBR=eseidel@chromium.org Review URL: https://codereview.chromium.org/1213683004.
-