- 11 6月, 2015 31 次提交
-
-
由 Hixie 提交于
R=eseidel@chromium.org, eseidel Review URL: https://codereview.chromium.org/1180623003
-
由 Collin Jackson 提交于
R=abarth@chromium.org, ianh@google.com, abarth Review URL: https://codereview.chromium.org/1174203002
-
由 Hixie 提交于
This lays the groundwork for using fn widgets in static environments. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1178703002
-
由 Hixie 提交于
Dispatch events to fn nodes for each RenderObject that the event goes through, instead of starting at the innermost target and just propagating through our tree. This starts laying the groundwork for fn disconnected subtrees that are linked together into one RenderObject tree. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1181503002
-
由 Collin Jackson 提交于
R=abarth@chromium.org, hixie Review URL: https://codereview.chromium.org/1181523002
-
由 Adam Barth 提交于
These are now called Block, Stack, and Flex, respectively. Less verbose. R=jackson@google.com, ianh@google.com Review URL: https://codereview.chromium.org/1181533002.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1181453003
-
由 Adam Barth 提交于
R=ianh@google.com Review URL: https://codereview.chromium.org/1174153002.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174143002
-
由 Adam Barth 提交于
Previously it was propagating for a constant duration. R=ianh@google.com Review URL: https://codereview.chromium.org/1173173002.
-
由 Hixie 提交于
Turns out that reintroducing the field in each subclass is probably allocating more storage per node. So let's not do that. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1177483004
-
由 Adam Barth 提交于
Previously, they always started at the center of the RenderInkWell. Now we remember the local coordinates we computed during the hit test and provide that information when handling the event. R=ianh@google.com Review URL: https://codereview.chromium.org/1180553002.
-
由 Hixie 提交于
I'd do it now, but these files are still being used by fn.dart/stocks1, and it's not worth forking the whole animation directory just for this. TBR=abarth Review URL: https://codereview.chromium.org/1170033005
-
由 Eric Seidel 提交于
I'm starting to spec out a script to make these updates for me but for now I'm still doing these by hand. TBR=johnmccutchen@google.com Review URL: https://codereview.chromium.org/1170863007.
-
由 Hixie 提交于
In general, we are hugely inconsistent in what onFoo/onFoo() means. I'm cleaning out all the cases where onFoo() is a method. Also, this fixes EditableText, which got missed in the recent syncFields() pass. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1175753003
-
由 Eric Seidel 提交于
Fixes https://github.com/domokit/mojo/issues/212 R=abarth@chromium.org Review URL: https://codereview.chromium.org/1173153002.
-
由 Adam Barth 提交于
Previously, we would try to close some Dart persistent handles after destroying the isolate. Now we revoke the weak pointers these handles are using to refer to the isolate before trying to tear them down. Fixes https://github.com/domokit/mojo/issues/233 R=chinmaygarde@google.com, eseidel@chromium.org Review URL: https://codereview.chromium.org/1175053002.
-
由 Collin Jackson 提交于
R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1176053002
-
由 Hixie 提交于
TBR=jackson Review URL: https://codereview.chromium.org/1178523005
-
由 Adam Barth 提交于
We can use const [] instead and we'll be sure we don't mutate this constant. R=ianh@google.com Review URL: https://codereview.chromium.org/1178623002.
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1176763006
-
由 Eric Seidel 提交于
Our current static view_configuration design cannot work. https://github.com/domokit/mojo/issues/231 R=ianh@google.com Review URL: https://codereview.chromium.org/1169813009.
-
由 Eric Seidel 提交于
The app looks so much better with this on. R=jackson@google.com, abarth@chromium.org Review URL: https://codereview.chromium.org/1172413002.
-
由 Hans Muller 提交于
Tweaked the layout in Scaffold a little: the Scaffold accounts for the (Android) notification bar's height, instead of the ToolBar. I think it would be best if moving the app below the notification area were handled at a lower level. Doing it in Scaffold seemed OK for the moment, since one could put a ToolBar component anywhere in an app. Closes #208 R=ianh@google.com Review URL: https://codereview.chromium.org/1171173003.
-
由 Hixie 提交于
This also removes one bit of magic to make it more obvious what on is going on during a sync, which should hopefully help. Components have to decide if they support being stateful or not. If they do, then they must implement syncFields() and have mutable fields; if they don't, then they must have final fields. This isn't particularly enforced, though. This also renames _willSync() to _retainStatefulNodeIfPossible(), for clarity, and fixes some minor style issues and one typo that was breaking the drawer. R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174023003
-
由 skyostil 提交于
Remove the usage of base::MessageLoopProxy since it has been deprecated. BUG=465354 R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/1174063002. Patch from skyostil <skyostil@chromium.org>.
-
由 Collin Jackson 提交于
Renders interactive_flex and stocks demos fine. Could use more testing, so I'm going to work on that after I land this. R=abarth@chromium.org, abarth Review URL: https://codereview.chromium.org/1173493003
-
由 Matt Perry 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1175763002.
-
由 Adam Barth 提交于
Previously, the ink splashes would disappear immediately because the button highlight would change the structure of the component hierarchy and we weren't smart enough to retain the underlying RenderInkSplash. This CL is a point fix for that issue by avoiding changing the structure of the component hierarchy. A more complete fix would be to make Container smarter about how it syncs its subcomponents. R=eseidel@chromium.org, ianh@google.com Review URL: https://codereview.chromium.org/1168323003.
-
由 Viktor Lidholt 提交于
R=eseidel@chromium.org Review URL: https://codereview.chromium.org/1177563004.
-
由 Adam Barth 提交于
This CL replaces the (non-working) components2 InkWell with some code based on the ink_well example. There are at least two issues with the implementation: 1) The ink splash always starts at the center of the well because we don't have a facility for converting from global to local coordinates, which means we can't tell where the tap occurred in the local coordinates we need to use for painting. 2) When used inside a MenuItem, the in splash disappears shortly after starting, presumably because the button starts highlighting, which causes a component rebuild and somehow we lose the RenderInkWell instance. I plan to address these issues in subsequent CLs. R=ianh@google.com Review URL: https://codereview.chromium.org/1172033003.
-
- 10 6月, 2015 9 次提交
-
-
由 Eric Seidel 提交于
I also fixed image_cache to not even bother to call ImageDecoder in the 404 case, but I also fixed CanvasImageDecoder not to blow up if the buffer is empty and its not able to allocate an ImageDecoder. Closes https://github.com/domokit/mojo/issues/229 R=abarth@chromium.org, jackson@google.com Review URL: https://codereview.chromium.org/1170413002.
-
由 Ian Fischer 提交于
Update the native_viewport interface to allow specification of the surface configuration, currently only needed for and used by EGL on Android. This also fixes an issue where eglChooseConfig was only being called in InitializeOneOff, which is only called once per process. This CL makes choosing the config happen once per GLSurface instead, which will ultimately permit apps to create multiple native_viewports with different surface configurations on the same display. The eglDisplay object is still a global, though. R=abarth@chromium.org, viettrungluu@chromium.org, jamesr@chromium.org Review URL: https://codereview.chromium.org/1168993002.
-
由 Hans Muller 提交于
StockRows are now a relatively simple application of flex layout. The up/down arrows are now rendered within a circle, like the original version. The arrows are a little bigger, because. R=ianh@google.com Review URL: https://codereview.chromium.org/1165223005.
-
由 Hixie 提交于
I accidentally removed two lines of code in https://codereview.chromium.org/1172173002 when merging upsteam before landing. TBR=abarth Review URL: https://codereview.chromium.org/1171163005
-
由 Hixie 提交于
- constructors first - have either a blank line at the top and bottom of each class, or no blank line in either place (it's still inconsistent about which we should do) - hide clamp() R=abarth@chromium.org Review URL: https://codereview.chromium.org/1172173002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1171273002
-
由 Hixie 提交于
R=abarth@chromium.org Review URL: https://codereview.chromium.org/1174683005
-
由 Eric Seidel 提交于
This would occur when bringing SkyDemo to the front after having viewed a SkyView based demo and then paused the SkyActivity (by going to the Android Launcher, etc.) I also fixed deploy_domokit_site.py to ignore .gitignore files found in packages. We should actually probably ignore these when creating the packages in the first place, but this check seems valid regardless. The .gitignore for sky/lib/assets was causing the assets not to get pushed to the demo site. R=abarth@chromium.org, johnmccutchan@google.com Review URL: https://codereview.chromium.org/1163323007.
-
由 Hixie 提交于
TBR=abarth Review URL: https://codereview.chromium.org/1173783002
-