UI: Call setWindowFlags before setupUi

For some reason this has a noticeable performance improvement,
presumably because Qt is notifying all the child widgets?

UI/window-basic-about.cpp

@@ -11,10 +11,10 @@ using namespace json11;
 
 OBSAbout::OBSAbout(QWidget *parent) : QDialog(parent), ui(new Ui::OBSAbout)
 {
-	ui->setupUi(this);
-
 	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 
+	ui->setupUi(this);
+
 	QString bitness;
 	QString ver;
 

UI/window-basic-filters.cpp

@@ -54,6 +54,8 @@ OBSBasicFilters::OBSBasicFilters(QWidget *parent, OBSSource source_)
 {
 	main = reinterpret_cast<OBSBasic *>(parent);
 
+	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
+
 	ui->setupUi(this);
 	UpdateFilters();
 
@@ -64,7 +66,6 @@ OBSBasicFilters::OBSBasicFilters(QWidget *parent, OBSSource source_)
 
 	const char *name = obs_source_get_name(source);
 	setWindowTitle(QTStr("Basic.Filters.Title").arg(QT_UTF8(name)));
-	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 
 #ifndef QT_NO_SHORTCUT
 	ui->actionRemoveFilter->setShortcut(

UI/window-basic-interaction.cpp

@@ -44,6 +44,10 @@ OBSBasicInteraction::OBSBasicInteraction(QWidget *parent, OBSSource source_)
 	int cy = (int)config_get_int(App()->GlobalConfig(), "InteractionWindow",
 				     "cy");
 
+	Qt::WindowFlags flags = windowFlags();
+	Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
+	setWindowFlags(flags & (~helpFlag));
+
 	ui->setupUi(this);
 
 	ui->preview->setMouseTracking(true);
@@ -59,10 +63,6 @@ OBSBasicInteraction::OBSBasicInteraction(QWidget *parent, OBSSource source_)
 	const char *name = obs_source_get_name(source);
 	setWindowTitle(QTStr("Basic.InteractionWindow").arg(QT_UTF8(name)));
 
-	Qt::WindowFlags flags = windowFlags();
-	Qt::WindowFlags helpFlag = Qt::WindowContextHelpButtonHint;
-	setWindowFlags(flags & (~helpFlag));
-
 	auto addDrawCallback = [this]() {
 		obs_display_add_draw_callback(ui->preview->GetDisplay(),
 					      OBSBasicInteraction::DrawPreview,

UI/window-basic-settings.cpp

@@ -318,10 +318,10 @@ OBSBasicSettings::OBSBasicSettings(QWidget *parent)
 
 	EnableThreadedMessageBoxes(true);
 
-	ui->setupUi(this);
-
 	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 
+	ui->setupUi(this);
+
 	main->EnableOutputs(false);
 
 	PopulateAACBitrates({ui->simpleOutputABitrate, ui->advOutTrack1Bitrate,

UI/window-basic-transform.cpp

@@ -42,10 +42,10 @@ void OBSBasicTransform::HookWidget(QWidget *widget, const char *signal,
 OBSBasicTransform::OBSBasicTransform(OBSBasic *parent)
 	: QDialog(parent), ui(new Ui::OBSBasicTransform), main(parent)
 {
-	ui->setupUi(this);
-
 	setWindowFlags(windowFlags() & ~Qt::WindowContextHelpButtonHint);
 
+	ui->setupUi(this);
+
 	HookWidget(ui->positionX, DSCROLL_CHANGED, SLOT(OnControlChanged()));
 	HookWidget(ui->positionY, DSCROLL_CHANGED, SLOT(OnControlChanged()));
 	HookWidget(ui->rotation, DSCROLL_CHANGED, SLOT(OnControlChanged()));