style: lint shell scripts

frontend/scripts/build.sh

@@ -14,11 +14,11 @@ OUTPUT_PATH="$WORKING_PATH/$OUTPUT"
 npx lerna run build
 
 # generate output
-rm -rf $OUTPUT_PATH
-mkdir -p $OUTPUT_PATH
+rm -rf ${OUTPUT_PATH}
+mkdir -p ${OUTPUT_PATH}
 
 # package server files
-(cd $SERVER_DIR_PATH && tar zcf $OUTPUT_PATH/server.tar.gz .)
+(cd ${SERVER_DIR_PATH} && tar zcf ${OUTPUT_PATH}/server.tar.gz .)
 
 # package serverless files
-(cd $SERVERLESS_DIR_PATH && tar zcf $OUTPUT_PATH/serverless.tar.gz .)
+(cd ${SERVERLESS_DIR_PATH} && tar zcf ${OUTPUT_PATH}/serverless.tar.gz .)

scripts/build.sh

@@ -2,11 +2,10 @@
 set -e
 
 TOP_DIR=$(pwd)
-FRONTEND_DIR=$TOP_DIR/frontend
-BACKEND_DIR=$TOP_DIR/visualdl
-BUILD_DIR=$TOP_DIR/build
+FRONTEND_DIR=${TOP_DIR}/frontend
+BUILD_DIR=${TOP_DIR}/build
 
-mkdir -p $BUILD_DIR
+mkdir -p "$BUILD_DIR"
 
 build_frontend_fake() {
     mkdir -p "$BUILD_DIR/package/dist"
@@ -15,7 +14,7 @@ build_frontend_fake() {
 build_frontend_from_source() {
     build_frontend_fake
 
-    cd $FRONTEND_DIR
+    cd "$FRONTEND_DIR"
     ./scripts/install.sh
     ./scripts/build.sh
 
@@ -27,21 +26,25 @@ build_frontend() {
     local PACKAGE="@visualdl/serverless"
     local NAME=${PACKAGE#*@}
     local NAME=${NAME////-}
-    echo $NAME
+    echo ${NAME}
     local TAG="latest"
     local TARBALL="${PACKAGE}@${TAG}"
 
     # get version
-    local VERSION=`npm view ${TARBALL} dist-tags.${TAG}`
-    if [ "$?" -ne "0" ]; then
+    local VERSION
+    VERSION=$(npm view ${TARBALL} dist-tags.${TAG})
+    # shellcheck disable=SC2181
+    if [[ "$?" -ne "0" ]]; then
         echo "Cannot get version"
         exit 1
     fi
     local FILENAME="${NAME}-${VERSION}.tgz"
 
     # get sha1sum
-    local SHA1SUM=`npm view ${TARBALL} dist.shasum`
-    if [ "$?" -ne "0" ]; then
+    local SHA1SUM;
+    SHA1SUM=$(npm view ${TARBALL} dist.shasum)
+    # shellcheck disable=SC2181
+    if [[ "$?" -ne "0" ]]; then
         echo "Cannot get sha1sum"
         exit 1
     fi
@@ -50,28 +53,30 @@ build_frontend() {
 
     local DOWNLOAD="1"
     # cached file exists
-    if [ -f "$BUILD_DIR/$FILENAME" ]; then
+    if [[ -f "$BUILD_DIR/$FILENAME" ]]; then
         # check sha1sum
-        (cd $BUILD_DIR && sha1sum -c "${FILENAME}.sha1")
-        # check pass, use chached file
-        if [ "$?" -eq "0" ]; then
+        (cd "$BUILD_DIR" && sha1sum -c "${FILENAME}.sha1")
+        # check pass, use cached file
+        # shellcheck disable=SC2181
+        if [[ "$?" -eq "0" ]]; then
             echo "Using cached npm package file ${FILENAME}"
             DOWNLOAD="0"
         fi
     fi
 
-    if [ "$DOWNLOAD" -eq "1" ]; then
-        echo "Donwloading npm package, please wait..."
+    if [[ "$DOWNLOAD" -eq "1" ]]; then
+        echo "Downloading npm package, please wait..."
 
         # remove cache
         rm -f "$BUILD_DIR/${NAME}-*.tgz"
 
         # download file
-        FILENAME=`(cd $BUILD_DIR && npm pack ${TARBALL})`
+        FILENAME=$( (cd "$BUILD_DIR" && npm pack ${TARBALL}) )
 
         # check sha1sum of downloaded file
-        (cd $BUILD_DIR && sha1sum -c "${FILENAME}.sha1")
-        if [ "$?" -ne "0" ]; then
+        (cd "BUILD_DIR" && sha1sum -c "${FILENAME}.sha1")
+        # shellcheck disable=SC2181
+        if [[ "$?" -ne "0" ]]; then
             echo "Check sum failed, download may not finish correctly."
             exit 1
         else
@@ -84,25 +89,27 @@ build_frontend() {
 }
 
 clean_env() {
-    rm -rf $TOP_DIR/visualdl/server/dist
-    rm -rf $BUILD_DIR/bdist*
-    rm -rf $BUILD_DIR/lib*
-    rm -rf $BUILD_DIR/temp*
-    rm -rf $BUILD_DIR/scripts*
-    rm -rf $BUILD_DIR/package
+    rm -rf "$TOP_DIR/visualdl/server/dist"
+    rm -rf "$BUILD_DIR/bdist*"
+    rm -rf "$BUILD_DIR/lib*"
+    rm -rf "$BUILD_DIR/temp*"
+    rm -rf "$BUILD_DIR/scripts*"
+    rm -rf "$BUILD_DIR/package"
 }
 
 package() {
-    cp -rf $BUILD_DIR/package/dist $TOP_DIR/visualdl/server/
+    cp -rf "$BUILD_DIR/package/dist" "$TOP_DIR/visualdl/server/"
 }
 
 ARG=$1
-echo "ARG: " $ARG
+echo "ARG: ${ARG}"
 
 clean_env
 
-if [ "$ARG" = "travis-CI" ]; then
+if [[ "$ARG" = "travis-CI" ]]; then
     build_frontend_fake
+elif [[ "$ARG" = "from-source" ]]; then
+    build_frontend_from_source
 else
     build_frontend
 fi