Skip to content

S
Serving

PaddlePaddle / Serving
大约 2 年 前同步成功

通知 187
Star 833
Fork 253
S
Serving

fix paddle_rocksdb.h and pure virtual func call bug. !76

!76 已合并 由 saxon_zh@saxon_zh 创建

Created by: wangjiawei04

there are 2 bug to fix in this PR.

  1. Compiling order was messy, RocksKVDB was being compiled before 3rd party rocksdb was installed. I add one add_dependencies in kvdb/CMakeList.txt to restrict the compiling order.

  2. it occurs pure virtual function called in gtest. it has two reasons. first one is implicit close db. second one is update_delta_model is async process, it exits too early in the test. I add Close() function to fix first one. For the second one, I remove the update_delta_model test, since the design has been changed a lot since it was first written, it requires more time to adapt the API UpdateModel to current design. So it'd better remove this test, and change the implementation of Update Model in the following months.