Skip to content

  • 体验新版
    • 正在加载...
  • 登录
  • PaddlePaddle
  • Paddle
  • 合并请求
  • !450

P
Paddle
  • 项目概览

PaddlePaddle / Paddle
大约 2 年 前同步成功

通知 2325
Star 20933
Fork 5424
  • 代码
    • 文件
    • 提交
    • 分支
    • Tags
    • 贡献者
    • 分支图
    • Diff
  • Issue 1423
    • 列表
    • 看板
    • 标记
    • 里程碑
  • 合并请求 543
  • Wiki 0
    • Wiki
  • 分析
    • 仓库
    • DevOps
  • 项目成员
  • Pages
P
Paddle
  • 项目概览
    • 项目概览
    • 详情
    • 发布
  • 仓库
    • 仓库
    • 文件
    • 提交
    • 分支
    • 标签
    • 贡献者
    • 分支图
    • 比较
  • Issue 1,423
    • Issue 1,423
    • 列表
    • 看板
    • 标记
    • 里程碑
  • 合并请求 543
    • 合并请求 543
  • Pages
  • 分析
    • 分析
    • 仓库分析
    • DevOps
  • Wiki 0
    • Wiki
  • 成员
    • 成员
  • 收起侧边栏
  • 动态
  • 分支图
  • 创建新Issue
  • 提交
  • Issue看板

Feature/pre commit hooks scripts !450

  • Report abuse
!450 已合并 11月 13, 2016 由 saxon_zh@saxon_zh 创建
#<User:0x00007f0ef4b3ffb0>
  • 概览 7
  • 提交 3
  • 变更 37

Created by: reyoung

Use a python package pre-commit to manage git pre-commit hooks when developing Paddle.

Git pre-commit hook is set by each developer locally. It is hard to force all developer set same pre-commit hooks, but there are some basic things should be check before commit, such as python style, file should use \n as line end, etc.

This PR is added to solve this problem, by using a python package pre-commit. Each developer should do two things to enable this feature.

  • Install pre-commit package. pip install pre-commit
  • Enable pre-commit package to manage Paddle git pre-commit in local directory, by run pre-commit install in Paddle checkout directory.

Currently, some hooks are added, and all files are scan & fixed by this PR.

By the way, there is another thing I found about yapf, the python formatter used by Paddle. Different version of yapf could generate different result, with the same input python file. So, we must use the same yapf when developing Paddle. pre-commit also can help us to archive that.

pre-commit is used only by Paddle developer, we should add some other tools (or just use pre-commit package, I'm not sure) to complete the CI tests about these checks.

指派人
分配到
审核者
Request review from
0.9.0
里程碑
0.9.0 (Past due)
分配里程碑
工时统计
标识: paddlepaddle/Paddle!450
Source branch: github/fork/reyoung/feature/pre-commit-hooks-scripts
渝ICP备2023009037号

京公网安备11010502055752号

网络110报警服务 Powered by GitLab CE v13.7
开源知识
Git 入门 Pro Git 电子书 在线学 Git
Markdown 基础入门 IT 技术知识开源图谱
帮助
使用手册 反馈建议 博客
《GitCode 隐私声明》 《GitCode 服务条款》 关于GitCode
Powered by GitLab CE v13.7