Skip to content

  • 体验新版
    • 正在加载...
  • 登录
  • PaddlePaddle
  • Paddle
  • 合并请求
  • !11133

P
Paddle
  • 项目概览

PaddlePaddle / Paddle
大约 2 年 前同步成功

通知 2325
Star 20933
Fork 5424
  • 代码
    • 文件
    • 提交
    • 分支
    • Tags
    • 贡献者
    • 分支图
    • Diff
  • Issue 1423
    • 列表
    • 看板
    • 标记
    • 里程碑
  • 合并请求 543
  • Wiki 0
    • Wiki
  • 分析
    • 仓库
    • DevOps
  • 项目成员
  • Pages
P
Paddle
  • 项目概览
    • 项目概览
    • 详情
    • 发布
  • 仓库
    • 仓库
    • 文件
    • 提交
    • 分支
    • 标签
    • 贡献者
    • 分支图
    • 比较
  • Issue 1,423
    • Issue 1,423
    • 列表
    • 看板
    • 标记
    • 里程碑
  • 合并请求 543
    • 合并请求 543
  • Pages
  • 分析
    • 分析
    • 仓库分析
    • DevOps
  • Wiki 0
    • Wiki
  • 成员
    • 成员
  • 收起侧边栏
  • 动态
  • 分支图
  • 创建新Issue
  • 提交
  • Issue看板

[Do not merge] Fix nondeterminism issue wrt sentiment analysis chapter !11133

  • Report abuse
!11133 已关闭 6月 03, 2018 由 saxon_zh@saxon_zh 创建
#<User:0x00007fed620f70b0>
  • 概览 1
  • 提交 5
  • 变更 5

Created by: sidgoyal78

As mentioned in https://github.com/PaddlePaddle/Paddle/issues/11057 we get non-deterministic outputs for a couple of examples.

I tried debugging the sentiment analysis model: https://github.com/sidgoyal78/Paddle/blob/a801e7bcb2f4f1e131f6a640ecd84a03d21588ff/test_sa_conv.py

by actually saving the weights after each iteration, and also printing inputs and outputs at individual CUDA kernels. I have some findings that I wanted to share:

  • The SGD Sparse kernel has cudaAtomicAdd which results in different order of processing the float values.
  • The im2colOCF kernel (for the sequence_convolution layer) is also implemented using cudaAtomicAdd, and hence the most probable reason for inconsistent results.

In order to get consistent results I had to change the launching of both of these kernels to allow for only 1 thread.

So in summary the issue is with CUDA atomics. This was pointed out by Greg in a discussion recently, and there is another comment here: https://github.com/tensorflow/tensorflow/issues/3103#issuecomment-286302405

With these changes, we get consistent results but at the cost of performance.

Moreover, if we change the optimizer to Adam in the above example, then we don't get consistent results. So probably there is some problem with Adam optimizer as well.

Note: With launching just one thread, we don't get correct results, since only a part of the actual work is done. However, this PR is for highlighting the consistency problem (but I want to be clear that launching 1 thread does result in incorrect outputs, as can be seen in the failed unit tests).

@dzhwinter @chengduoZH : What do you guys think?

指派人
分配到
审核者
Request review from
无
里程碑
无
分配里程碑
工时统计
标识: paddlepaddle/Paddle!11133
Source branch: github/fork/sidgoyal78/fix_nondeter
渝ICP备2023009037号

京公网安备11010502055752号

网络110报警服务 Powered by GitLab CE v13.7
开源知识
Git 入门 Pro Git 电子书 在线学 Git
Markdown 基础入门 IT 技术知识开源图谱
帮助
使用手册 反馈建议 博客
《GitCode 隐私声明》 《GitCode 服务条款》 关于GitCode
Powered by GitLab CE v13.7