Skip to content

  • 体验新版
    • 正在加载...
  • 登录
  • PaddlePaddle
  • Paddle
  • Issue
  • #13405

P
Paddle
  • 项目概览

PaddlePaddle / Paddle
大约 2 年 前同步成功

通知 2325
Star 20933
Fork 5424
  • 代码
    • 文件
    • 提交
    • 分支
    • Tags
    • 贡献者
    • 分支图
    • Diff
  • Issue 1423
    • 列表
    • 看板
    • 标记
    • 里程碑
  • 合并请求 543
  • Wiki 0
    • Wiki
  • 分析
    • 仓库
    • DevOps
  • 项目成员
  • Pages
P
Paddle
  • 项目概览
    • 项目概览
    • 详情
    • 发布
  • 仓库
    • 仓库
    • 文件
    • 提交
    • 分支
    • 标签
    • 贡献者
    • 分支图
    • 比较
  • Issue 1,423
    • Issue 1,423
    • 列表
    • 看板
    • 标记
    • 里程碑
  • 合并请求 543
    • 合并请求 543
  • Pages
  • 分析
    • 分析
    • 仓库分析
    • DevOps
  • Wiki 0
    • Wiki
  • 成员
    • 成员
  • 收起侧边栏
  • 动态
  • 分支图
  • 创建新Issue
  • 提交
  • Issue看板
已关闭
开放中
Opened 9月 14, 2018 by saxon_zh@saxon_zhGuest

Question about IR graph passes

Created by: tpatejko

I've been working on fusion pass that fuses MKLDNN convolution with elementwise_add operator, and I use framework::ir graph and pass infrastructure.

The fusion pass I've been working on transforms the following set of operations:

y = conv(W, z)
out = elementwise_add(x, y)

into

y = x
y = conv`(W, z)

where

conv`(W, z) = y + conv(W, z)   <- done in MKLDNN

because MKLDNN convolution primitive that fuses elementwise_add expects data, that it will add convolution output to, already in the output memory.

I'm having some trouble implementing assignment operation y = x. x and y are nodes of variable type in a graph, so creating an edge between them is not correct, because, if I understand correctly, nodes allow only operations in their adjacency lists.

These are solutions I could think of:

  1. I could use PaddlePaddle assign_op operator so it would look like this: y = assign_op(x). However, it copies x to y so it introduces performance overhead.
  2. I could add additional input parameter to PaddlePaddle MKLDNN convolution operator that takes x as an argument and initializes output memory of MKLDNN convolution primitive.
  3. I could turn y into a reference to x but I'm not sure how to do it without abusing graph API (making two Node* pointers pointing into a single std::unique_ptr<Node> object, as, if I'm not mistaken, nodes container is implemented as std::map<Node*, std::unique_ptr<Node>>).

So, I guess option 2. is the most reasonable one. What do you think about it? Do you have any other options?

指派人
分配到
无
里程碑
无
分配里程碑
工时统计
无
截止日期
无
标识: paddlepaddle/Paddle#13405
渝ICP备2023009037号

京公网安备11010502055752号

网络110报警服务 Powered by GitLab CE v13.7
开源知识
Git 入门 Pro Git 电子书 在线学 Git
Markdown 基础入门 IT 技术知识开源图谱
帮助
使用手册 反馈建议 博客
《GitCode 隐私声明》 《GitCode 服务条款》 关于GitCode
Powered by GitLab CE v13.7