fix the strong Wolfe conditions for line search for minimize_lbfgs and minimize_bfgs APIs (#52033)

* fix the strong Wolfe conditions for line search

* pass the max_line_search_iters parameter into line search method (strong_wolfe)

python/paddle/incubate/optimizer/functional/bfgs.py

@@ -141,6 +141,7 @@ def minimize_bfgs(
                 f=objective_func,
                 xk=xk,
                 pk=pk,
+                max_iters=max_line_search_iters,
                 initial_step_length=initial_step_length,
                 dtype=dtype,
             )

python/paddle/incubate/optimizer/functional/lbfgs.py

@@ -212,6 +212,7 @@ def minimize_lbfgs(
                 f=objective_func,
                 xk=xk,
                 pk=pk,
+                max_iters=max_line_search_iters,
                 initial_step_length=initial_step_length,
                 dtype=dtype,
             )

python/paddle/incubate/optimizer/functional/line_search.py

@@ -314,7 +314,7 @@ def strong_wolfe(
             paddle.assign(ls_func_calls + j, ls_func_calls)
 
         pred1 = ~done & (
-            (phi_2 > phi_0 + c1 * a2 * derphi_0) | ((phi_2 >= phi_0) & (i > 1))
+            (phi_2 > phi_0 + c1 * a2 * derphi_0) | ((phi_2 >= phi_1) & (i > 1))
         )
         paddle.assign(done | pred1, done)
         paddle.static.nn.cond(pred1, true_fn1, None)