未验证 提交 a694e679 编写于 作者: G gouzil 提交者: GitHub

[clang-tidy] enable clang-analyzer-core.UndefinedBinaryOperatorResult (#56636)

上级 f2c7d162
...@@ -58,7 +58,7 @@ bugprone-unused-raii, ...@@ -58,7 +58,7 @@ bugprone-unused-raii,
-clang-analyzer-core.NullDereference, -clang-analyzer-core.NullDereference,
-clang-analyzer-core.StackAddrEscapeBase, -clang-analyzer-core.StackAddrEscapeBase,
-clang-analyzer-core.StackAddressEscape, -clang-analyzer-core.StackAddressEscape,
-clang-analyzer-core.UndefinedBinaryOperatorResult, clang-analyzer-core.UndefinedBinaryOperatorResult,
-clang-analyzer-core.VLASize, -clang-analyzer-core.VLASize,
-clang-analyzer-core.builtin.BuiltinFunctions, -clang-analyzer-core.builtin.BuiltinFunctions,
-clang-analyzer-core.builtin.NoReturnFunctions, -clang-analyzer-core.builtin.NoReturnFunctions,
......
...@@ -1488,7 +1488,7 @@ struct LeakyReluFunctor : public BaseActivationFunctor<T> { ...@@ -1488,7 +1488,7 @@ struct LeakyReluFunctor : public BaseActivationFunctor<T> {
template <typename Device, typename X, typename Out> template <typename Device, typename X, typename Out>
void operator()(Device d, X x, Out out) const { void operator()(Device d, X x, Out out) const {
if (alpha < 1.f) { if (alpha < 1.f) { // NOLINT
out.device(d) = x.cwiseMax(static_cast<T>(alpha) * x); out.device(d) = x.cwiseMax(static_cast<T>(alpha) * x);
} else { } else {
out.device(d) = x.cwiseMin(static_cast<T>(alpha) * x); out.device(d) = x.cwiseMin(static_cast<T>(alpha) * x);
...@@ -1653,7 +1653,7 @@ struct HardShrinkFunctor : public BaseActivationFunctor<T> { ...@@ -1653,7 +1653,7 @@ struct HardShrinkFunctor : public BaseActivationFunctor<T> {
} }
template <typename Device, typename X, typename Out> template <typename Device, typename X, typename Out>
void operator()(Device d, X x, Out out) const { void operator()(Device d, X x, Out out) const {
auto temp1 = x < static_cast<T>(threshold * -1.f); auto temp1 = x < static_cast<T>(threshold * -1.f); // NOLINT
auto temp2 = x > static_cast<T>(threshold); auto temp2 = x > static_cast<T>(threshold);
out.device(d) = x * (temp1 || temp2).template cast<T>(); out.device(d) = x * (temp1 || temp2).template cast<T>();
} }
...@@ -1673,7 +1673,7 @@ struct HardShrinkGradFunctor : public BaseActivationFunctor<T> { ...@@ -1673,7 +1673,7 @@ struct HardShrinkGradFunctor : public BaseActivationFunctor<T> {
typename dOut, typename dOut,
typename dX> typename dX>
void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const { void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const {
auto temp1 = x < static_cast<T>(threshold * -1.f); auto temp1 = x < static_cast<T>(threshold * -1.f); // NOLINT
auto temp2 = x > static_cast<T>(threshold); auto temp2 = x > static_cast<T>(threshold);
dx.device(d) = dout * (temp1 || temp2).template cast<T>(); dx.device(d) = dout * (temp1 || temp2).template cast<T>();
} }
...@@ -2565,7 +2565,7 @@ struct CELUGradFunctor : public BaseActivationFunctor<T> { ...@@ -2565,7 +2565,7 @@ struct CELUGradFunctor : public BaseActivationFunctor<T> {
typename dOut, typename dOut,
typename dX> typename dX>
void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const { void operator()(Device d, X x, Out out UNUSED, dOut dout, dX dx) const {
auto temp_a_pos = static_cast<T>(alpha > 0); auto temp_a_pos = static_cast<T>(alpha > 0); // NOLINT
auto temp_a_neg = static_cast<T>(alpha <= 0); auto temp_a_neg = static_cast<T>(alpha <= 0);
auto temp_x_pos = (x > static_cast<T>(0)).template cast<T>(); auto temp_x_pos = (x > static_cast<T>(0)).template cast<T>();
auto temp_x_neg = (x <= static_cast<T>(0)).template cast<T>(); auto temp_x_neg = (x <= static_cast<T>(0)).template cast<T>();
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册