Extend the driver to init switch register offsets from variables
instead of compile time macros and enable detection of 88E6071 and
compatible devices. Ethernet transfer (e.g. tftp) does not work yet,
so enable the registration of the 'indirect mii' bus for easier PHY
register access by 'mii' command.
Signed-off-by: NAnatolij Gustschin <agust@denx.de>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

The KSZ8081 PHY has a factory test mode which is set at the de-assertion
of the reset line based on the RXER (KSZ8081RNA/RND) or TXC
(KSZ8081MNX/RNB) pin. If a pull-down is missing, or if the pin has a
pull-up, the factory test mode should be cleared by manually writing a 0
(according to the datasheet).
Create another ksz8081_config function to handle this case.
Suggested-by: NAntoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: NNicolas Ferre <nicolas.ferre@microchip.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

device_probe() may fail in which case the seq_id will be -1. Don't
display these devices during startup. While this is only a cosmetic
change, the return value of eth_initialize() will also change to the
actual number of available devices. The return value is only used in
spl_net to decide whether there are any devices to boot from. So
returning only available devices is also more correct in that case.
Signed-off-by: NMichael Walle <michael@walle.cc>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Aquantia quad-phys may take longer to initialize. This commit adds
a polling mechanism for a global alarm bit that tells if phy init
sequence is completed.
Signed-off-by: NFlorin Chiculita <florinlaurentiu.chiculita@nxp.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

This allows passing arbitrary addresses through macb_miiphy_read and
macb_miiphy_write, therefore enabling the mii command to access
all mdio bus devices instead of only the defined phy.
Signed-off-by: NJosef Holzmayr <holzmayr@rsi-elektrotechnik.de>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

To support accessing arbitrary addresses the mii/mdio bus it is
necessary that the macb_mdio_read and macb_mdio_write functions
do not implicitly use the address of the connected phy.

The function signature is extended according to the Linux kernel
equivalent.
Signed-off-by: NJosef Holzmayr <holzmayr@rsi-elektrotechnik.de>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

I've noticed that in most cases when genphy_update_link() is called, the
ethernet driver (mt7628-eth in this case) fails with the first ethernet
packets. Resulting in a timeout of the first tftp command. Increasing
the delay in the link check look from 1 to 50 ms and moving it below the
BMSR register read fixes this issue, resulting in a stable ethernet
traffic, even after initial link autonogotiation.
Signed-off-by: NStefan Roese <sr@denx.de>
Cc: Weijie Gao <weijie.gao@mediatek.com>
Cc: Joe Hershberger <joe.hershberger@ni.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

* Add Kconfig help describing the purpose of each command.
* Add CONFIG_CMD_MDIO so it could be selected individually, as
  it doesn't depend on the mii command.
* Add Kconfig imply to mii to automatically select the mdio
  command.
Signed-off-by: NRamon Fried <rfried.dev@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

This version of the RTL-8168 chip can be found on some add-in cards sold
by CSL-Computer GmbH & Co. KG. The chip isn't special in any way, but it
needs to have the ChipCmd register programmed after the DMA descriptors
have been set up, so make sure that happens by adding an entry to the
chip information table.
Signed-off-by: NThierry Reding <treding@nvidia.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Changes to mvpp2.c require the MVMDIO module which in turn uses
DM_MDIO.
Signed-off-by: NNevo Hed <nhed+github@starry.com>
Reviewed-by: NRamon Fried <rfried.dev@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

This commit ports mvpp2 to use the recently introduced Marvell MDIO
(MVMDIO) driver.  It removes direct interaction with the SMI & XSMI
busses.  This commit is based in part on earlier work by
Ken Ma <make@marvell.com> in Marvell's own downstream repo:
https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/c81dc39.

The above refrenced work was based on an MVMDIO implementation that
never made it into U-Boot.  With this patch the mvpp2 driver switches
to use the new MVMDIO driver that is based on a more universal
mdio-uclass implementation.
Signed-off-by: NNevo Hed <nhed+github@starry.com>
Reviewed-by: NRamon Fried <rfried.dev@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Based on upstream-linux
See https://github.com/torvalds/linux/commit/f66b2aff.

However made the XSMI register window 0x16 (22) bytes per my reading
of the functional spec.  Similar commits in Marvels own repo bump it
to 0x200 (512) bytes but I did not see the reasoning for that.

https://github.com/MarvellEmbeddedProcessors/u-boot-marvell/commit/4d932b4.

Also added device-name attributes to prevent ambiguity in the `mdio`
command.
Signed-off-by: NNevo Hed <nhed+github@starry.com>
Reviewed-by: NRamon Fried <rfried.dev@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

If the phy doesn't match with any existing u-boot drivers, the phy
framework will connect it to the generic one which uid ==
0xffffffff. In this case, act as if the phy wouldn't be declared in
dts. Otherwise, in case of 3310 (for which the driver doesn't exist)
the link is marked as always down. Removing phy entry from dts in case
of 3310 is not a good option because it is required for the
phy_fw_down procedure.

This patch fixes the issue with the link always down on MCBIN board.

nhed: added NULL deref test.
Signed-off-by: NGrzegorz Jaszczyk <jaz@semihalf.com>
Reviewed-by: NIgal Liberman <igall@marvell.com>
Tested-by: NIgal Liberman <igall@marvell.com>
Signed-off-by: NNevo Hed <nhed+github@starry.com>
Reviewed-by: NRamon Fried <rfried.dev@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Issue:
- Network stuck if autonegotion fails.

Issue root cause:

- When autonegotiation fails during port open procedure, the packet
  processor configuration does not finish and open procedure exits
  with error.
- However, this doesn't prevent u-boot network framework from
  calling send and receive procedures.
- Using transmit and receive functions of misconfigured packet
  processor will cause traffic to get stuck.

Fix:

- Continue packet processor configuration even if autonegotiation
  fails.  Only error message is triggered in this case.
- Exit transmit and receive functions if there is no PHY link
  indication.
- U-boot network framework now calls open procedure again during next
  transmit initiation.
Signed-off-by: NStefan Chulski <stefanc@marvell.com>
Reviewed-by: NIgal Liberman <igall@marvell.com>
Tested-by: NIgal Liberman <igall@marvell.com>
Reviewed-by: NRamon Fried <rfried.dev@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

The AM654 SoC doesn't allow to disabling RGMII TX internal delay in CPSW2G
MAC. Hence, change CPSW2G interface mode to "rgmii-rxid" - RGMII with
internal RX delay provided by the PHY, the MAC will add an TX delay in this
case.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Refactor SGMII configuration to group all settings together and reduce
number of MDIO transactions.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Based on commit 27708eb5481b ("net: phy: dp83867: IO impedance is not
dependent on RGMII delay") of mainline linux kernel.

The driver would only set the IO impedance value when RGMII internal delays
were enabled.  There is no reason for this.  Move the IO impedance block
out of the RGMII delay block.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Based on commit c11669a2757e ("net: phy: dp83867: Rework delay rgmii delay
handling") of mainline linux kernel.

The current code is assuming the reset default of the delay control
register was to have delay disabled.  This is what the datasheet shows as
the register's initial value.  However, that's not actually true: the
default is controlled by the PHY's pin strapping.

This patch:
- insures the other direction's delay is disabled If the interface mode is
selected as RX or TX delay only
- validates the delay values and fail if they are not in range
- checks if the board is strapped to have a delay and is configured to use
"rgmii" mode and warning is generated that "rgmii-id" should have been
used.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Based on commit 13c83cf8af0d ("net: phy: dp83867: Add ability to disable
output clock") of mainline linux kernel.

Generally, the output clock pin is only used for testing and only serves as
a source of RF noise after this.  It could be used to daisy-chain PHYs, but
this is uncommon.  Since the PHY can disable the output, make doing so an
option.  I do this by adding another enumeration to the allowed values of
ti,clk-output-sel.

The code was not using the value DP83867_CLK_O_SEL_REF_CLK as one might
expect: to select the REF_CLK as the output.  Rather it meant "keep clock
output setting as is", which, depending on PHY strapping, might not be
outputting REF_CLK.

Change this so DP83867_CLK_O_SEL_REF_CLK means enable REF_CLK output.
Omitting the property will leave the setting as is (which was the previous
behavior in this case).

Out of range values were silently converted into DP83867_CLK_O_SEL_REF_CLK.
Change this so they generate an error.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Based on commit 980066e6d964 ("dt-bindings: phy: dp83867: Add documentation
for disabling clock output") of mainline linux kernel.

The clock output is generally only used for testing and development and not
used to daisy-chain PHYs.  It's just a source of RF noise afterward.

Add a mux value for "off".  I've added it as another enumeration to the
output property.  In the actual PHY, the mux and the output enable are
independently controllable.  However, it doesn't seem useful to be able
to describe the mux setting when the output is disabled.

Document that PHY's default setting will be left as is if the property
is omitted.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Move static, one-time initialization to .probe() callback.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

The driver ti.c is actually driver for TI DP83867x PHYs, so rename it
accordingly.
Signed-off-by: NGrygorii Strashko <grygorii.strashko@ti.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

During testing of qemu-riscv32 with a 2GiB memory configuration,
tftp always fails with a error message:

  Load address: 0x84000000
  Loading: #
  TFTP error: trying to overwrite reserved memory...

It turns out the result of 'tftp_load_addr + tftp_load_size' just
overflows (0x100000000) and the test logic in store_block() fails.
Fix this by adjusting the end address to ULONG_MAX when overflow
is detected.

Fixes: a156c47e ("tftp: prevent overwriting reserved memory")
Signed-off-by: NBin Meng <bmeng.cn@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

sandbox_defconfig does not compile using GCC 9.2.1:

net/net.c: In function ‘net_process_received_packet’:
net/net.c:1288:23: error: taking address of packed member of ‘struct
ip_udp_hdr’ may result in an unaligned pointer value
[-Werror=address-of-packed-member]
 1288 |    sumptr = (ushort *)&(ip->udp_src);
      |                       ^~~~~~~~~~~~~~

Avoid the error by using a u8 pointer instead of an u16 pointer and
in-lining ntohs().

Simplify the checksumming of the last message byte.
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>
Reviewed-by: NSimon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix 'mask' calculation in phy_connect() for phy addr '0'.
'mask' is getting set to '0xffffffff' for phy addr '0'
in phy_connect() whereas expected value is '0'.
Signed-off-by: NPriyanka Jain <priyanka.jain@nxp.com>
Reported-by: tetsu-aoki via github
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

While we have networking use cases within SPL we do not support loading
files via NFS at this point in time.  Disable calling nfs_start() so
that the NFS related code can be garbage collected at link time.
Signed-off-by: NTom Rini <trini@konsulko.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>

Even if not communicating over the network in U-Boot, code may be manipulating
and storing IP or MAC addresses to pass to Linux, etc.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Part of the env cleanup moved this out of the environment code and into
the net code. However, this helper is sometimes needed even when the net
stack isn't included.

Move the helper to lib/net_utils.c like it's similarly-purposed
string_to_ip(). Also rename the moved function to similar naming.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Reported-by: NOndrej Jirman <megous@megous.com>

- 16-bit start up codes clean up

You can directly specify the label as the operand for ljmp.

This commit saves 4-byte code.
Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Tested-by: NBin Meng <bmeng.cn@gmail.com>
[bmeng: fixed the gas warning]
Signed-off-by: NBin Meng <bmeng.cn@gmail.com>

This file defines 'a32' and 'o32' macros to avoid magic numbers
of operand/address-size prefixing.

GAS supports 'data32' and 'addr32' for that purpose.
Signed-off-by: NMasahiro Yamada <masahiroy@kernel.org>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Tested-by: NBin Meng <bmeng.cn@gmail.com>

- Allow for the sysboot command, which is used to parse extlinux.conf
  files to be used without PXE support.  There is no functional change
  here aside from fixing distro boot in a few cases where we actually
  lacked the ability to parse the extlinux.conf file
- Add the x509/pkcs7 parsers from Linux, a pre-requisite to EFI Secure
  Boot support.

With the change to make tools/version.h a file we need to make sure that
the output directory exists first otherwise we will get a build failure.
Reported-by: NPeter Robinson <pbrobinson@gmail.com>
Tested-by: NPeter Robinson <pbrobinson@gmail.com>
Fixes: 4d90f6cd ("tools: Avoid creating symbolic links for tools/version.h")
Signed-off-by: NTom Rini <trini@konsulko.com>
Reviewed-by: NBin Meng <bmeng.cn@gmail.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

This test will exercise asn1 compiler as well as asn1 decoder functions
via various parsers.
Signed-off-by: NAKASHI Takahiro <takahiro.akashi@linaro.org>

Imported from linux kernel v5.3:
 pkcs7.asn1 without changes
 pkcs7.h with changes marked as __UBOOT__
 pkcs7_parser.h without changes
 pkcs7_parser.c with changes marked as __UBOOT__
Signed-off-by: NAKASHI Takahiro <takahiro.akashi@linaro.org>

Imported from linux kernel v5.3:
 x509.asn1 without changes
 x509_akid.asn1 without changes
 x509_parser.h without changes
 x509_cert_parser.c with changes marked as __UBOOT__
 x509_public_key.c with changes marked as __UBOOT__
Signed-off-by: NAKASHI Takahiro <takahiro.akashi@linaro.org>

Imported from linux kernel v5.3:
rsapubkey.asn1 without changes
rsa.h without changes
rsa_helper.c with changes marked as __UBOOT__
Signed-off-by: NAKASHI Takahiro <takahiro.akashi@linaro.org>

Imported from linux kernel v5.3:
 asymmetric-type.h with changes marked as __UBOOT__
 asymmetric_type.c with changes marked as __UBOOT__
 public_key.h with changes marked as __UBOOT__
 public_key.c with changes marked as __UBOOT__
Signed-off-by: NAKASHI Takahiro <takahiro.akashi@linaro.org>

Imported from linux kernel v5.3:
 build_OID_registry without changes
 oid_registry.h without changes
 oid_registry.c with changes marked as __UBOOT__
Signed-off-by: NAKASHI Takahiro <takahiro.akashi@linaro.org>