- 24 4月, 2019 1 次提交
-
-
由 Eugeniu Rosca 提交于
Paranoid programming [1] lies at the foundation of proper software development, but the repetitive zeroing-out of output arguments in the context of the same function rather clutters the code and inhibits further refactoring/optimization than is doing any good. In boot_get_fdt(), we already perform zero/NULL-initialization of *of_flat_tree and *of_size at the beginning of the function, so doing the same at function error-out is redundant/superfluous. Moreover, keeping the code unchanged might encourage the developers to update *of_flat_tree and *of_size during some interim computations, which is against the current design of boot_get_fdt(). Currently, writing useful data into these arguments happens just before successfully returning from boot_get_fdt() and it should better stay so. [1] https://blog.regehr.org/archives/1106Signed-off-by: NEugeniu Rosca <erosca@de.adit-jv.com> Reviewed-by: NSimon Glass <sjg@chromium.org>
-
- 09 3月, 2019 1 次提交
-
-
由 Patrick Delaunay 提交于
Handle in boot_fdt_reserve_region any return value > 0 of lmb_reserve() function; it occurs when coalesced region are found: adjacent reserved region are merged. This patch avoid the error trace: ERROR: reserving fdt memory region failed.. when reserved region are merged (return value = 1). Signed-off-by: NPatrick Delaunay <patrick.delaunay@st.com>
-
- 09 2月, 2019 1 次提交
-
-
由 Shawn Guo 提交于
Some platforms choose to store device tree blob in Android image second area. Let's try to look for dtb from there when booting an Android image, and use it for booting if found. Signed-off-by: NShawn Guo <shawn.guo@linaro.org>
-
- 17 1月, 2019 1 次提交
-
-
由 Simon Goldschmidt 提交于
boot_fdt_add_mem_rsv_regions() adds reserved memory sections to an lmb struct. Currently, it only parses regions described by /memreserve/ entries. Extend this to the more commonly used scheme of the "reserved-memory" node. Signed-off-by: NSimon Goldschmidt <simon.k.r.goldschmidt@gmail.com> Reviewed-by: NSimon Glass <sjg@chromium.org>
-
- 15 1月, 2019 1 次提交
-
-
由 Simon Goldschmidt 提交于
Booting an image currently sets the environment variable "fdtaddr" by calling into 'cmd/fdt.c'. As a result, linking U-Boot fails if CMD_FDT is not enabled. Fix this by adding 'if (CONFIG_IS_ENABLED(CMD_FDT))' to the two places where 'set_working_fdt_addr()' is called. Signed-off-by: NSimon Goldschmidt <simon.k.r.goldschmidt@gmail.com>
-
- 26 9月, 2018 1 次提交
-
-
由 Alexander Graf 提交于
When running sandbox with the new pointer sanitization we just recently introduced, we're running into a case with FIT images where we end up interpreting pointers as addresses. What happened is that most callers of set_working_fdt_addr() simply convert pointers into addresses without taking into account that they might be 2 separate address spaces. Fix the callers up to map their pointers into addresses. This makes sandbox tests pass for me again. Signed-off-by: NAlexander Graf <agraf@suse.de>
-
- 07 5月, 2018 1 次提交
-
-
由 Tom Rini 提交于
When U-Boot started using SPDX tags we were among the early adopters and there weren't a lot of other examples to borrow from. So we picked the area of the file that usually had a full license text and replaced it with an appropriate SPDX-License-Identifier: entry. Since then, the Linux Kernel has adopted SPDX tags and they place it as the very first line in a file (except where shebangs are used, then it's second line) and with slightly different comment styles than us. In part due to community overlap, in part due to better tag visibility and in part for other minor reasons, switch over to that style. This commit changes all instances where we have a single declared license in the tag as both the before and after are identical in tag contents. There's also a few places where I found we did not have a tag and have introduced one. Signed-off-by: NTom Rini <trini@konsulko.com>
-
- 01 4月, 2018 1 次提交
-
-
由 Masahiro Yamada 提交于
This macro is locally referenced in common/image-fdt.c Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com> Reviewed-by: NSimon Glass <sjg@chromium.org>
-
- 05 3月, 2018 1 次提交
-
-
由 Masahiro Yamada 提交于
Thomas reported U-Boot failed to build host tools if libfdt-devel package is installed because tools include libfdt headers from /usr/include/ instead of using internal ones. This commit moves the header code: include/libfdt.h -> include/linux/libfdt.h include/libfdt_env.h -> include/linux/libfdt_env.h and replaces include directives: #include <libfdt.h> -> #include <linux/libfdt.h> #include <libfdt_env.h> -> #include <linux/libfdt_env.h> Reported-by: NThomas Petazzoni <thomas.petazzoni@bootlin.com> Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com>
-
- 19 2月, 2018 1 次提交
-
-
由 Alexey Brodkin 提交于
Only ARM and in some configs MIPS really implement arch_fixup_fdt(). Others just use the same boilerplate which is not good by itself, but what's worse if we try to build with disabled CONFIG_CMD_BOOTM and enabled CONFIG_OF_LIBFDT we'll hit an unknown symbol which was apparently implemented in arch/xxx/lib/bootm.c. Now with weak arch_fixup_fdt() right in image-fdt.c where it is used we get both items highlighted above fixed. Signed-off-by: NAlexey Brodkin <abrodkin@synopsys.com> Cc: Daniel Schwierzeck <daniel.schwierzeck@gmail.com> Cc: Simon Glass <sjg@chromium.org> Cc: York Sun <york.sun@nxp.com> Cc: Stefan Roese <sr@denx.de> Reviewed-by: NTom Rini <trini@konsulko.com> Reviewed-by: NDaniel Schwierzeck <daniel.schwierzeck@gmail.com>
-
- 16 10月, 2017 1 次提交
-
-
由 Tuomas Tynkkynen 提交于
Removal of the legacy DataFlash code turned genimg_get_image() into a no-op. Drop all calls to it and the function itself. Signed-off-by: NTuomas Tynkkynen <tuomas.tynkkynen@iki.fi>
-
- 15 9月, 2017 1 次提交
-
-
由 Pantelis Antoniou 提交于
Introduce an overlay based method for constructing a base DT blob to pass to the kernel. It is based on a specific method now to get the FDT from a FIT image named boot_get_fdt_fit(). Signed-off-by: NPantelis Antoniou <pantelis.antoniou@konsulko.com> Acked-by: NSimon Glass <sjg@chromium.org>
-
- 16 8月, 2017 2 次提交
-
-
由 Simon Glass 提交于
We are now using an env_ prefix for environment functions. Rename these other functions as well, for consistency: getenv_vlan() getenv_bootm_size() getenv_bootm_low() getenv_bootm_mapsize() env_get_default() Suggested-by: NWolfgang Denk <wd@denx.de> Signed-off-by: NSimon Glass <sjg@chromium.org>
-
由 Simon Glass 提交于
We are now using an env_ prefix for environment functions. Rename these two functions for consistency. Also add function comments in common.h. Quite a few places use getenv() in a condition context, provoking a warning from checkpatch. These are fixed up in this patch also. Suggested-by: NWolfgang Denk <wd@denx.de> Signed-off-by: NSimon Glass <sjg@chromium.org>
-
- 01 5月, 2017 1 次提交
-
-
由 Tom Rini 提交于
With 3f66149d we no longer have a common call fdt_fixup_ethernet. This was fine to do on PowerPC as they largely had calls already in ft_cpu_fixup. On ARM however we largely relied on this call. Rather than introduce a large number of changes to ft_cpu_fixup / ft_board_fixup we recognize that this is a common enough call that we should be doing it in a central location. Do it early enough that we can do any further updates in ft_cpu_fixup / ft_board_fixup. Cc: Gerd Hoffmann <kraxel@redhat.com> Cc: Chen-Yu Tsai <wens@csie.org> Cc: Maxime Ripard <maxime.ripard@free-electrons.com> Cc: Thomas Chou <thomas@wytron.com.tw> (maintainer:NIOS) Cc: York Sun <york.sun@nxp.com> (maintainer:POWERPC MPC85XX) Cc: Stefan Roese <sr@denx.de> (maintainer:POWERPC PPC4XX) Cc: Simon Glass <sjg@chromium.org> Cc: Joakim Tjernlund <Joakim.Tjernlund@infinera.com> Fixes: 3f66149d ("Remove extra fdt_fixup_ethernet() call") Signed-off-by: NTom Rini <trini@konsulko.com> Acked-by: NStefan Roese <sr@denx.de> Acked-by: NYork Sun <york.sun@nxp.com> Reviewed-by: NSimon Glass <sjg@chromium.org>
-
- 08 4月, 2017 1 次提交
-
-
由 Joakim Tjernlund 提交于
ft_cpu_setup() already calls fdt_fixup_ethernet(), calling it in image_setup_libfdt() is both redundant and breaks any modifications done by ft_board_setup(). Restore the old behavior by removing the call in image_setup_libfdt() Fixes: 13d06981 ("image: Add device tree setup to image library") Signed-off-by: NJoakim Tjernlund <joakim.tjernlund@infinera.com>
-
- 03 12月, 2016 1 次提交
-
-
由 Masahiro Yamada 提交于
Commit e2f88dfd ("libfdt: Introduce new ARCH_FIXUP_FDT option") allows us to skip memory setup of DTB, but a problem for ARM is that spin_table_update_dt() and psci_update_dt() are skipped as well if CONFIG_ARCH_FIXUP_FDT is disabled. This commit allows us to skip only fdt_fixup_memory_banks() instead of the whole of arch_fixup_fdt(). It will be useful when we want to use a memory node from a kernel DTB as is, but need some fixups for Spin-Table/PSCI. Signed-off-by: NMasahiro Yamada <yamada.masahiro@socionext.com> Acked-by: NAlexey Brodkin <abrodkin@synopsys.com> Acked-by: NSimon Glass <sjg@chromium.org> Fixed build error for x86: Signed-off-by: NSimon Glass <sjg@chromium.org>
-
- 14 10月, 2016 1 次提交
-
-
由 Hannes Schmelzer 提交于
Sometimes devicetree nodes and or properties are added out of the u-boot console, maybe through some script or manual interaction. The devicetree as loaded or embedded is quite small, so the devicetree has to be resized to take up those new nodes/properties. In original the devicetree was only extended by effective 4 * add_mem_rsv. With this commit we can add an argument to the "fdt resize" command, which takes the extrasize to be added. Signed-off-by: NHannes Schmelzer <hannes.schmelzer@br-automation.com> Signed-off-by: NHannes Schmelzer <oe5hpm@oevsv.at> Acked-by: NSimon Glass <sjg@chromium.org>
-
- 22 9月, 2016 1 次提交
-
-
由 Paul Burton 提交于
Commit bac17b78 ("image-fit: switch ENOLINK to ENOENT") changed fit_get_node_from_config to return -ENOENT when a property doesn't exist, but didn't change any of its callers which check return values. Notably it didn't change boot_get_ramdisk, which leads to U-Boot failing to boot FIT images which don't include ramdisks with the following message: Ramdisk image is corrupt or invalid It also didn't take into account that by returning -ENOENT to denote the lack of a property we lost the ability to determine from the return value of fit_get_node_from_config whether it was the property or the configuration node that was missing, which may potentially lead callers to accept invalid FIT images. Fix this by having fit_get_node_from_config return -EINVAL when the configuration node isn't found and -ENOENT when the property isn't found, which seems to make semantic sense. Callers that previously checked for -ENOLINK are adjusted to check for -ENOENT, which fixes the breakage introduced by commit bac17b78 ("image-fit: switch ENOLINK to ENOENT"). The only other user of the return fit_get_node_from_config return value, indirectly, is bootm_find_os which already checked for -ENOENT. From a read-through of the code I suspect it ought to have been checking for -ENOLINK prior to bac17b78 ("image-fit: switch ENOLINK to ENOENT") anyway, which would make it right after this patch, but this would be good to get verified by someone who knows this x86 code or is able to test it. Signed-off-by: NPaul Burton <paul.burton@imgtec.com> Cc: Jonathan Gray <jsg@jsg.id.au> Cc: Marek Vasut <marex@denx.de> Acked-by: NMarek Vasut <marex@denx.de> Acked-by: NStefan Roese <sr@denx.de> Acked-by: NGeorge McCollister <george.mccollister@gmail.com> Tested-by: NGeorge McCollister <george.mccollister@gmail.com>
-
- 01 8月, 2016 1 次提交
-
-
由 Michal Simek 提交于
Add new Kconfig option to disable arch_fixup_fdt() calls for cases where U-Boot shouldn't update memory setup in DTB file. One example of usage of this option is to boot OS with different memory setup than U-Boot use. Signed-off-by: NMichal Simek <michal.simek@xilinx.com> Acked-by: NSimon Glass <sjg@chromium.org>
-
- 16 3月, 2016 1 次提交
-
-
由 Alexander Graf 提交于
We have a nice framework around image fils to prepare a device tree for OS execution. That one patches in missing device tree nodes and fixes up the memory range bits. We need to call that one from the EFI boot path too to get all those nice fixups. This patch adds the call. Signed-off-by: NAlexander Graf <agraf@suse.de>
-
- 15 3月, 2016 1 次提交
-
-
由 Simon Glass 提交于
There are already two FIT options in Kconfig but the CONFIG options are still in the header files. We need to do a proper move to fix this. Move these options to Kconfig and tidy up board configuration: CONFIG_FIT CONFIG_OF_BOARD_SETUP CONFIG_OF_SYSTEM_SETUP CONFIG_FIT_SIGNATURE CONFIG_FIT_BEST_MATCH CONFIG_FIT_VERBOSE CONFIG_OF_STDOUT_VIA_ALIAS CONFIG_RSA Unfortunately the first one is a little complicated. We need to make sure this option is not enabled in SPL by this change. Also this option is enabled automatically in the host builds by defining CONFIG_FIT in the image.h file. To solve this, add a new IMAGE_USE_FIT #define which can be used in files that are built on the host but must also build for U-Boot and SPL. Note: Masahiro's moveconfig.py script is amazing. Signed-off-by: NSimon Glass <sjg@chromium.org> [trini: Add microblaze change, various configs/ re-applies] Signed-off-by: NTom Rini <trini@konsulko.com>
-
- 06 2月, 2016 1 次提交
-
-
由 Bin Meng 提交于
Correct spelling of "U-Boot" shall be used in all written text (documentation, comments in source files etc.). Signed-off-by: NBin Meng <bmeng.cn@gmail.com> Reviewed-by: NHeiko Schocher <hs@denx.de> Reviewed-by: NSimon Glass <sjg@chromium.org> Reviewed-by: NMinkyu Kang <mk7.kang@samsung.com>
-
- 06 12月, 2015 1 次提交
-
-
由 Peng Fan 提交于
If condition of "(load == image_start || load == image_data)" is true, should use "fdt_addr = load;", but not "fdt_blob = (char *)image_data;", or fdt_blob will be overridden by "fdt_blob = map_sysmem(fdt_addr, 0);" at the end of the switch case. Signed-off-by: NPeng Fan <Peng.Fan@freescale.com> Cc: Simon Glass <sjg@chromium.org> Cc: Joe Hershberger <joe.hershberger@ni.com> Cc: Max Krummenacher <max.krummenacher@toradex.com> Cc: Marek Vasut <marex@denx.de> Cc: Suriyan Ramasami <suriyan.r@gmail.com> Cc: Paul Kocialkowski <contact@paulk.fr> Cc: Tom Rini <trini@konsulko.com> Reviewed-by: NSimon Glass <sjg@chromium.org>
-
- 13 8月, 2015 1 次提交
-
-
由 Max Krummenacher 提交于
This fixes the following warning (and the runtime error reporting): ../common/image-fdt.c:491:4: warning: 'fdt_ret' may be used uninitialized in this function [-Wmaybe-uninitialized] Signed-off-by: NMax Krummenacher <max.krummenacher@toradex.com> Signed-off-by: NMarcel Ziswiler <marcel.ziswiler@toradex.com> Acked-by: NMarek Vasut <marex@denx.de> Acked-by: NSimon Glass <sjg@chromium.org>
-
- 05 6月, 2015 1 次提交
-
-
由 Paul Kocialkowski 提交于
Before device-tree, the device serial number used to be passed to the kernel using ATAGs (on ARM). This is now deprecated and all the handover to the kernel should now be done using device-tree. Thus, this passes the serial-number property to the kernel using the serial-number property of the root node, as expected by the kernel. The serial number is a string that somewhat represents the device's serial number. It might come from some form of storage (e.g. an eeprom) and be programmed at factory-time by the manufacturer or come from identification bits available in e.g. the SoC. Signed-off-by: NPaul Kocialkowski <contact@paulk.fr> Reviewed-by: NSimon Glass <sgj@chromium.org>
-
- 19 4月, 2015 1 次提交
-
-
由 Joe Hershberger 提交于
In the case where the arch defines a custom map_sysmem(), make sure that including just mapmem.h is sufficient to have these functions as they are when the arch does not override it. Also split the non-arch specific functions out of common.h Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com> Reviewed-by: NSimon Glass <sjg@chromium.org>
-
- 18 2月, 2015 1 次提交
-
-
由 Joe Hershberger 提交于
Commit 90bac29a claims to fix this bug that was introduced in commit a92fd657 but doesn't actually make the change that the commit message describes. Actually fix the bug this time. Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com> Acked-by: NSimon Glass <sjg@chromium.org>
-
- 08 12月, 2014 1 次提交
-
-
由 Suriyan Ramasami 提交于
The boot commands - bootz/bootm mandate a third argument which is the address to the FDT blob. In cases where this argument is not specified, boot fails with a message indicating a missing FDT. This causes non-FDT kernels to fail to boot. This patch allows both FDT and non-FDT kernels to boot by making the third parameter to the bootm/bootz optional. Signed-off-by: NSuriyan Ramasami <suriyan.r@gmail.com> Acked-by: NSimon Glass <sjg@chromium.org> [trini: Update again for covering appended DTB case after last revert in this area] Signed-off-by: NTom Rini <trini@ti.com>
-
- 04 12月, 2014 1 次提交
-
-
由 Tom Rini 提交于
It has been found that this change breaks the case of an appended device tree file, so for the problem in question some other solution must be found. This reverts commit c6150aaf. Reported-by: NBill Pringlemeir <bpringlemeir@nbsps.com> Reported-by: NPantelis Antoniou <panto@antoniou-consulting.com> Confirmed-by: NBill Pringlemeir <bpringlemeir@nbsps.com> Signed-off-by: NTom Rini <trini@ti.com>
-
- 21 11月, 2014 2 次提交
-
-
由 Simon Glass 提交于
Add an additional function for adding information to the device tree before booting. This permits additions which are not board-specific. Signed-off-by: NSimon Glass <sjg@chromium.org> Acked-by: NAnatolij Gustschin <agust@denx.de> Reviewed-by: NTom Rini <trini@ti.com>
-
由 Simon Glass 提交于
The message about needing to reset should be printed no matter what error is printed. Also, an error should always be printed. Signed-off-by: NSimon Glass <sjg@chromium.org> Acked-by: NAnatolij Gustschin <agust@denx.de> Reviewed-by: NTom Rini <trini@ti.com>
-
- 08 11月, 2014 1 次提交
-
-
由 Noam Camus 提交于
I believe that when no DTB is around we should return 1. This why I fixed such scenarious to not return zero anymore. Else kernel might get NULL pointer to DTB which doesn't exists. Signed-off-by: NNoam Camus <noamc@ezchip.com>
-
- 09 8月, 2014 1 次提交
-
-
由 Simon Glass 提交于
Since libfdt now has an fdt_resize() function, we need to rename the U-Boot one. Signed-off-by: NSimon Glass <sjg@chromium.org>
-
- 28 7月, 2014 1 次提交
-
-
由 Ma Haijun 提交于
Some architecture needs extra device tree setup. Instead of adding yet another hook, convert arch_fixup_memory_node to be a generic FDT fixup function. [maz: collapsed 3 patches into one, rewrote commit message] Signed-off-by: NMa Haijun <mahaijuns@gmail.com> Signed-off-by: NMarc Zyngier <marc.zyngier@arm.com> Acked-by: NIan Campbell <ijc@hellion.org.uk>
-
- 26 7月, 2014 1 次提交
-
-
由 Khoronzhuk, Ivan 提交于
Use CONFIG_SOC_KEYSTONE in common places instead of defining a lot of "if def .. || if def " for different Keystone2 SoC types. Acked-by: NMurali Karicheri <m-karicheri2@ti.com> Signed-off-by: NIvan Khoronzhuk <ivan.khoronzhuk@ti.com>
-
- 19 6月, 2014 3 次提交
-
-
由 Simon Glass 提交于
This can be obtained by looking up the image type, so is redundant. It is better to centralise this lookup to avoid errors. Signed-off-by: NSimon Glass <sjg@chromium.org>
-
由 Masahiro Yamada 提交于
After all, we have realized "force" argument is completely useless. fdt_chosen() was always called with force = 1. We should always want to do the same thing (set appropriate value to the property) even if the property already exists. Signed-off-by: NMasahiro Yamada <yamada.m@jp.panasonic.com> Acked-by: NSimon Glass <sjg@chromium.org>
-
由 Masahiro Yamada 提交于
After all, we have realized "force" argument is completely useless. fdt_initrd() was always called with force = 1. We should always want to do the same thing (set appropriate value to the property) even if the property already exists. Signed-off-by: NMasahiro Yamada <yamada.m@jp.panasonic.com> Acked-by: NSimon Glass <sjg@chromium.org>
-
- 06 6月, 2014 1 次提交
-
-
由 Heiko Schocher 提交于
make the use of legacy image format configurable through the config define CONFIG_IMAGE_FORMAT_LEGACY. When relying on signed FIT images with required signature check the legacy image format should be disabled. Therefore introduce this new define and enable legacy image format if CONFIG_FIT_SIGNATURE is not set. If CONFIG_FIT_SIGNATURE is set disable per default the legacy image format. Signed-off-by: NHeiko Schocher <hs@denx.de> Cc: Simon Glass <sjg@chromium.org> Cc: Lars Steubesand <lars.steubesand@philips.com> Cc: Mike Pearce <mike@kaew.be> Cc: Wolfgang Denk <wd@denx.de> Cc: Tom Rini <trini@ti.com> Cc: Michal Simek <monstr@monstr.eu> Acked-by: NSimon Glass <sjg@chromium.org>
-