This function does nothing but call env_get_char_spec(). Drop it and
adjust its only caller.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NTom Rini <trini@konsulko.com>

The check for gd->env_valid is used in both the 'if' and 'else' part of
env_get_char(). Move it into that function instead for simplicity. Drop
that code from the two leaf functions.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NTom Rini <trini@konsulko.com>

This function is not used anywhere other than env_get_char(). Move the
code into that function.
Reviewed-by: NTom Rini <trini@konsulko.com>
Signed-off-by: NSimon Glass <sjg@chromium.org>

These functions are not used outside this file. Make them static and order
them to avoid forward declarations.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NTom Rini <trini@konsulko.com>

About a quarter of the files in common/ relate to the environment. It
seems better to put these into their own subdirectory and remove the
prefix.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NTom Rini <trini@konsulko.com>

All current environments that implement redundancy use almost
identical implementations. This patch implements the env_nand
implementation as a function in env_common, and updates the
env_export function to export an env_nand-style 'flags' field by
default.
Signed-off-by: NFiach Antaw <fiach.antaw@uqconnect.edu.au>
Reviewed-by: NTom Rini <trini@konsulko.com>

aes.h is a too generic name if this file can
be exported and used by a program.
Rename it to avoid any conflicts with
other files (for example, from openSSL).
Signed-off-by: NStefano Babic <sbabic@denx.de>

Fix various misspellings of:

 * deprecated
 * partition
 * preceding,preceded
 * preparation
 * its versus it's
 * export
 * existing
 * scenario
 * redundant
 * remaining
 * value
 * architecture
Signed-off-by: NRobert P. J. Day <rpjday@crashcourse.ca>
Reviewed-by: NJagan Teki <jteki@openedev.com>
Reviewed-by: NStefan Roese <sr@denx.de>

    Fix a number of typos, including:

     * "compatble" -> "compatible"
     * "eanbeld" -> "enabled"
     * "envrionment" -> "environment"
     * "FTD" -> "FDT" (for "flattened device tree")
     * "ommitted" -> "omitted"
     * "overriden" -> "overridden"
     * "partiton" -> "partition"
     * "propogate" -> "propagate"
     * "resourse" -> "resource"
     * "rest in piece" -> "rest in peace"
     * "suport" -> "support"
     * "varible" -> "variable"
Signed-off-by: NRobert P. J. Day <rpjday@crashcourse.ca>

Setup flag when default environment are used to be able to
rewrite default distro boot variables based on SoC boot mode.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NAlexander Graf <agraf@suse.de>

When this option is enabled, CRLF is treated like LF when importing environments
from text files, which means CRs ('\r') in front of LFs ('\n') are just ignored.

Drawback of enabling this option is that (maybe exported) variables which have
a trailing CR in their content will get imported without that CR. But this
drawback is very unlikely and the big advantage of letting Windows user create
a *working* uEnv.txt too is likely more welcome.
Signed-off-by: NAlexander Holler <holler@ahsoftware.de>

Signed-off-by: NJeroen Hofstee <jeroen@myspectrum.nl>

Add function which allows encrypting the whole environment block with
AES-128-CBC. The key for the environment is retrieved by
env_aes_cbc_get_key() function, which must be implemented on a per-board
basis.
Signed-off-by: NMarek Vasut <marex@denx.de>

Implement env_export() wrapper, so that all implementers of saveenv() don't
have to call hexport_r(), crc32() etc. sequence . This trims down a bit of
code duplication.
Signed-off-by: NMarek Vasut <marex@denx.de>

Signed-off-by: NWolfgang Denk <wd@denx.de>

The functionality env_import will be used in the SPL. They
had been excluded by ifndef CONFIG_SPL_BUILD. Now, put it
into the SPL.
Signed-off-by: NYing Zhang <b40530@freescale.com>
Acked-by: NTom Rini <trini@ti.com>
Acked-by: NYork Sun <yorksun@freescale.com>

Signed-off-by: NWolfgang Denk <wd@denx.de>
[trini: Fixup common/cmd_io.c]
Signed-off-by: NTom Rini <trini@ti.com>

Add support for read-only, write-once, and change-default.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Currently just validates variable types as decimal, hexidecimal,
boolean, ip address, and mac address.

If the entry is not found in the env ".flags", then look in the static
one. This allows the env to override the static definitions, but prevents
the need to have every definition in the environment distracting you.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Move the getenv_yesno() to env_common.c and change most checks for
'y' or 'n' to use this helper.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Move the read of the old value to inside the check function.  In some
cases it can be avoided all together and at the least the code is only
called from one place.

Also name the function and the callback to more clearly describe what
it does.

Pass the ENTRY instead of just the name for direct access to the whole
data structure.

Pass an enum to the callback that specifies the operation being approved.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Use a flag in hsearch_r for insert mode passed from import to allow the
behavior be different based on use.

Now that "do_check" is called for all imports, ensure console init is
complete before updating the console on relocation import
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

There used to be a huge structure duplicated 3 times in the source.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Signed-off-by: NTom Rini <trini@ti.com>

Kill multiple occurances and redeclaration of MK_STR
in favor of __stringify().
Signed-off-by: NMarek Vasut <marex@denx.de>
Cc: Wolfgang Denk <wd@denx.de>
Signed-off-by: NTom Rini <trini@ti.com>

This patch adds support for networking in SPL. Some devices are
capable of loading SPL via network so it makes sense to load the
main U-Boot binary via network too. This patch tries to use
existing network code as much as possible. Unfortunately, it depends
on environment which in turn depends on other code so SPL size
is increased significantly. No effort was done to decouple network
code and environment so far.
Signed-off-by: NIlya Yanok <ilya.yanok@cogentembedded.com>
Acked-by: NJoe Hershberger <joe.hershberger@ni.com>
Signed-off-by: NTom Rini <trini@ti.com>

Change the syntax (user API) for "env default":
  -f: override write-once variables
  var... : accept individual variable(s)
  -a: all (resetting the whole env is NOT the default behavior)

Enable variable checking and make changes effective by
enabling do_apply argument to himport_r().
Signed-off-by: NGerlando Falauto <gerlando.falauto@keymile.com>

Change hashtable so that a callback function will decide whether a
variable can be overwritten, and possibly apply the changes.

So add a new field to struct hsearch_data:

 o "apply" callback function to check whether a variable can be
    overwritten, and possibly immediately apply the changes;
    when NULL, no check is performed.

And a new argument to himport_r():
 o "do_apply": whether to call the apply callback function

NOTE: This patch does not change the current behavior.
Signed-off-by: NGerlando Falauto <gerlando.falauto@keymile.com>
Reviewed-by: NMarek Vasut <marex@denx.de>

Add 2 new arguments to himport_r():

 o "nvars", "vars": number and list of variables to take into account
   (0 means ALL)

NOTE: This patch does not change the current behaviour.
Signed-off-by: NGerlando Falauto <gerlando.falauto@keymile.com>
Reviewed-by: NMarek Vasut <marex@denx.de>

The ethprime env var was missing from env_common.
Signed-off-by: NBenoît Thébaudeau <benoit.thebaudeau@advansee.com>
Cc: Wolfgang Denk <wd@denx.de>

This can be useful for generic scripts. For example, rather than hard-
coding a script to ext2load tegra-harmony.dtb, it could load
${soc}-${board}.dtb and hence not need adjustments to run on multiple
boards.
Signed-off-by: NStephen Warren <swarren@nvidia.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Signed-off-by: NTom Warren <twarren@nvidia.com>

These calls should not be made directly any more, since bootstage
will call the show_boot_...() functions as needed.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This changes over the network-related progress numbers to use enums
from bootstage.h.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Rather than the caller negating our progress numbers to indicate an
error has occurred, which seems hacky, add a function to indicate this.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Acked-by: NMike Frysinger <vapier@gentoo.org>

env_get_char_spec() function is duplicated across multiple environment
files.
Remove the duplication by providing a default implementation.
Add "weak" declaration, so the default implementation can be overridden.
Signed-off-by: NIgor Grinberg <grinberg@compulab.co.il>

Cleanup the env_common.c checkpatch warnings, errors and coding style.
Signed-off-by: NIgor Grinberg <grinberg@compulab.co.il>

Remove MK_STR from places that consume CONFIG_BOOTFILE to force all definitions to be string literals.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Remove MK_STR from places that consume CONFIG_ROOTPATH to force all definitions to be string literals.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Acked-by: NMike Frysinger <vapier@gentoo.org>

I can't see any obvious needs for the default environment to be writable,
so make it const.
Signed-off-by: NMike Frysinger <vapier@gentoo.org>

Currently, only basic completion is supported (no globs), but this is
what we had previously.
Signed-off-by: NMike Frysinger <vapier@gentoo.org>

The non-reentrant versions of the hashtable functions operate on a single
shared hashtable.  So if two different people try using these funcs for
two different purposes, they'll cause problems for the other.

Avoid this by converting all existing hashtable consumers over to the
reentrant versions and then punting the non-reentrant ones.
Signed-off-by: NMike Frysinger <vapier@gentoo.org>