Move CONFIG_VIDEO_MXS from board headers to Kconfig
and drop it from obsolete cfb_console driver.
Signed-off-by: NAnatolij Gustschin <agust@denx.de>
Reviewed-by: NFabio Estevam <festevam@gmail.com>

i.MX31 support was removed, and the non dm-video driver
is obsolete and not used. Remove it.
Signed-off-by: NAnatolij Gustschin <agust@denx.de>

After DM_VIDEO conversion the 'vidconsole' is the correct name
for the frame buffer console. 'video' will not work, so update
the description of the config option.
Signed-off-by: NAnatolij Gustschin <agust@denx.de>

Convert pixel values when necessary like we do for 16bpp
framebuffers.
Signed-off-by: NMark Kettenis <kettenis@openbsd.org>
Reviewed-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>

Recognize the canonical format strings for framebuffers in
30bpp mode and 32/24bpp mode.
Signed-off-by: NMark Kettenis <kettenis@openbsd.org>

Provide correct framebuffer information for 30bpp modes.
Signed-off-by: NMark Kettenis <kettenis@openbsd.org>

Add support for 30bpp mode where pixels are picked in 32-bit
integers but use 10 bits instead of 8 bits for each component.
Signed-off-by: NMark Kettenis <kettenis@openbsd.org>

- A large number of image file and tooling related cleanups

This function is far too long. Before trying to remove #ifdefs, split out
the code that deals with selecting the FDT into a separate function.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Move the variables declarations to where they are needed, to reduce the
number of #ifdefs needed.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Drop the #ifdefs which are easy to remove without refactoring.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Use boolean variables to deal with the strange #ifdef logic of this
function, so we can remove the #ifdefs.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This function is far too long. Before trying to remove #ifdefs, split out
the code that deals with selecting the ramdisk into a separate function.

Leave the code indented as it was for easier review. The next patch cleans
this up along with checkpatch violations.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Move the variables declarations to where they are needed, to reduce the
number of #ifdefs needed.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Remove ifdefs in this file, so far as possible without too much
refactoring.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Use a simple return to drop the unwanted code.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This file has a lot of conditional code and much of it is unnecessary.
Clean this up to reduce the number of build combinations.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This function is only used in one place and does not need to use the
preprocessor. Move it to the C file and convert it to a normal function.

Drop fit_unsupported() since it is not used.
Signed-off-by: NSimon Glass <sjg@chromium.org>

At present EFI_SECURE BOOT selects RSA but does not necessarily enable
FIT_SIGNATURE. Mostly this is fine, but a few boards do not enable it,
so U-Boot tries to do RSA verification when loading FIT images, but it
is not enabled.

This worked because the condition for checking the RSA signature is
wrong in the fit_image_verify_with_data() function. In order to fix it
we need to fix this dependency. Make sure that FIT_SIGNATURE is enabled
so that RSA can be used.

It might be better to avoid using 'select' in this situation.
Signed-off-by: NSimon Glass <sjg@chromium.org>

We can use the new host_build() function for this, so drop it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

This is not needed with Kconfig, since we can use IS_ENABLED() easily
enough. Drop it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

This is not needed with Kconfig, since we can use IS_ENABLED() easily
enough. Drop it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

This is not needed with Kconfig, since we can use IS_ENABLED() easily
enough and the board code is now in a separate file. Update the only place
where this is used and drop it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Add a host Kconfig for CRC32. With this we can use CONFIG_IS_ENABLED(CRC32)
directly in the host build, so drop the unnecessary indirection.

Add a few more conditions to SPL_CRC32 to avoid build failures as well as
TPL_CRC32. Also update hash.c to make crc32 optional and to actually take
notice of SPL_CRC32.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Add a host Kconfig for FIT_RSASSA_PSS. With this we can use
CONFIG_IS_ENABLED(FIT_RSASSA_PSS) directly in the host build, so drop the
forcing of this in the image.h header.

Drop the #ifdef around padding_pss_verify() too since it is not needed.
Use the compiler to check the config where possible, instead of the
preprocessor.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Add a host Kconfig for FIT_VERBOSE. With this we can use
CONFIG_IS_ENABLED(FIT_VERBOSE) directly in the tools build, so drop the
forcing of this in the image.h header.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Add a host Kconfig for OF_LIBFDT. With this we can use
CONFIG_IS_ENABLED(OF_LIBFDT) directly in the tools build, so drop the
unnecessary indirection.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Make use of the host Kconfig for FIT. With this we can use
CONFIG_IS_ENABLED(FIT) directly in the host build, so drop the unnecessary
indirection.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

We can use the __maybe_unused attribute to avoid some of the #ifdefs in
this file. Update the functions accordingly.

Note: The actual hashing interface is still a mess, with four separate
combinations and lots of #ifdefs. This should really use a driver
approach, e.g. as is done with partition drivers.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

At present when building host tools, we force CONFIG_SHAxxx to be enabled
regardless of the board Kconfig setting. This is done in the image.h
header file.

For SPL we currently just assume the algorithm is desired if U-Boot proper
enables it.

Clean this up by adding new Kconfig options to enable hashing on the host,
relying on CONFIG_IS_ENABLED() to deal with the different builds.

Add new SPL Kconfigs for hardware-accelerated hashing, to maintain the
current settings.

This allows us to drop the image.h code and the I_WANT_MD5 hack.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Unfortunately these were removed by mistake. This means that adding hash
support to SPL brings in all software algorithms, with a substantial
increase in code size.

The origin of the problem was renaming them to SPL_FIT_xxx and then these
were removed altogether in a later commit.

Add them back. This aligns with CONFIG_MD5, for example, which has an SPL
variant.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Fixes: f5bc9c25 ("image: Rename SPL_SHAxxx_SUPPORT to SPL_FIT_SHAxxx")
Fixes: eb5171dd ("common: Remove unused CONFIG_FIT_SHAxxx selectors")
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

In preparation for enabling CONFIG_IS_ENABLED() on the host build, add
some options to enable the various FIT options expected in these tools.
This will ensure that the code builds correctly when CONFIG_TOOLS_xxx
is distinct from CONFIG_xxx.

Drop some #ifdefs which are immediately unnecessary (many more are in
later patches).
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

At present we must separately test for the host build for many options,
since we force them to be enabled. For example, CONFIG_FIT is always
enabled in the host tools, even if CONFIG_FIT is not enabled by the
board itself.

It would be more convenient if we could use, for example,
CONFIG_IS_ENABLED(FIT) and get CONFIG_HOST_FIT, when building for the
host. Add support for this.

With this and the tools_build() function, we should be able to remove all
the #ifdefs currently needed in code that is build by tools and targets.

This will be even nicer when we move to using CONFIG(xxx) everywhere,
since all the #ifdef and IS_ENABLED/CONFIG_IS_ENABLED stuff will go away.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Suggested-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk> # b4f73886Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

With the new TOOLS_LIBCRYPTO and some other changes, it seems that we are
heading towards calling this a tools build rather than a host build,
although of course it does happen on the host.

I cannot think of anything built by the host which cannot be described as
a tool, so rename this function.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlexandru Gagniuc <mr.nuke.me@gmail.com>

Drop some more ifdefs in image-board.c and also the FPGA part of bootm.c
which calls into it.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Add a macro to handle manually relocating a pointer. Update the iamge code
to use this to avoid needing #ifdefs.

This also fixes a bug where the 'done' flag was not set.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Rather than adding an #ifdef and open-coding this calculation, add a
helper function to handle it. Use this in the image code.
Signed-off-by: NSimon Glass <sjg@chromium.org>

To avoid having #ifdefs in a few functions which are completely different
in the board and host code, create a new image-host.c file.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Tidy up the warnings.
Signed-off-by: NSimon Glass <sjg@chromium.org>

To avoid a large #ifdef in the image.c file, move the affected code into
a separate file.

Avoid any style fix-ups for easier review. Those are in the next patch.
Signed-off-by: NSimon Glass <sjg@chromium.org>