CONFIG_IS_ENABLED() takes the kconfig name without the CONFIG_ prefix,
e.g. CONFIG_IS_ENABLED(CLK) for CONFIG_CLK. Make including the prefix
an error in checkpatch.pl so calls in the wrong format aren't
accidentally reintroduced.
Signed-off-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Entirely disabling relocation of the device tree or initrd is almost
never the right answer.  Doing this by default leads to hard to diagnose
run-time failures.
Signed-off-by: NTom Rini <trini@konsulko.com>

These headers should not be included in other header files. Add a
checkpatch rule and test for this.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This warning should only be displayed for C files. Fix it and update the
test.
Signed-off-by: NSimon Glass <sjg@chromium.org>

While commit 048a6482 ("checkpatch.pl: Update to v5.7") largely
re-syncs us with checkpatch.pl from v5.7 there are a number of things
missing still.  Re-copy the script and again take care to keep our
allowed debug prints and now localized checks intact.

Fixes: 048a6482 ("checkpatch.pl: Update to v5.7")
Signed-off-by: NTom Rini <trini@konsulko.com>

All of our cmds have a Kconfig entry.  Making enabling a CMD via the
config file an error to checkpatch.pl.
Signed-off-by: NTom Rini <trini@konsulko.com>

There is a lot of use of #ifdefs in U-Boot. In an effort reduce this,
suggest using the compile-time construct.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This request is made with nearly every new command. Point to some docs
on how to do it.
Signed-off-by: NSimon Glass <sjg@chromium.org>

We want people to use the livetree API, so request it.
Signed-off-by: NSimon Glass <sjg@chromium.org>

A common problem when submitting a new uclass is to forget to add sandbox
tests. Add a warning for this.

Of course tests should always be added for new code, but this one seems to
be missed by nearly every new contributor.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Add an option to indicate that U-Boot-specific checks should be enabled.
Add a function to house the code that will be added.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Keep the U-Boot changes to $logFunctions
Signed-off-by: NSimon Glass <sjg@chromium.org>
[trini: Resync with v5.7 release which changed the default max line
 length, update commit to reflect]
Signed-off-by: NTom Rini <trini@konsulko.com>

The 'debug' and 'printf' functions were previously added to the list of
logFunctions in commit 0cab4211 ("checkpatch.pl: Add 'debug' to
the list of logFunctions") and commit 397bfd46 ("checkpatch.pl:
Add 'printf' to logFunctions") but these additions were lost when newer
versions of checkpatch were pulled in from the upstream Linux
kernel version.

This restores them so that you don't end up in a situation where
checkpatch will give a warning for "quoted string split across lines"
which you cannot fix without getting a warning for "line over 80
characters" instead.
Signed-off-by: NJames Byrne <james.byrne@origamienergy.com>

Update from upstream.

Just minor changes like checking that the author has also done a sign-off.
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>

Update scripts/checkpatch.pl from upstream.

One of the many corrections is not creating an error for cover-letters.

Reintroduce U-Boot's
5c761ce5
checkpatch.pl: Add warning for new __packed additions
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>

Allow prefixing typical strings with L for wide strings

Patch originally by Joe Perches
https://lkml.org/lkml/2017/10/17/1117Signed-off-by: NJoe Perches <joe@perches.com>
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>

While there are valid reasons to use __packed, often the answer is that
you should be doing something else here instead.

This reintroduces the changes of
f503cc49 (Add warning for new __packed additions)
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>

Checkpatch produces the following warning:

Unescaped left brace in regex is deprecated here
(and will be fatal in Perl 5.30), passed through in regex;
marked by <-- HERE in m/^(\+.*(?:do|\))){ <-- HERE /
at scripts/checkpatch.pl line 3348.

The curent checkpatch of the Linux kernel corrects this
bug and many others.

It provides improved colored output.

So replace checkpatch by the current Linux version.

Add an empty file scripts/const_structs.checkpatch.
We can later fill it according to our needs.
Signed-off-by: NHeinrich Schuchardt <xypron.glpk@gmx.de>

Pick commit 66b47b4a9dad0 checkpatch: look for common misspellings
from the Linux kernel for spelling check from Kees Cook

In addition pulled in additional changes
commit ebfd7d6237531 checkpatch: add optional --codespell dictionary to find more typos
from the Linux kernel for codespell from Joe Perches

commit f1a63678554f8 checkpatch: remove local from codespell path
from the Linux kernel for dictionary path from Maxim Uvarov
Signed-off-by: NDan Murphy <dmurphy@ti.com>
Reviewed-by: NTom Rini <trini@konsulko.com>

Fix various misspellings of:

 * deprecated
 * partition
 * preceding,preceded
 * preparation
 * its versus it's
 * export
 * existing
 * scenario
 * redundant
 * remaining
 * value
 * architecture
Signed-off-by: NRobert P. J. Day <rpjday@crashcourse.ca>
Reviewed-by: NJagan Teki <jteki@openedev.com>
Reviewed-by: NStefan Roese <sr@denx.de>

using checkpatch with Perl 5.22.0 generates a warning,
this is fixed in linux through commit:

commit 4e5d56bdf892e18832a6540b63ebf709966bce2a
Author: Eddie Kovsky <ewk@edkovsky.org>
Date:   Wed Sep 9 15:37:52 2015 -0700

checkpatch: fix left brace warning

Using checkpatch.pl with Perl 5.22.0 generates the following warning:

Unescaped left brace in regex is deprecated, passed through in regex;

This patch fixes the warnings by escaping occurrences of the left brace
inside the regular expression.

Adapt it for U-Boot.
Signed-off-by: NHeiko Schocher <hs@denx.de>

Pick the following commit from Linux kernel:
commit 66cb4ee0e52ca721f609fd5eec16187189ae5fda
Author: Joe Perches <joe@perches.com>
Date:   Wed Sep 10 09:40:47 2014 +1000

checkpatch: remove unnecessary + after {8,8}

There's a useless "+" use that needs to be removed as perl 5.20 emits a
"Useless use of greediness modifier '+'" message each time it's hit.
Signed-off-by: NMarek Vasut <marex@denx.de>
Cc: Tom Rini <trini@ti.com>

Update to v3.14-rc4's version of checkpatch.pl.  In doing so we drop the
changes to top_of_kernel_tree() as we pass in --no-tree and drop our
changes about MAINTAINERS as that's for reporting checkpatch.pl problems
itself (and upstream has said they'll reword this section to be
clearer).
Signed-off-by: NTom Rini <trini@ti.com>

While there are valid reasons to use __packed, often the answer is that
you should be doing something else here instead.
Signed-off-by: NTom Rini <trini@ti.com>

We have some scripts imported from Linux Kernel:
setlocalversion, checkstack.pl, checkpatch.pl, cleanpatch

They are located under tools/ directory in U-Boot now.
But they were originally located under scripts/ directory
in Linux Kernel.

This commit moves them to the original location.

It is true that binutils-version.sh and dtc-version.sh
do not originate in Linux Kernel, but they should
be moved by analogy to gcc-version.sh.
Signed-off-by: NMasahiro Yamada <yamada.m@jp.panasonic.com>

Signed-off-by: NRoger Meier <roger@bufferoverflow.ch>

Signed-off-by: NTom Rini <trini@ti.com>

While the kernel mainly uses pr_debug(...), etc, for debug messages, we
use debug(...).  Add this to the list of logFunctions so that they are
correctly checked (and not warned against) for long string literals.
Signed-off-by: NTom Rini <trini@ti.com>

i.e., from the linux kernel's commit
be987d9f80354e2e919926349282facd74992f90
Signed-off-by: NKim Phillips <kim.phillips@freescale.com>

This tests for a bad habits of mine like this:

	return 0 ;
Signed-off-by: NEric Nelson <eric.nelson@boundarydevices.com>

Added from Linux - commit 30ecad51849ae132dc6ef6ddb62d499c7257515b

Include config file to ignore common false-positives
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Cc: Joe Hershberger <joe.hershberger@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>