Changes to NetState now go through an accessor function called
net_set_state()
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Use this entry-point consistently across the net/ code
Use a static inline function to preserve code size
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

There is no need to call through the handler... inline it
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Eliminate pointer subtraction that recovers values computed earlier
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Save the length when it is computed instead of forgetting it and
subtracting pointers to figure it out again.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Share more of the code that is common between ARP vs not.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

ICMP (ping) was reimplementing IP header code... it now shares code.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Use field names and sizes when accessing ARP packets
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Renamed for clarity
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Easier to find when alphabetized
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Clearer constant name.
Also remove related BOOTP_SIZE which was unused and doesn't take
into account VLAN packets.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

This is not called as a handler, so don't name it that way
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

x is a poor variable name
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Make the comment more accurate about the header including SNAP
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

This name more explicitly claims that it does not include the
header size
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Remove typedef and lower-case name
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Remove typedef and lower-case letters
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Eliminate the typedef and remove capital letters
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Separate the Ethernet header from the 802 header.
Base the size constants on the structs.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Add a structure that only contains IP header fields to be used by
functions that don't need UDP
Rename IP_HDR_SIZE_NO_UDP to IP_HDR_SIZE
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Rename IP header related things to IP_UDP. The existing definition
of IP_t includes UDP header, so name it to accurately describe the
structure.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Separate this functionality out of the net.c behemoth
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Separate this functionality out of the net.c behemoth
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Separate this functionality out of the net.c behemoth
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Checking for CDP packets should be encapsulated, not copied code.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Separate this functionality out of the net.c behemoth
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Make the MAC-seeded random number generator available to /net in
general.  MAC-seeded rand will be needed by link-local as well, so
give it an interface.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

Some boards claim to need ping, but don't support net.
That makes no sense, and causes problems now that ping
is in a separate file.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NSimon Glass <sjg@chromium.org>

These are all the files which use the API incorrectly but did not get
built using MAKEALL -a powerpc|arm.  I have no compiler for them, but
the remaining issues should be far less than without this patch.

Any outstanding issues are left to the maintainers of boards that use
these drivers.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix this:
rtl8169.c: In function 'rtl8169_initialize':
rtl8169.c:907:13: warning: assignment from incompatible pointer type
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix this:
pcnet.c: In function 'pcnet_initialize':
pcnet.c:224:13: warning: assignment from incompatible pointer type
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix this:
ether_scc.c: In function 'mpc82xx_scc_enet_initialize':
ether_scc.c:377:14: warning: assignment from incompatible pointer type
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix this:
xilinx_axi_emac.c: In function 'xilinx_axiemac_initialize':
xilinx_axi_emac.c:646: warning: assignment from incompatible pointer type
Signed-off-by: NStephan Linz <linz@li-pro.net>

Fix this:
xilinx_emaclite.c: In function 'xilinx_emaclite_initialize':
xilinx_emaclite.c:371: warning: assignment from incompatible pointer type
Signed-off-by: NStephan Linz <linz@li-pro.net>

Fix this:
xilinx_ll_temac.c: In function 'xilinx_ll_temac_initialize':
xilinx_ll_temac.c:332: warning: assignment from incompatible pointer type
xilinx_ll_temac.c:340: warning: assignment from incompatible pointer type
Signed-off-by: NStephan Linz <linz@li-pro.net>

Some copy/pasted drivers redefine functions
defined in include/net.h.  Remove these so that
the definitions can be changed without error.
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>
Acked-by: NMike Frysinger <vapier@gentoo.org>

Fix this:
uec.c: In function 'uec_initialize':
uec.c:1404:12: warning: assignment from incompatible pointer type
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix this:
uli526x.c: In function 'uli526x_initialize':
uli526x.c:243:13: warning: assignment from incompatible pointer type
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>

Fix this:
tsi108_eth.c: In function 'tsi108_eth_initialize':
tsi108_eth.c:745:13: warning: assignment from incompatible pointer type
tsi108_eth.c: In function 'tsi108_eth_recv':
tsi108_eth.c:989:4: warning: passing argument 1 of 'NetReceive' discards qualifiers from pointer target type
Signed-off-by: NJoe Hershberger <joe.hershberger@ni.com>