This converts the following to Kconfig:
   CONFIG_PHY_RESET_DELAY

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_SYS_RX_ETH_BUFFER

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_LPC32XX_ETH

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_TFTP_PORT

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_RMII

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_SYS_FAULT_ECHO_LINK_DOWN

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_RESET_PHY_R

Cc: Ramon Fried <rfried.dev@gmail.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_AT91_WANTS_COMMON_PHY

Cc: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

This converts the following to Kconfig:
   CONFIG_AT91_LED

Cc: Eugen Hristev <eugen.hristev@microchip.com>
Signed-off-by: NTom Rini <trini@konsulko.com>

binman FIT improvements
various minor sandbox improvements

Some boards need to load an ELF file using the 'loadables' property, but
the file has segments at different memory addresses. This means that it
cannot be supplied as a flat binary.

Allow generating a separate node in the FIT for each segment in the ELF,
with a different load address for each.

Also add checks that the fit,xxx directives are valid.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Acked-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

The current implementation sets up the FIT entries but then deletes the
'generator' ones so they don't appear in the final image.

This is a bit clumsy. We cannot build the image more than once, since the
generator entries are lost during the first build. Binman requires that
calling BuildSectionData() multiple times returns a valid result each
time.

Keep a separate, private list which includes the generator nodes and use
that where needed, to correct this problem. Ensure that the missing list
includes removed generator entries too.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

It doesn't make sense to use 'subnode' as a function parameter since it
is just a 'node' so far as the function is concerned. Update two functions
to use 'node' instead.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Add a new function to handling reporting errors within a particular
subnode of the FIT description. This can be used to make the format of
these errors consistent.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Some warnings have crept in, so fix those that are easy to fix.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

This should not be done in the constructor. Move it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

At present the entries are read twice, once by the entry_Section class
and once by the FIT implementation. This is harmless but can be confusing
when debugging. Fix it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Unfortunately mkimage gets upset with zero-sized files. Update the
ObtainContents() method to support specifying the size, if a fake blob is
created.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

On x86 devices having even a small amount of data can cause an overlap
between regions. For example, bayleybay complains when the intel-vga
region overlaps with u-boot-ucode:

   ImagePos    Offset      Size  Name
   <none>    00000000  00800000  main-section
   <none>     ff800000  00000080  intel-descriptor
   <none>     ff800400  00000080  intel-me
   <none>     fff00000  00098f24  u-boot-with-ucode-ptr
   <none>     fff98f24  00001aa0  u-boot-dtb-with-ucode
   <none>     fff9a9d0  0002a000  u-boot-ucode
   <none>     fffb0000  00000080  intel-vga
   ...

It is safer to use an empty file in most cases. Add an option to set the
size for those uses that need it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

At present fake blobs are created but internally an empty blob is used.
Change it to use the contents of the faked file. Also return whether the
blob was faked, in case the caller needs to know that.

Add a TODO to put fake blobs in their own directory.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

This shadows the patman.tools library so rename it to avoid a pylint
warning.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

At present the fit implementation creates the output tree while
scanning the FIT description. Then it updates the tree later when the
data is known.

This works, but is a bit confusing, since it requires mixing the scanning
code with the generation code, with a fix-up step at the end.

It is actually possible to do this in two phases, one to scan everything
and the other to generate the FIT. Thus the FIT is generated in one pass,
when everything is known.

Update the code accordingly. The only functional change is that the 'data'
property for each node are now last instead of first, which is really a
more natural position. Update the affected test to deal with this.

One wrinkle is that the calculated properties (image-pos, size and offset)
are now added before the FIT is generated. so we must filter these out
when copying properties from the binman description to the FIT.

Most of the change here is splitting out some of the code from the
ReadEntries() implementation into _BuildInput(). So despite the large
diff, most of the code is the same. It is not feasible to split this patch
up, so far as I can tell.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Leave the 'expand' term for use by entry types which have an expanded
version of themselves. Rename this method to indicate that it generates
subentries.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

The word 'expand' is used for entries which generate subentries. It is
also used for entries that can have an '_expanded' version which is used
to break out its contents.

Rather than talking about expanding an entry's size, use the term
'extending'. It is slightly more precise and avoids the above conflicts.

This change renders the old 'expand-size' property invalid, so add an
error check for that.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Update the return value of this function, fix the 'create' typo and
update the documentation for clarity.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Rename this function to make it clear that it only reads loadable
segments. Also update the error for missing module to better match the
message emitted by Python.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Refactor this to avoid a loop. Also add a test for an empty string.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Fix the help which should refer to TPL, not SPL.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

Simplify the code by using the available function.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

This is not necessary if simpler code is used. Use the split function and
drop the unnecessary []
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

At present it is not possible to have arguments which include spaces.
Update the function to only split the args if the property is a single
string. This is a bit inconsistent, but might still be useful.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reviewed-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>
Suggested-by: NAlper Nebi Yasak <alpernebiyasak@gmail.com>

It is good practice to init all variables in the constructor and pylint
sometimes checks this. Fix it.
Signed-off-by: NSimon Glass <sjg@chromium.org>
Reported-by: NTom Rini <trini@konsulko.com>

Use the new sandbox_find_next_phase() function, which does what is needed
here.
Signed-off-by: NSimon Glass <sjg@chromium.org>

There is seldom a need to refresh at 100Hz and it uses a lot of CPU.
Reduce the rate to 10Hz which seems to be adequate.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Some files cannot be written but read-only access is still useful for
tests. Add a fallback to read-only access when needed.

This is useful in CI when opening a large data file provided by docker,
where read/write access would result in copying the file, thus needing
a lot of extra disk space.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This defines a function declared in handoff.h so add the header.
Signed-off-by: NSimon Glass <sjg@chromium.org>

If state is not being written, but RAM is, we should still show a message,
so it is clear that this is happening.
Signed-off-by: NSimon Glass <sjg@chromium.org>

This allows to prefill fdt and config nodes with hash and signature
subnodes. It's just important to place the child nodes last so that
hashes do not come before the data - would be disliked by mkimage.
Signed-off-by: NJan Kiszka <jan.kiszka@siemens.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Adds build-sandbox in sys.path to look for libfdt,
otherwise py_test can't use binman.
Signed-off-by: NPhilippe Reynes <philippe.reynes@softathome.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

Add coverage for the new elf functions needed for the event_dump.py
script.
Signed-off-by: NSimon Glass <sjg@chromium.org>