At present buildman sets the python path on startup so that it can access
the libraries it needs. If we convert to use absolute imports this is not
necessary.

Move buildman to use absolute imports. Also adjust moveconfig.py too since
it uses some buildman modules and cannot work without this.
Signed-off-by: NSimon Glass <sjg@chromium.org>

The naming is slightly different on kernel.org now. Update the regex so
that the test still passes.
Signed-off-by: NSimon Glass <sjg@chromium.org>

These are becoming more common now. They cause boards to show warnings
which can be mistaking for compiler warnings.

Add a buildman option to ignore them. This option works only with the
summary option (-s). It does not affect the build process.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Unfortunately the plague of device-tree warnings has not lifted. These
warnings infiltrate almost every build, adding noise and confusion.

Add a buildman option to ignore them. This option works only with the
summary option (-s). It does not affect the build process.
Signed-off-by: NSimon Glass <sjg@chromium.org>

When buildman finishes it leaves the last summary line visible, which
shows the number of successful builds, builds with warnings and builds
with errors.

It is useful also to see how many builds were done in total along with
the time taken. Show these on a separate line before buildman finishes.
Signed-off-by: NSimon Glass <sjg@chromium.org>

At present the board names shown with -l are separated by commas. This
makes it hard to double-click to select a particular board. Also it is not
possible to select all boards and paste them as arguments to a subsequent
buildman run, since buildman requires spaces to separate the list on the
command line, not commas.

Change the output format to use spaces instead of commas.
Signed-off-by: NSimon Glass <sjg@chromium.org>

It is quite hard to see the list of board for each error line since the
colour is the same as the actual error line. Show the board list in
magenta so that it is easier to distinguish them.

There is no point in checking the colour of the overall line, since there
are now multiple colours. So drop those tests.
Signed-off-by: NSimon Glass <sjg@chromium.org>

At present warnings are shown in yellow in the summary (-s) but magenta in
the detail listing (-e). Use yellow in both.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Add a test to cover this flag, which adds the name of each board to each
error/warning line.
Signed-off-by: NSimon Glass <sjg@chromium.org>

The split/join code is repeated in a lot of places. Add a function to
handle this.
Signed-off-by: NSimon Glass <sjg@chromium.org>

We want to add a few more tests similar to testOutput(). Split its logic
into a function which runs buildman to get the output and another which
checks the output. This will make it easier to reuse the code.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Rather than having a few tests handle this themselves, create the
temporary directory in the setUp() method and remove it in tearDown().
This will make it easier to add more tests.

Only testOutput and testGit() actually need it, but it doesn't add to the
test time noticeably to do this for all tests in this file.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Rather than using the absolute array index, use an interator to work
through the expected output lines. This is easier to follow.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Buildman should output the right colours for each error/warning line. Some
of these checks are missing. Add them.
Signed-off-by: NSimon Glass <sjg@chromium.org>

At present buildman removes any directory it doesn't intend to write
output into. This is overly expansive since if the output directory
happens to be somewhere with existing files, they may be removed. Using
an existing directory for buildman is not a good practice, but since the
result might be catastrophic, it is best to guard against it.

A previous commit[1] fixed this by refusing to write to a subdirectory
of the current directory, assumed to have U-Boot source code. But we can
do better by only removing directories that look like the ones buildman
creates.

Update the code to do this and add a test.
Signed-off-by: NSimon Glass <sjg@chromium.org>

[1] 409fc029 tools: buildman: Don't use the working dir as build dir

Sometimes it is useful for external tools to use buildman to provide the
toolchain information. Add an -a option which shows the value to use for
the ARCH environment variable, and -A which does the same for
CROSS_COMPILE
Signed-off-by: NSimon Glass <sjg@chromium.org>

Convert buildman to Python 3 and make it use that, to meet the 2020
deadline.
Signed-off-by: NSimon Glass <sjg@chromium.org>

In the 'Make' function, the codes tries to create a directory
if current stage is 'build'. But the directory isn't used at
all anywhere.
Signed-off-by: NBin Meng <bmeng.cn@gmail.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>

At present we should boards with warnings in the same way as those with
errors. This is not ideal. Add a new 'warn' state and show these listed
in yellow to match the actual warning lines printing with -e.
Signed-off-by: NSimon Glass <sjg@chromium.org>

At present messages from the device-tree compiler like this:

  arch/arm/dts/socfpga_arria10_socdk_sdmmc.dtb: Warning
     (avoid_unnecessary_addr_size): /clocks: unnecessary
     #address-cells/#size-cells without "ranges" or child "reg" property

are detected as errors since they don't match the gcc warning regex. Add a
new one for dtc to fix this.
Signed-off-by: NSimon Glass <sjg@chromium.org>

At present 'buildman sandbox' will build all 5 boards for the sandbox
architecture rather than the single board 'sandbox'. The only current way
to exclude sandbox_spl, sandbox_noblk, etc. is to use -x which is a bit
clumbsy.

Add a --boards option to allow individual build targets to be specified.
Signed-off-by: NSimon Glass <sjg@chromium.org>

There are a few test cases which print output. Suppress this so that tests
can run silently in the normal case.
Signed-off-by: NSimon Glass <sjg@chromium.org>

The filenames of the toolchains on kernel.org changes every now and then.
Fix it for the current change, and make the test use a regex so that it
has a better chance of passing with future changes too.
Signed-off-by: NSimon Glass <sjg@chromium.org>

When U-Boot started using SPDX tags we were among the early adopters and
there weren't a lot of other examples to borrow from.  So we picked the
area of the file that usually had a full license text and replaced it
with an appropriate SPDX-License-Identifier: entry.  Since then, the
Linux Kernel has adopted SPDX tags and they place it as the very first
line in a file (except where shebangs are used, then it's second line)
and with slightly different comment styles than us.

In part due to community overlap, in part due to better tag visibility
and in part for other minor reasons, switch over to that style.

This commit changes all instances where we have a single declared
license in the tag as both the before and after are identical in tag
contents.  There's also a few places where I found we did not have a tag
and have introduced one.
Signed-off-by: NTom Rini <trini@konsulko.com>

The tests were broken by two separate commits which adjusted the output
when boards are listed. Fix this by adding back a PowerPC board and
putting the name of each board in the test.

Fixes: b9f7d881 (powerpc, 5xx: remove some "5xx" remains)
Fixes: 8d7523c5 (buildman: Allow showing the list of boards with -n)
Signed-off-by: NSimon Glass <sjg@chromium.org>

Accessing the network slows down the test and limits the environment in
which it can be run. Add an option to disable network tests.
Signed-off-by: NSimon Glass <sjg@chromium.org>

we removed 5xx support. So delete some forgotten remains.
Signed-off-by: NHeiko Schocher <hs@denx.de>

Make it clear when buildman actually starts building. This happens when it
has prepared the threads, working directory and output directories.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Also read gcc 4.9.0 at kernel.org which also have Microblaze toolchain.
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Acked-by: NSimon Glass <sjg@chromium.org>
Tested-by: NSimon Glass <sjg@chromium.org>

Fixed unit test failure by updating the test:
Signed-off-by: NSimon Glass <sjg@chromium.org>

Tweak the output slightly so we don't get things like:

   - board1 board2+  board3 board4

There should be a space before the '+'.
Signed-off-by: NSimon Glass <sjg@chromium.org>

The site at https://www.kernel.org/pub/tools/crosstool/ is a convenient
repository of toolchains which can be used for U-Boot. Add a feature to
download and install a toolchain for a selected architecture automatically.

It isn't clear how long this site will stay in the current place and
format, but we should be able to rely on bug reports if it changes.
Suggested-by: NMarek Vašut <marex@denx.de>
Suggested-by: NFabio Estevam <festevam@gmail.com>
Signed-off-by: NSimon Glass <sjg@chromium.org>

Some archs have need than one alias, so support a list of alises in the
..buildman file.
Signed-off-by: NSimon Glass <sjg@chromium.org>

We should create a test setting file when running testes, not use whatever
happens to be on the local machine.
Signed-off-by: NSimon Glass <sjg@chromium.org>

When building current source for a single board, buildman puts the output
in <output_dir>/current/current/<board>. Add an option to make it use
<output_dir>/<board> instead. This removes the unnecessary directories
in that case, controlled by the --no-subdirs/-N option.
Suggested-by: NTom Rini <trini@ti.com>
Signed-off-by: NSimon Glass <sjg@chromium.org>

Add a few tests of the output directory logic.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Now that buildman supports removing the build directory prefix from output,
add a test for it. Also ensure that output directories are removed when the
test completes.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Adjust the basic test so that it checks all console output. This will help
to ensure that the builder is behaving correctly with printing summary
information.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Currently buildman allows a list of boards to build to be specified on the
command line. The list can include specific board names, architecture, SOC
and so on.

At present the list of boards is dealt with in an 'OR' fashion, and there
is no way to specify something like 'arm & freescale', meaning boards with
ARM architecture but only those made by Freescale. This would exclude the
PowerPC boards made by Freescale.

Support an '&' operator on the command line to permit this. Ensure that
arguments can be specified in a single string to permit easy shell quoting.
Suggested-by: NYork Sun <yorksun@freescale.com>
Signed-off-by: NSimon Glass <sjg@chromium.org>
Acked-by: NYork Sun <yorksun@freescale.com>

The non-incremental build method is no longer used, so remove it.
Signed-off-by: NSimon Glass <sjg@chromium.org>

Normally buildman operates in two passes - one to do the build and another
to summarise the errors. Add a verbose option (-v) to display build problems
as they happen. With -e also given, this will display errors too.

When building the current source tree (rather than a list of commits in a
branch), both -v and -e are enabled automatically.
Signed-off-by: NSimon Glass <sjg@chromium.org>