提交 ac71d410 编写于 作者: M Michal Simek 提交者: Tom Rini

tools: mkimage: Call fclose in error path

This patch is fixing missing fclose() calls
in error patch introduced by:
"tools: mkimage: Use fstat instead of stat to avoid malicious hacks"
(sha1: ebe0f53f)

Reported-by: Coverity (CID: 155064, 155065)
Signed-off-by: NMichal Simek <michal.simek@xilinx.com>
Reviewed-by: NSimon Glass <sjg@chromium.org>
上级 d0cf5512
......@@ -239,11 +239,15 @@ static void zynqimage_parse_initparams(struct zynq_header *zynqhdr,
}
err = fstat(fileno(fp), &path_stat);
if (err)
if (err) {
fclose(fp);
return;
}
if (!S_ISREG(path_stat.st_mode))
if (!S_ISREG(path_stat.st_mode)) {
fclose(fp);
return;
}
do {
r = fscanf(fp, "%x %x", &reginit.address, &reginit.data);
......
......@@ -251,11 +251,15 @@ static void zynqmpimage_parse_initparams(struct zynqmp_header *zynqhdr,
}
err = fstat(fileno(fp), &path_stat);
if (err)
if (err) {
fclose(fp);
return;
}
if (!S_ISREG(path_stat.st_mode))
if (!S_ISREG(path_stat.st_mode)) {
fclose(fp);
return;
}
do {
r = fscanf(fp, "%x %x", &reginit.address, &reginit.data);
......
Markdown is supported
0% .
You are about to add 0 people to the discussion. Proceed with caution.
先完成此消息的编辑!
想要评论请 注册